Update liblouis to 3.12, compile with Clang on Visual Studio 2019#10275
Merged
Conversation
Collaborator
Author
Member
|
We are going to leave switching to VS2019 and this pr until after 2019.3. Instead we will take pr #10168 for now. |
This comment has been minimized.
This comment has been minimized.
Contributor
|
As Liblouis 3.12 has been released it makes sense to update to it directly skipping 3.11. |
Collaborator
Author
|
Yup, we'll do that.
|
Contributor
|
Hi, Let's get this PR going again. Thanks. |
michaelDCurran
approved these changes
Feb 16, 2020
michaelDCurran
added a commit
that referenced
this pull request
Feb 16, 2020
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Note: this draft is based on #10169 and can be rebased on master when that pr is merged.
Link to issue number:
Closes #10161
Closes #10094
Closes #9526
Summary of the issue:
Liblouis 3.12.0 has been released. Unfortunately, starting from version 3.11, liblouis drops compatibility with Microsoft Visual C++ as it now uses C99 dynamic arrays, which are not supported on MSVC
Description of how this pull request fixes the issue:
Use the clang toolset to build Liblouis instead. Note that, where msvc does assume the sdcall calling convention, clang does not.
Testing performed:
Tested locally AS WELL AS ON APPVEYOR WITH A TRY BUILD
Known issues with pull request:
None known, though as this is a major under the hood change, it needs to be tested carefully.
Change log entry: