Hi! Can you see which commit gives us the improvements to polish tables, grade 1 or 2? From: Leonard de Ruijter <notifications@github.com> Sent: Friday, September 6, 2019 1:51 PM To: nvaccess/nvda <nvda@noreply.github.com> Cc: Subscribed <subscribed@noreply.github.com> Subject: [nvaccess/nvda] Update liblouis to commit 58d67e63 (#10168) Link to issue number: None Summary of the issue: The python 3 transition caused a regression for liblouis, printing unicode surrogate characters like \ud83d cause an UnicodeEncodeError, You can easily trigger this issue by reading the following line: � Description of how this pull request fixes the issue: Updates liblouis to a commit that has a fix for this. This is a commit post 3.10, also applying the following fixes: * Don't let a caps passage end on a word with no letters * Handle word resets in the last word of an caps or emphasis passage if the end indicator was placed before the word- Never convert to lowercase if capsletter is not defined * Fix position mapping for back-translation when noUndefinedDots mode is active * Fix an issue with ordinal numbers inside caps passages in Dutch braille * Improved back-translation for Mongolian Testing performed: Tested the case above, the issue does no longer occur and liblouis prints the hexadecimal representation of the surrogate character, as expected. Known issues with pull request: This does not update to liblouis 3.11, see #10161 <#10161> Change log entry: * Changes * Updated Liblouis braille translator to commit 58d67e63

@LeonarddeR can you do that? From: Leonard de Ruijter <notifications@github.com> Sent: Friday, September 6, 2019 2:56 PM To: nvaccess/nvda <nvda@noreply.github.com> Cc: zstanecic <zvonimirek222@yandex.com>; Comment <comment@noreply.github.com> Subject: Re: [nvaccess/nvda] Update liblouis to commit 58d67e63 (#10168) This is c870f23c63dc3a2eed9e025d3bbf63de175f00cb I actually discovered that we could also go to 146c0757b91c186742922b8e0f4e2f8f4a8350cc, which is the last merge commit before the MSVC incompatible code was merged. That will include the changes to Polish and will also fix the double underscores bug. — You are receiving this because you commented. Reply to this email directly, view it on GitHub <#10168?email_source=notifications&email_token=ACVCDE6DKCXLSGAMRF3POYTQIJHMPA5CNFSM4IUIEY22YY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGOD6CYESA#issuecomment-528843336> , or mute the thread <https://github.com/notifications/unsubscribe-auth/ACVCDE5UN5RGXRXEGEM2YELQIJHMPANCNFSM4IUIEY2Q> . <https://github.com/notifications/beacon/ACVCDE6CHWDAJAF3XPSGWFLQIJHMPA5CNFSM4IUIEY22YY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGOD6CYESA.gif>

So i am against any compromises. We should go with the big dependency change, no matter how it is big, as it fixe salso accessibility, as well as security issues in Ll. I don’t know what others say, but we should keep improvements going, even if it is a small table improvement for output/imput. The real showstopper question is: what forces us to stay on MSVC 2017 and not switch to 2019 completely which fixes the c99 with clang dependency? Yes, the local building environments, but this is the problem of the developer itself. He needs to maintain his development env up to date. That’s just my opinion… From: Leonard de Ruijter <notifications@github.com> Sent: Friday, September 6, 2019 3:20 PM To: nvaccess/nvda <nvda@noreply.github.com> Cc: zstanecic <zvonimirek222@yandex.com>; Comment <comment@noreply.github.com> Subject: Re: [nvaccess/nvda] Update liblouis to commit 58d67e63 (#10168) I actually discovered that we could also go to 146c0757b91c186742922b8e0f4e2f8f4a8350cc, which is the last merge commit before the MSVC incompatible code was merged. That will include the changes to Polish and will also fix the double underscores bug. Ugh, I was wrong there, I'm sorry for creating wrong expectations here. — You are receiving this because you commented. Reply to this email directly, view it on GitHub <#10168?email_source=notifications&email_token=ACVCDE6U2523KPTGDD36GP3QIJKI3A5CNFSM4IUIEY22YY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGOD6C2FCA#issuecomment-528851592> , or mute the thread <https://github.com/notifications/unsubscribe-auth/ACVCDEZO4CGWMOOZFSHWXHDQIJKI3ANCNFSM4IUIEY2Q> . <https://github.com/notifications/beacon/ACVCDE3DYM4JXN6QPGWJQS3QIJKI3A5CNFSM4IUIEY22YY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGOD6C2FCA.gif>

I settled on the commit in the description and title of the pr. I think it is ready to be reviewed/merged if we agree that this is the right way to go, i.e. stick with 3.10 with patches instead of going the liblouis 3.11 with vs2019 and clang route.