This repository was archived by the owner on Apr 17, 2026. It is now read-only.
add locale.t2tconf as a translatable file#83
Merged
Merged
Conversation
9 tasks
michaelDCurran
approved these changes
Mar 24, 2023
seanbudd
added a commit
to nvaccess/nvda
that referenced
this pull request
Mar 27, 2023
Supersedes #13133 Closes #8856 with nvaccess/mrconfig#83 Summary of the issue: The generated HTML from t2t (changes, quick reference, user guide) has no lang attribute set. So, it will not read in the correct TTS language. Right to left languages also do not render correctly without an dir="rtl" attribute. Description of user facing changes When translators add values to the attributes, the correct TTS language will be used when reading NVDA documentation and the layout direction of text will be appropriate. Description of development approach PR to mrconfig to support locale.t2tconf: add locale.t2tconf as a translatable file in nvaccess/mrconfig#83 Create a base template for translators to add their own lang and dir attribute values.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes nvaccess/nvda#14169
Relates to nvaccess/nvda#8856, and closes the issue with nvaccess/nvda#14546
locale.t2tconfallows translators to set the locale and layout direction of NVDA user documentationlocale.t2tconffiles cannot be modified by translators, and are expected to be modified in the main NVDA repository.This is an unexpected workflow for translators, they should be able to push changes to
locale.t2tconf.Testing
What is the best way to test this script?