Rename into decimal to into float#9979
Conversation
|
I think we need to have both |
|
Circling back to this, I think more generally we want to move away from |
Keep `into decimal`. Add a warning that it will be removed in the `0.86` release
51b83a0 to
0123986
Compare
|
Gave it the same |
Co-authored-by: Darren Schroeder <343840+fdncred@users.noreply.github.com>
fdncred
left a comment
There was a problem hiding this comment.
I like it this move. Makes me wonder if we're using decimal anywhere else improperly.
You bet, we have |
Co-authored-by: Darren Schroeder <343840+fdncred@users.noreply.github.com>
Mention the deprecated state
Similar to nushell#9979 `random decimal` will now raise a warning and can be removed in an upcoming release. New command is named `random float` Tests updated and improved.
|
@sholderbach |
# Description Similar to #9979 # User-Facing Changes `random decimal` will now raise a warning and can be removed in an upcoming release. New command is named `random float` # Tests + Formatting Tests updated and improved.
# Description We made the decision that our floating point type should be referred to as `float` over `decimal`. Commands were updated by #9979 and #10320 Now make the internal codebase consistent in referring to this data type as `float`. Work for #10332 # User-Facing Changes `decimal` has been removed as a type name/symbol. Instead of ```nushell def foo [bar: decimal] decimal -> decimal {} ``` use ```nushell def foo [bar: float] float -> float {} ``` Potential effect of `SyntaxShape`'s `Display` implementation now also referring to `float` instead of `decimal` # Details - Rename `SyntaxShape::Decimal` to `Float` - Update `Display for SyntaxShape` to `float` - Update error message + fn name in dataframe code - Fix docs in command examples - Rename tests that are float specific - Update doccomment on `SyntaxShape` - Update comment in script # Tests + Formatting Updates the names of some tests
# Description We keep "into decimal" for a release and warn through a message that it will be removed in 0.86. All tests are updated to use `into float` # User-Facing Changes `into decimal` raises a deprecation warning, will be removed soon. Use `into float` as the new functionally identical command instead. ``` ~/nushell> 2 | into decimal Error: × Deprecated command ╭─[entry #1:1:1] 1 │ 2 | into decimal · ──────┬───── · ╰── `into decimal` is deprecated and will be removed in 0.86. ╰──── help: Use `into float` instead 2 ``` # Tests + Formatting Updated --------- Co-authored-by: Darren Schroeder <343840+fdncred@users.noreply.github.com>
# Description Similar to nushell#9979 # User-Facing Changes `random decimal` will now raise a warning and can be removed in an upcoming release. New command is named `random float` # Tests + Formatting Tests updated and improved.
# Description We made the decision that our floating point type should be referred to as `float` over `decimal`. Commands were updated by nushell#9979 and nushell#10320 Now make the internal codebase consistent in referring to this data type as `float`. Work for nushell#10332 # User-Facing Changes `decimal` has been removed as a type name/symbol. Instead of ```nushell def foo [bar: decimal] decimal -> decimal {} ``` use ```nushell def foo [bar: float] float -> float {} ``` Potential effect of `SyntaxShape`'s `Display` implementation now also referring to `float` instead of `decimal` # Details - Rename `SyntaxShape::Decimal` to `Float` - Update `Display for SyntaxShape` to `float` - Update error message + fn name in dataframe code - Fix docs in command examples - Rename tests that are float specific - Update doccomment on `SyntaxShape` - Update comment in script # Tests + Formatting Updates the names of some tests
followup to - nushell#9979 ##⚠️ wait for just before 0.86⚠️ # Description after deprecation comes removal 😏 # User-Facing Changes `into decimal` is removed in favor of `into float` # Tests + Formatting # After Submitting
followup to - nushell#9979 ##⚠️ wait for just before 0.86⚠️ # Description after deprecation comes removal 😏 # User-Facing Changes `into decimal` is removed in favor of `into float` # Tests + Formatting # After Submitting
Description
We keep "into decimal" for a release and warn through a message that it will be removed in 0.86.
All tests are updated to use
into floatUser-Facing Changes
into decimalraises a deprecation warning, will be removed soon.Use
into floatas the new functionally identical command instead.Tests + Formatting
Updated