Skip to content

remove into decimal#10341

Merged
amtoine merged 2 commits intonushell:mainfrom
amtoine:remove-into-decimal
Oct 10, 2023
Merged

remove into decimal#10341
amtoine merged 2 commits intonushell:mainfrom
amtoine:remove-into-decimal

Conversation

@amtoine
Copy link
Copy Markdown
Member

@amtoine amtoine commented Sep 12, 2023

followup to

⚠️ wait for just before 0.86 ⚠️

Description

after deprecation comes removal 😏

User-Facing Changes

into decimal is removed in favor of into float

Tests + Formatting

After Submitting

@amtoine amtoine added notes:breaking-changes This PR implies a change affecting users and has to be noted in the release notes category:deprecation Related to the deprecation of commands/features/options labels Sep 12, 2023
@sholderbach sholderbach marked this pull request as draft September 12, 2023 19:57
@amtoine
Copy link
Copy Markdown
Member Author

amtoine commented Sep 23, 2023

Nushell 0.85.0 was released, i'm marking this PR as "ready for review" for next release 😋

@amtoine amtoine marked this pull request as ready for review September 23, 2023 09:59
this commit removes `into decimal`.

this should solve the conflict in nushell#10341.
@amtoine amtoine merged commit 8c36e9d into nushell:main Oct 10, 2023
@amtoine amtoine deleted the remove-into-decimal branch October 10, 2023 18:05
@sholderbach sholderbach added category:removal-after-deprecation The component has already been sunset with `deprecation` and is now up for final removal and removed category:deprecation Related to the deprecation of commands/features/options labels Nov 8, 2023
hardfau1t pushed a commit to hardfau1t/nushell that referenced this pull request Dec 14, 2023
followup to
- nushell#9979

## ⚠️ wait for just before 0.86 ⚠️

# Description
after deprecation comes removal 😏 

# User-Facing Changes
`into decimal` is removed in favor of `into float`

# Tests + Formatting

# After Submitting
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

category:removal-after-deprecation The component has already been sunset with `deprecation` and is now up for final removal notes:breaking-changes This PR implies a change affecting users and has to be noted in the release notes

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants