Merged
Conversation
Contributor
|
Looks good. Just so we don't forget, this PR also needs to be updated #10784 so it suggests the right command. |
Contributor
Author
Contributor
|
ya, i think so. i'm not saying it's time to land #10784, but as it sits now, it's wrong. so, we should update 10784 so when we're ready to land it, it's right. |
Member
|
yeah the idea behind removal PRs is for them to be ready as soon as the deprecation lands, in a DRAFT, so that we do not forget about them 😌 |
amtoine
added a commit
to amtoine/nushell
that referenced
this pull request
Oct 21, 2023
this should solve the merge conflict introduced by nushell#10798
sholderbach
added a commit
to sholderbach/nu_scripts
that referenced
this pull request
Oct 23, 2023
This happened in nushell/nushell#10798
WindSoilder
pushed a commit
that referenced
this pull request
Nov 16, 2023
follow-up to - #10798 > **Important** > wait for between 0.87 and 0.88 to land this # Description once again, after deprecation comes removal 😌 # User-Facing Changes `size` is now removed and `str size` should be used # Tests + Formatting # After Submitting
sholderbach
added a commit
to nushell/nu_scripts
that referenced
this pull request
Dec 6, 2023
Deprecation will be released with `0.87` - ~~nushell/nushell#10772 - nushell/nushell#10798 Final removal in `0.88` Land before: - nushell/nushell#10784
hardfau1t
pushed a commit
to hardfau1t/nushell
that referenced
this pull request
Dec 14, 2023
<!-- if this PR closes one or more issues, you can automatically link the PR with them by using one of the [*linking keywords*](https://docs.github.com/en/issues/tracking-your-work-with-issues/linking-a-pull-request-to-an-issue#linking-a-pull-request-to-an-issue-using-a-keyword), e.g. - this PR should close #xxxx - fixes #xxxx you can also mention related issues, PRs or discussions! --> # Description <!-- Thank you for improving Nushell. Please, check our [contributing guide](../CONTRIBUTING.md) and talk to the core team before making major changes. Description of your pull request goes here. **Provide examples and/or screenshots** if your changes affect the user experience. --> Rename `str size` to `str stats`, for more detail see: nushell#10772 # User-Facing Changes <!-- List of all changes that impact the user experience here. This helps us keep track of breaking changes. --> # Tests + Formatting <!-- Don't forget to add tests that cover your changes. Make sure you've run and fixed any issues with these commands: - `cargo fmt --all -- --check` to check standard code formatting (`cargo fmt --all` applies these changes) - `cargo clippy --workspace -- -D warnings -D clippy::unwrap_used` to check that you're using the standard code style - `cargo test --workspace` to check that all tests pass (on Windows make sure to [enable developer mode](https://learn.microsoft.com/en-us/windows/apps/get-started/developer-mode-features-and-debugging)) - `cargo run -- -c "use std testing; testing run-tests --path crates/nu-std"` to run the tests for the standard library > **Note** > from `nushell` you can also use the `toolkit` as follows > ```bash > use toolkit.nu # or use an `env_change` hook to activate it automatically > toolkit check pr > ``` --> # After Submitting <!-- If your PR had any user-facing changes, update [the documentation](https://github.com/nushell/nushell.github.io) after the PR is merged, if necessary. This will help us keep the docs up to date. -->
hardfau1t
pushed a commit
to hardfau1t/nushell
that referenced
this pull request
Dec 14, 2023
follow-up to - nushell#10798 > **Important** > wait for between 0.87 and 0.88 to land this # Description once again, after deprecation comes removal 😌 # User-Facing Changes `size` is now removed and `str size` should be used # Tests + Formatting # After Submitting
dmatos2012
pushed a commit
to dmatos2012/nushell
that referenced
this pull request
Feb 20, 2024
follow-up to - nushell#10798 > **Important** > wait for between 0.87 and 0.88 to land this # Description once again, after deprecation comes removal 😌 # User-Facing Changes `size` is now removed and `str size` should be used # Tests + Formatting # After Submitting
maxim-uvarov
pushed a commit
to maxim-uvarov/nu_scripts_reduced_size
that referenced
this pull request
Oct 12, 2024
Deprecation will be released with `0.87` - ~~nushell/nushell#10772 - nushell/nushell#10798 Final removal in `0.88` Land before: - nushell/nushell#10784
maxim-uvarov
pushed a commit
to maxim-uvarov/nu_scripts_reduced_size
that referenced
this pull request
Oct 13, 2024
Deprecation will be released with `0.87` - ~~nushell/nushell#10772 - nushell/nushell#10798 Final removal in `0.88` Land before: - nushell/nushell#10784
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Rename
str sizetostr stats, for more detail see: #10772User-Facing Changes
Tests + Formatting
After Submitting