remove size command in favor of str stats#10784
Merged
WindSoilder merged 6 commits intonushell:mainfrom Nov 16, 2023
Merged
Conversation
this should solve the merge conflict introduced by nushell#10798
the command i used ```shell sd "str size" "str stats" crates/nu-command/tests/commands/**/*.rs ```
Member
Author
|
@hustcer |
size command in favor of str sizesize command in favor of str stats
12 tasks
this should solve the merge conflict in nushell#10784
sholderbach
added a commit
to nushell/nu_scripts
that referenced
this pull request
Dec 6, 2023
Deprecation will be released with `0.87` - ~~nushell/nushell#10772 - nushell/nushell#10798 Final removal in `0.88` Land before: - nushell/nushell#10784
hardfau1t
pushed a commit
to hardfau1t/nushell
that referenced
this pull request
Dec 14, 2023
follow-up to - nushell#10798 > **Important** > wait for between 0.87 and 0.88 to land this # Description once again, after deprecation comes removal 😌 # User-Facing Changes `size` is now removed and `str size` should be used # Tests + Formatting # After Submitting
dmatos2012
pushed a commit
to dmatos2012/nushell
that referenced
this pull request
Feb 20, 2024
follow-up to - nushell#10798 > **Important** > wait for between 0.87 and 0.88 to land this # Description once again, after deprecation comes removal 😌 # User-Facing Changes `size` is now removed and `str size` should be used # Tests + Formatting # After Submitting
maxim-uvarov
pushed a commit
to maxim-uvarov/nu_scripts_reduced_size
that referenced
this pull request
Oct 12, 2024
Deprecation will be released with `0.87` - ~~nushell/nushell#10772 - nushell/nushell#10798 Final removal in `0.88` Land before: - nushell/nushell#10784
maxim-uvarov
pushed a commit
to maxim-uvarov/nu_scripts_reduced_size
that referenced
this pull request
Oct 13, 2024
Deprecation will be released with `0.87` - ~~nushell/nushell#10772 - nushell/nushell#10798 Final removal in `0.88` Land before: - nushell/nushell#10784
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
follow-up to
sizetostr stats#10798Description
once again, after deprecation comes removal 😌
User-Facing Changes
sizeis now removed andstr sizeshould be usedTests + Formatting
After Submitting