deprecate size to str size#10772
Conversation
|
cc/ @fdncred |
There was a problem hiding this comment.
Seems appropriate.
This has nothing to do with your work here but it's still an odd command. Maybe it's supposed to be nushell's version of wc?
❯ wc Cargo.toml
176 759 6094 Cargo.toml
❯ open Cargo.toml -r | size
╭─────────┬────╮
│lines │176 │
│words │743 │
│bytes │6094│
│chars │6094│
│graphemes│5918│
╰─────────┴────╯Deprecation will be released with `0.87` - nushell/nushell#10772 Final removal in `0.88`
related to - https://discord.com/channels/601130461678272522/614613939334152217/1164530991931605062 # Description it appears `size` is a command that operates on `string`s only and gives the user information about the chars, graphemes and bytes of a string. this looks like a command that should be a subcommand to `str` 😏 this PR - adds `str size` - deprecates `size` `size` is planned to be removed in 0.88 # User-Facing Changes `str size` can be used for the same result as `size`. # Tests + Formatting # After Submitting write a removal PR for `size`
|
@fdncred |
|
I was wondering if |
it's the size in memory i'd say? 🤔 |
|
I'm not sure "size in memory" is correct either. Not really sure what the correct name is. |
|
|
|
ya, i could support |
|
feel free to overwrite this PR with a new name, we're inbetween two releases, so that's more than fine 😉 |
<!-- if this PR closes one or more issues, you can automatically link the PR with them by using one of the [*linking keywords*](https://docs.github.com/en/issues/tracking-your-work-with-issues/linking-a-pull-request-to-an-issue#linking-a-pull-request-to-an-issue-using-a-keyword), e.g. - this PR should close #xxxx - fixes #xxxx you can also mention related issues, PRs or discussions! --> # Description <!-- Thank you for improving Nushell. Please, check our [contributing guide](../CONTRIBUTING.md) and talk to the core team before making major changes. Description of your pull request goes here. **Provide examples and/or screenshots** if your changes affect the user experience. --> Rename `str size` to `str stats`, for more detail see: #10772 # User-Facing Changes <!-- List of all changes that impact the user experience here. This helps us keep track of breaking changes. --> # Tests + Formatting <!-- Don't forget to add tests that cover your changes. Make sure you've run and fixed any issues with these commands: - `cargo fmt --all -- --check` to check standard code formatting (`cargo fmt --all` applies these changes) - `cargo clippy --workspace -- -D warnings -D clippy::unwrap_used` to check that you're using the standard code style - `cargo test --workspace` to check that all tests pass (on Windows make sure to [enable developer mode](https://learn.microsoft.com/en-us/windows/apps/get-started/developer-mode-features-and-debugging)) - `cargo run -- -c "use std testing; testing run-tests --path crates/nu-std"` to run the tests for the standard library > **Note** > from `nushell` you can also use the `toolkit` as follows > ```bash > use toolkit.nu # or use an `env_change` hook to activate it automatically > toolkit check pr > ``` --> # After Submitting <!-- If your PR had any user-facing changes, update [the documentation](https://github.com/nushell/nushell.github.io) after the PR is merged, if necessary. This will help us keep the docs up to date. -->
Deprecation will be released with `0.87` - ~~nushell/nushell#10772 - nushell/nushell#10798 Final removal in `0.88` Land before: - nushell/nushell#10784
related to - https://discord.com/channels/601130461678272522/614613939334152217/1164530991931605062 # Description it appears `size` is a command that operates on `string`s only and gives the user information about the chars, graphemes and bytes of a string. this looks like a command that should be a subcommand to `str` 😏 this PR - adds `str size` - deprecates `size` `size` is planned to be removed in 0.88 # User-Facing Changes `str size` can be used for the same result as `size`. # Tests + Formatting # After Submitting write a removal PR for `size`
<!-- if this PR closes one or more issues, you can automatically link the PR with them by using one of the [*linking keywords*](https://docs.github.com/en/issues/tracking-your-work-with-issues/linking-a-pull-request-to-an-issue#linking-a-pull-request-to-an-issue-using-a-keyword), e.g. - this PR should close #xxxx - fixes #xxxx you can also mention related issues, PRs or discussions! --> # Description <!-- Thank you for improving Nushell. Please, check our [contributing guide](../CONTRIBUTING.md) and talk to the core team before making major changes. Description of your pull request goes here. **Provide examples and/or screenshots** if your changes affect the user experience. --> Rename `str size` to `str stats`, for more detail see: nushell#10772 # User-Facing Changes <!-- List of all changes that impact the user experience here. This helps us keep track of breaking changes. --> # Tests + Formatting <!-- Don't forget to add tests that cover your changes. Make sure you've run and fixed any issues with these commands: - `cargo fmt --all -- --check` to check standard code formatting (`cargo fmt --all` applies these changes) - `cargo clippy --workspace -- -D warnings -D clippy::unwrap_used` to check that you're using the standard code style - `cargo test --workspace` to check that all tests pass (on Windows make sure to [enable developer mode](https://learn.microsoft.com/en-us/windows/apps/get-started/developer-mode-features-and-debugging)) - `cargo run -- -c "use std testing; testing run-tests --path crates/nu-std"` to run the tests for the standard library > **Note** > from `nushell` you can also use the `toolkit` as follows > ```bash > use toolkit.nu # or use an `env_change` hook to activate it automatically > toolkit check pr > ``` --> # After Submitting <!-- If your PR had any user-facing changes, update [the documentation](https://github.com/nushell/nushell.github.io) after the PR is merged, if necessary. This will help us keep the docs up to date. -->
Deprecation will be released with `0.87` - ~~nushell/nushell#10772 - nushell/nushell#10798 Final removal in `0.88` Land before: - nushell/nushell#10784
Deprecation will be released with `0.87` - ~~nushell/nushell#10772 - nushell/nushell#10798 Final removal in `0.88` Land before: - nushell/nushell#10784
related to
Description
it appears
sizeis a command that operates onstrings only and gives the user information about the chars, graphemes and bytes of a string.this looks like a command that should be a subcommand to
str😏this PR
str sizesizesizeis planned to be removed in 0.88User-Facing Changes
str sizecan be used for the same result assize.Tests + Formatting
After Submitting
write a removal PR for
size