Type of PR:

• Rework
• Refactor
• 🪓

Required reviews:
4

What this does:

Enhancements

• Automated operator wallet generation from ursula's mnemonic (optional) on nucypher ursula init
  • example usage:

    nucypher ursula init 
    --eth-endpoint https://mainnet.infura.io/v3/abc 
    --polygon-endpoint https://polygon-mainnet.infura.io/v3/abc 
    --domain mainnet
    
    ...
    
    Generated keystore
    
    Operator Address:   0xeCaf28AD99A4150f9A890B214C005f19e344E3d9
    Network Public Key:   02a43893e5205546dfe07fbd39096697
    Keystore Directory: /home/k/.local/share/nucypher/keystore
    ...

• Introduces new CLI/config option --wallet-filepath for using a pre-existing wallet
• Extracts migrate to a dedicated CLI command nucypher ursula migrate
• Reduces configuration fields with config bump v8 -> v9 and migration script

Deprecations

• TransactingPower and Signers in favor of Wallet
• --signer-uri, --operator-address, --light and --poa launch flags
• operator_address and checksum_address as character constructor inputs
• InfuraClient, AlchemyClient, RPC account management
• Multiple configuration files handling and selection (now only one is required/supported)
• Select JSON config values; Remaining fields are
  • keystore_filepath
  • domain
  • eth_endpoint
  • polygon_endpoint
  • host
  • port
  • wallet_filepath
  • condition_blockchain_endpoints
  • version

Renames

• "node" (and in many cases "teacher") -> "peer"
• rest_host, rest_port -> host, port
• keystore_path -> keystore_filepath

Code Quality

• Reinvention of wallet/account management (testing with local accounts a la ape, no more RPC wallets)
• Unused code removal (constants, methods, utilities)
• Unskips and fixes all skipped tests, removes unhelpful tests
• Fixes exception handling and reporting of invalid peer nodes
• Fixes failed transaction handling
• Removes unhelpful TODOs
• Improves P2P logging and error handling
• more...

Issues

• Closes Remove Support for Multiple Configuration Files #3373
• Closes Embeded Operator Wallets #3371
• Fixes test_learner_learns_about_domains_separately fails on CI #3289
• Fixes Address poa, light config values technical debt #3268
• Closes Remove CLI parameter: --min-staking #3249
• Closes condition_provider_uris is a dictionary in our Ursula Configuration; how is it updated via the CLI update command #3228
• Closes Persistent DKG artifact storage #3052
• Fixes Ambiguous behaviour with --force for operator address #3039
• Closes ganache-cli unable to handle txs from the PRE node #2958 (deprecated/wontfix)
• Closes Support for the new Ganache #2957 (deprecated/wontfix)
• Fixes RestMiddleware.Unreachable is propagated and sometimes not handled #2920
• Closes Error messages and tests for Policy.Unauthorized scenarios #2784
• Fixes test_alice_verifies_ursula_just_in_time is broken #2715
• Closes Rename "known nodes" -> "peers" #2526
• Fixes OpenEthereum is not a supported ethereum client #2372
• Fixes Require signer prefix (API, CLI, and Configuration) #2342
• Closes Give helpful message when signer is specified as Infura #2323
• Closes Unittest proving that on-chain staking verification is skipped by Bob. #2252
• Closes extract EthereumTester client to the tests package #1807
• Closes Allow Bob's CFrag retention to be set in configuration. #1249 (wontfix)
• Closes New storage cleanup logic. #1554
• Closes Configurable "find ursulas" Timeout #843
• Fixes NotFound is not being caught and converted into a 404; Bob is also not properly catching it. #851

Notes for reviewers:

• Based over Memory-Only Peering: TLS Certificates and Metadata #3307.
• This PR is a work in progress.
• I apologize for the large-scale refactor, mega commits and widespread coverage -- I will make an effort to turn the history into something useful 😅