Skip to content

NotFound is not being caught and converted into a 404; Bob is also not properly catching it. #851

@jMyles

Description

@jMyles

During my investigation of #833, I thought it odd that, once a Policy has been revoked, we expect that Bob will encounter NotEnoughUrsulas:

with pytest.raises(Ursula.NotEnoughUrsulas):

Now... maybe, at a high-level, this is true - we expect that Bob will treat any 404 as insufficient, and ultimately conclude that there are Not Enough Ursulas to complete the retrieval.

The problem is that this is not at all why this is happening. Instead, it "works" for a terrible reason - and it's the same reason that #833 is broken in the first place: that Bob doesn't generate new work orders once he has retrieved. So if he generates zero work orders, he reaches out to zero Ursulas. And of course zero is not enough!

Metadata

Metadata

Assignees

No one assigned

    Labels

    Bob 👨‍💼Effects the "Bob" development areaIs this done?Ambiguous closing requirements may already be metPREStrictly effects PRERevokeUrsula 👩‍🚀Effects the "Ursula" development area

    Type

    No type

    Projects

    Status

    Done

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions