Skip to content

Memory-Only Peering: TLS Certificates and Metadata#3307

Merged
KPrasch merged 18 commits intonucypher:v7.2.xfrom
KPrasch:certs
Jan 18, 2024
Merged

Memory-Only Peering: TLS Certificates and Metadata#3307
KPrasch merged 18 commits intonucypher:v7.2.xfrom
KPrasch:certs

Conversation

@KPrasch
Copy link
Member

@KPrasch KPrasch commented Oct 24, 2023 •
edited
Loading

@KPrasch KPrasch changed the title Memory-only TLS Certificates Memory-Only TLS Certificates Oct 24, 2023
@KPrasch KPrasch added Enhancement New or improved features Ursula 👩‍🚀 Effects the "Ursula" development area Code Quality 🔧 Pertaining to code quality improvements P2P Node discovery and P2P Optimization use less, go faster labels Oct 24, 2023
@KPrasch KPrasch force-pushed the certs branch 2 times, most recently from 639b1eb to 02b5b99 Compare October 25, 2023 18:18
KPrasch added a commit to KPrasch/nucypher that referenced this pull request Oct 25, 2023
@KPrasch
newsfragment for PR nucypher#3307
7003165
@codecov
Copy link

codecov bot commented Oct 25, 2023 •
edited
Loading

Codecov Report

All modified and coverable lines are covered by tests ✅

❗ No coverage uploaded for pull request base (v7.2.x@bd68f5c). Click here to learn what that means.

❗ Current head 299a882 differs from pull request most recent head 29f722b. Consider uploading reports for the commit 29f722b to get more accurate results

Additional details and impacted files 
@@            Coverage Diff            @@
##             v7.2.x    #3307   +/-   ##
=========================================
  Coverage          ?   82.70%           
=========================================
  Files             ?      117           
  Lines             ?    11058           
  Branches          ?        0           
=========================================
  Hits              ?     9145           
  Misses            ?     1913           
  Partials          ?        0
Flag Coverage Δ
acceptance 92.92% <0.00%> (?)
integration 73.42% <0.00%> (?)
unit 60.39% <0.00%> (?)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@KPrasch KPrasch marked this pull request as ready for review October 30, 2023 11:54
KPrasch added a commit to KPrasch/nucypher that referenced this pull request Oct 30, 2023
@KPrasch
newsfragment for PR nucypher#3307
ddde666
@KPrasch KPrasch force-pushed the certs branch 2 times, most recently from 46962cb to 7241ddf Compare October 30, 2023 20:21
KPrasch added a commit to KPrasch/nucypher that referenced this pull request Oct 31, 2023
@KPrasch
newsfragment for PR nucypher#3307
41f11e3
@KPrasch KPrasch changed the base branch from v7.1.0 to v7.0.0 October 31, 2023 12:42
@KPrasch KPrasch changed the base branch from v7.0.0 to v7.1.0 October 31, 2023 12:42
@KPrasch KPrasch requested a review from jMyles October 31, 2023 14:06
cygnusv
cygnusv reviewed Oct 31, 2023
View reviewed changes
KPrasch added a commit to KPrasch/nucypher that referenced this pull request Nov 2, 2023
@KPrasch
newsfragment for PR nucypher#3307
378d5c6
@KPrasch KPrasch changed the base branch from v7.1.0 to v7.0.0 November 2, 2023 19:51
KPrasch added a commit to KPrasch/nucypher that referenced this pull request Nov 3, 2023
@KPrasch
newsfragment for PR nucypher#3307
3d7cd27
KPrasch added a commit to KPrasch/nucypher that referenced this pull request Nov 28, 2023
@KPrasch
newsfragment for PR nucypher#3307
41c82f1
@KPrasch KPrasch changed the base branch from v7.0.0 to main November 30, 2023 16:22
@KPrasch KPrasch changed the base branch from main to v7.0.0 November 30, 2023 16:22
@KPrasch KPrasch changed the base branch from v7.0.0 to v7.1.0 December 1, 2023 10:38
@KPrasch KPrasch changed the title Memory-Only TLS Certificates Memory-Only Peering: TLS Certificates and Metadata Jan 12, 2024
KPrasch
KPrasch commented Jan 12, 2024
View reviewed changes
Copy link
Member Author

@KPrasch KPrasch left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I expanded the scope of this PR just slightly to include a full deprecation of the NodeStorage internal API. Going forward peering will be fully managed by FleetSensor and FleetState APIs, as they have their own in-memory storage mechanisms.

@KPrasch KPrasch mentioned this pull request Jan 13, 2024
Closed
theref
theref reviewed Jan 18, 2024
View reviewed changes
derekpierre
derekpierre reviewed Jan 18, 2024
View reviewed changes
tests/unit/test_memory_certs.py
cache.set(address, MOCK_CERT)
assert not cache.is_expired(address)
# Wait for the cert to expire
time.sleep(2)
Copy link
Member

@derekpierre derekpierre Jan 18, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Instead of actually sleeping you can patch time.time() to return a time 2 seconds in the future.

Copy link
Member Author

@KPrasch KPrasch Jan 18, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

True. Do you mind If I address this test optimization in PR #3382 in order to avoid more rebases?

Copy link
Member

@derekpierre derekpierre Jan 18, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yep no problem.

derekpierre
derekpierre approved these changes Jan 18, 2024
View reviewed changes
Copy link
Member

@derekpierre derekpierre left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🎸

@KPrasch
Copy link
Member Author

KPrasch commented Jan 18, 2024

Thanks everyone!

@KPrasch KPrasch merged commit e64c9a7 into nucypher:v7.2.x Jan 18, 2024
KPrasch added a commit to KPrasch/nucypher that referenced this pull request Jan 24, 2024
@KPrasch
newsfragment for PR nucypher#3307
6fdacf2
KPrasch added a commit to KPrasch/nucypher that referenced this pull request Jan 30, 2024
@KPrasch
newsfragment for PR nucypher#3307
014c053
KPrasch added a commit that referenced this pull request Jan 30, 2024
@KPrasch
newsfragment for PR #3307
c21dadd
@derekpierre derekpierre mentioned this pull request Feb 5, 2024
Merged
@KPrasch KPrasch self-assigned this Feb 5, 2024
This was referenced Feb 7, 2024
Closed
Closed
Merged
derekpierre pushed a commit that referenced this pull request Feb 13, 2024
@KPrasch @derekpierre
newsfragment for PR #3307
62ab576
@derekpierre derekpierre mentioned this pull request Feb 20, 2024
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@theref theref theref approved these changes

@derekpierre derekpierre derekpierre approved these changes

@jMyles jMyles Awaiting requested review from jMyles

@cygnusv cygnusv Awaiting requested review from cygnusv

Assignees

@KPrasch KPrasch

Labels

Code Quality 🔧 Pertaining to code quality improvements Enhancement New or improved features Optimization use less, go faster P2P Node discovery and P2P Ursula 👩‍🚀 Effects the "Ursula" development area

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

New storage cleanup logic.

4 participants

@KPrasch @cygnusv @theref @derekpierre