Skip to content

Feat/new estimations#3539

Merged
cthulhu-rider merged 7 commits intomasterfrom
feat/new-estimations
Aug 28, 2025
Merged

Feat/new estimations#3539
cthulhu-rider merged 7 commits intomasterfrom
feat/new-estimations

Conversation

@carpawell
Copy link
Member

@carpawell carpawell commented Aug 21, 2025

No description provided.

@carpawell carpawell self-assigned this Aug 21, 2025
@codecov
Copy link

codecov bot commented Aug 21, 2025 •
edited
Loading

Codecov Report

❌ Patch coverage is 27.65273% with 225 lines in your changes missing coverage. Please review.
✅ Project coverage is 24.89%. Comparing base (22f0daa) to head (1f58415).
⚠️ Report is 26 commits behind head on master.

Files with missing lines Patch % Lines
pkg/morph/client/container/load_new.go 0.00% 94 Missing ⚠️
pkg/morph/event/container/load_new_notary.go 0.00% 28 Missing ⚠️
pkg/local_object_storage/metabase/containers.go 63.76% 16 Missing and 9 partials ⚠️
cmd/neofs-node/container.go 0.00% 23 Missing ⚠️
pkg/local_object_storage/metabase/version.go 67.27% 12 Missing and 6 partials ⚠️
...ring/processors/container/process_announce_load.go 0.00% 12 Missing ⚠️
pkg/local_object_storage/engine/container.go 0.00% 7 Missing ⚠️
pkg/innerring/processors/container/handlers.go 0.00% 5 Missing ⚠️
pkg/innerring/innerring.go 0.00% 4 Missing ⚠️
pkg/innerring/processors/container/processor.go 0.00% 3 Missing ⚠️
... and 4 more
Additional details and impacted files 
@@            Coverage Diff             @@
##           master    #3539      +/-   ##
==========================================
+ Coverage   24.68%   24.89%   +0.20%     
==========================================
  Files         672      666       -6     
  Lines       50052    49553     -499     
==========================================
- Hits        12357    12334      -23     
+ Misses      36698    36231     -467     
+ Partials      997      988       -9

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

This was referenced Aug 21, 2025
Merged
Closed
cthulhu-rider
cthulhu-rider reviewed Aug 21, 2025
View reviewed changes
@cthulhu-rider
Copy link
Contributor

cthulhu-rider commented Aug 21, 2025 •
edited
Loading

looks legit overall

not yet reviewed metabase

@carpawell carpawell force-pushed the feat/new-estimations branch from 1c0cc80 to 3ae8546 Compare August 22, 2025 17:10
cthulhu-rider
cthulhu-rider reviewed Aug 25, 2025
View reviewed changes
cthulhu-rider
cthulhu-rider reviewed Aug 25, 2025
View reviewed changes
@carpawell carpawell mentioned this pull request Aug 25, 2025
Closed
@carpawell
node: drop old container estimations
16a3840 
`morph` package is untouched for now and will be fully adopted with a single
commit. Refs #3460.

Signed-off-by: Pavel Karpy <carpawell@nspcc.ru>
@carpawell
ir: drop old container estimations managing API
466613a 
`morph` package is untouched for now and will be fully adopted with a single
commit. Refs #3460.

Signed-off-by: Pavel Karpy <carpawell@nspcc.ru>
@carpawell carpawell force-pushed the feat/new-estimations branch from 3ae8546 to 1a70460 Compare August 25, 2025 17:22
@cthulhu-rider
Copy link
Contributor

cthulhu-rider commented Aug 26, 2025 •
edited
Loading

tests fail due to removed config? How/when they gonna be fixed?

@carpawell carpawell marked this pull request as draft August 26, 2025 08:34
@carpawell carpawell force-pushed the feat/new-estimations branch from 1a70460 to 240fbbc Compare August 26, 2025 08:40
carpawell added a commit to nspcc-dev/neofs-testcases that referenced this pull request Aug 26, 2025
@carpawell
env/templates: drop IR's estimation managing config
9693322 
Will not be used in future releases, fails tests for current master.
Refs nspcc-dev/neofs-node#3539.

Signed-off-by: Pavel Karpy <carpawell@nspcc.ru>
@carpawell carpawell mentioned this pull request Aug 26, 2025
Merged
@carpawell
Copy link
Member Author

carpawell commented Aug 26, 2025 •
edited
Loading

tests fail due to removed config? How/when they gonna be fixed?

Likely should be fixed this way: nspcc-dev/neofs-testcases#1139.

@carpawell
morph: support new container size reports
289706f 
Implementation of nspcc-dev/neofs-contract#507. Also,
drop IR's old API controlling estimations flow (StartEstimation/StopEstimation).
Refs #3460.

Signed-off-by: Pavel Karpy <carpawell@nspcc.ru>
@carpawell
engine: track container's number of object
0559add 
The same way container's size was tracked before. Required metabase adoption
and, therefore, its version update. Refs #3460.

Signed-off-by: Pavel Karpy <carpawell@nspcc.ru>
@carpawell
node: send container reports to the Container contract
187d902 
Refs #3460.

Signed-off-by: Pavel Karpy <carpawell@nspcc.ru>
@carpawell
ir: allow new multisigned container reports from SNs
0f2b40c 
Refs #3460.

Signed-off-by: Pavel Karpy <carpawell@nspcc.ru>
@carpawell carpawell force-pushed the feat/new-estimations branch from 240fbbc to b7344bc Compare August 26, 2025 11:58
@carpawell
go.mod: update contracts
1f58415 
This brings nspcc-dev/neofs-contract#507 and allows IRs
and SNs use new container estimations API. Refs #3460.

Signed-off-by: Pavel Karpy <carpawell@nspcc.ru>
@carpawell carpawell force-pushed the feat/new-estimations branch from b7344bc to 1f58415 Compare August 27, 2025 19:45
@carpawell carpawell marked this pull request as ready for review August 28, 2025 08:48
@cthulhu-rider cthulhu-rider merged commit c3baef6 into master Aug 28, 2025
21 of 22 checks passed
@cthulhu-rider cthulhu-rider deleted the feat/new-estimations branch August 28, 2025 08:52
cthulhu-rider added a commit that referenced this pull request Sep 9, 2025
@cthulhu-rider
fschain: Drop unused Client.AnnounceLoad
b09b69d 
Unused since 16a3840.

Also, the method used elements removed in
nspcc-dev/neofs-sdk-go#732 making the module
upgrade breaking.

Refs #3539.

Signed-off-by: Leonard Lyubich <leonard@morphbits.io>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@cthulhu-rider cthulhu-rider cthulhu-rider approved these changes

@roman-khimov roman-khimov Awaiting requested review from roman-khimov roman-khimov is a code owner

@End-rey End-rey Awaiting requested review from End-rey End-rey is a code owner

Assignees

@carpawell carpawell

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@carpawell @cthulhu-rider