container: calculate container estimations on contract side#507
Merged
cthulhu-rider merged 1 commit intomasterfrom Aug 18, 2025
Merged
Conversation
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #507 +/- ##
==========================================
- Coverage 62.55% 62.22% -0.33%
==========================================
Files 23 23
Lines 3301 3328 +27
==========================================
+ Hits 2065 2071 +6
- Misses 1236 1257 +21 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
6bf257f to
003a573
Compare
003a573 to
9483999
Compare
cthulhu-rider
previously approved these changes
Aug 18, 2025
Accept container estimations report made by storage nodes directly from every netmap member (limiting max number of reports per epoch by 3). Keep an average value for every container. Add API for fetching new estimations and allow checking what exact report every storage node made. Extend "container estimation" term to (size, objectsNumber) pair. Closes #501. Signed-off-by: Pavel Karpy <carpawell@nspcc.ru>
9483999 to
38ac6f6
Compare
cthulhu-rider
approved these changes
Aug 18, 2025
carpawell
added a commit
to nspcc-dev/neofs-node
that referenced
this pull request
Aug 21, 2025
Implementation of nspcc-dev/neofs-contract#507. Also, drop IR's old API controlling estimations flow (StartEstimation/StopEstimation). Refs #3460. Signed-off-by: Pavel Karpy <carpawell@nspcc.ru>
carpawell
added a commit
to nspcc-dev/neofs-node
that referenced
this pull request
Aug 21, 2025
This brings nspcc-dev/neofs-contract#507 and allows IRs and SNs use new container estimations API. Refs #3460. Signed-off-by: Pavel Karpy <carpawell@nspcc.ru>
carpawell
added a commit
to nspcc-dev/neofs-node
that referenced
this pull request
Aug 21, 2025
This brings nspcc-dev/neofs-contract#507 and allows IRs and SNs use new container estimations API. Refs #3460. Signed-off-by: Pavel Karpy <carpawell@nspcc.ru>
carpawell
added a commit
to nspcc-dev/neofs-node
that referenced
this pull request
Aug 22, 2025
Implementation of nspcc-dev/neofs-contract#507. Also, drop IR's old API controlling estimations flow (StartEstimation/StopEstimation). Refs #3460. Signed-off-by: Pavel Karpy <carpawell@nspcc.ru>
carpawell
added a commit
to nspcc-dev/neofs-node
that referenced
this pull request
Aug 22, 2025
This brings nspcc-dev/neofs-contract#507 and allows IRs and SNs use new container estimations API. Refs #3460. Signed-off-by: Pavel Karpy <carpawell@nspcc.ru>
carpawell
added a commit
to nspcc-dev/neofs-node
that referenced
this pull request
Aug 25, 2025
Implementation of nspcc-dev/neofs-contract#507. Also, drop IR's old API controlling estimations flow (StartEstimation/StopEstimation). Refs #3460. Signed-off-by: Pavel Karpy <carpawell@nspcc.ru>
carpawell
added a commit
to nspcc-dev/neofs-node
that referenced
this pull request
Aug 25, 2025
This brings nspcc-dev/neofs-contract#507 and allows IRs and SNs use new container estimations API. Refs #3460. Signed-off-by: Pavel Karpy <carpawell@nspcc.ru>
carpawell
added a commit
to nspcc-dev/neofs-node
that referenced
this pull request
Aug 26, 2025
This brings nspcc-dev/neofs-contract#507 and allows IRs and SNs use new container estimations API. Refs #3460. Signed-off-by: Pavel Karpy <carpawell@nspcc.ru>
carpawell
added a commit
to nspcc-dev/neofs-node
that referenced
this pull request
Aug 26, 2025
Implementation of nspcc-dev/neofs-contract#507. Also, drop IR's old API controlling estimations flow (StartEstimation/StopEstimation). Refs #3460. Signed-off-by: Pavel Karpy <carpawell@nspcc.ru>
carpawell
added a commit
to nspcc-dev/neofs-node
that referenced
this pull request
Aug 26, 2025
This brings nspcc-dev/neofs-contract#507 and allows IRs and SNs use new container estimations API. Refs #3460. Signed-off-by: Pavel Karpy <carpawell@nspcc.ru>
carpawell
added a commit
to nspcc-dev/neofs-node
that referenced
this pull request
Aug 27, 2025
This brings nspcc-dev/neofs-contract#507 and allows IRs and SNs use new container estimations API. Refs #3460. Signed-off-by: Pavel Karpy <carpawell@nspcc.ru>
carpawell
added a commit
to nspcc-dev/neofs-node
that referenced
this pull request
Aug 28, 2025
Transfer assets according to new reports from nspcc-dev/neofs-contract#507. Simplify processor's logic. Do not use a separate "bank" account, transfer directly from container owner to storage nodes instead. Pay for exact reported values, do not calculate size estimations. Closes #3053. Signed-off-by: Pavel Karpy <carpawell@nspcc.ru>
carpawell
added a commit
to nspcc-dev/neofs-node
that referenced
this pull request
Aug 28, 2025
Transfer assets according to new reports from nspcc-dev/neofs-contract#507. Simplify processor's logic. Do not use a separate "bank" account, transfer directly from container owner to storage nodes instead. Pay for exact reported values, do not calculate size estimations. Closes #3053. Signed-off-by: Pavel Karpy <carpawell@nspcc.ru>
carpawell
added a commit
to nspcc-dev/neofs-node
that referenced
this pull request
Aug 29, 2025
Transfer assets according to new reports from nspcc-dev/neofs-contract#507. Simplify processor's logic. Do not use a separate "bank" account, transfer directly from container owner to storage nodes instead. Pay for exact reported values, do not calculate size estimations. Closes #3053. Signed-off-by: Pavel Karpy <carpawell@nspcc.ru>
carpawell
added a commit
to nspcc-dev/neofs-node
that referenced
this pull request
Aug 29, 2025
Transfer assets according to new reports from nspcc-dev/neofs-contract#507. Simplify processor's logic. Do not use a separate "bank" account, transfer directly from container owner to storage nodes instead. Pay for exact reported values, do not calculate size estimations. Closes #3053. Signed-off-by: Pavel Karpy <carpawell@nspcc.ru>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Accept container estimations report made by storage nodes directly from every netmap member (limiting max number of reports per epoch by 3). Keep an average value for every container. Add API for fetching new estimations and allow checking what exact report every storage node made. Extend "container estimation" term to (size, objectsNumber) pair. Closes #501.