native: adapt dynamic block time by AnnaShaleva · Pull Request #3835 · nspcc-dev/neo-go

AnnaShaleva · 2025-03-10T16:46:12Z

pkg/core/native/policy.go

codecov · 2025-03-12T12:49:26Z

Codecov Report

Attention: Patch coverage is 83.90805% with 14 lines in your changes missing coverage. Please review.

Project coverage is 82.56%. Comparing base (eedadd0) to head (1d15db3).
Report is 7 commits behind head on master.

Files with missing lines	Patch %	Lines
pkg/core/blockchain.go	43.75%	6 Missing and 3 partials ⚠️
pkg/core/native/policy.go	95.45%	1 Missing and 1 partial ⚠️
cli/server/server.go	66.66%	1 Missing ⚠️
pkg/network/tcp_peer.go	0.00%	1 Missing ⚠️
pkg/services/stateroot/validators.go	0.00%	1 Missing ⚠️

Additional details and impacted files

@@            Coverage Diff             @@
##           master    #3835      +/-   ##
==========================================
- Coverage   82.61%   82.56%   -0.05%     
==========================================
  Files         342      342              
  Lines       48032    48105      +73     
==========================================
+ Hits        39681    39718      +37     
- Misses       6708     6745      +37     
+ Partials     1643     1642       -1

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:

❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

AnnaShaleva · 2025-03-19T13:03:47Z

Depends on nspcc-dev/dbft#147.

AnnaShaleva · 2025-03-20T16:41:02Z

Depends on nspcc-dev/dbft#148.

AnnaShaleva · 2025-03-20T16:44:00Z

@roman-khimov, please review.

pkg/core/blockchain.go

pkg/network/tcp_peer.go

Ref. #3835 (comment), sub-second write timeout is too harsh for real networks. Signed-off-by: Anna Shaleva <shaleva.ann@nspcc.ru>

Signed-off-by: Anna Shaleva <shaleva.ann@nspcc.ru>

Ref. #3835 (comment), sub-second write timeout is too harsh for real networks. Signed-off-by: Anna Shaleva <shaleva.ann@nspcc.ru>

A part of #3745. Signed-off-by: Anna Shaleva <shaleva.ann@nspcc.ru>

Ref. #3835 (comment), sub-second write timeout is too harsh for real networks. Signed-off-by: Anna Shaleva <shaleva.ann@nspcc.ru>

AnnaShaleva · 2025-04-17T15:20:54Z

@roman-khimov, just for the record, this one is ready for review, let's merge it and I'll update other dependent PRs.

roman-khimov

How about getversion? It has MillisecondsPerBlock as well.

AnnaShaleva · 2025-04-18T09:21:00Z

I was sure I've already fixed this code, there was a TODO comment. Seems like a rebase problem.

Close #3745. Signed-off-by: Anna Shaleva <shaleva.ann@nspcc.ru>

Ref. #3835 (comment), sub-second write timeout is too harsh for real networks. Signed-off-by: Anna Shaleva <shaleva.ann@nspcc.ru>

AnnaShaleva · 2025-04-18T09:35:34Z

How about getversion?

Fixed, and also for stateservice.

Should be a part of #3849 and #3835. Signed-off-by: Anna Shaleva <shaleva.ann@nspcc.ru>

AnnaShaleva requested a review from roman-khimov as a code owner March 10, 2025 16:46

AnnaShaleva marked this pull request as draft March 10, 2025 16:46

This was referenced Mar 10, 2025

3s consensus - With consensus time included into consensus intervals. neo-project/neo#3622

Closed

core: fix native contract initialization process #3837

Merged

AnnaShaleva force-pushed the blocktime-policy branch 2 times, most recently from 6922449 to 6b6ddf6 Compare March 12, 2025 12:26

AnnaShaleva commented Mar 12, 2025

View reviewed changes

pkg/core/native/policy.go Outdated Show resolved Hide resolved

pkg/core/native/policy.go Outdated Show resolved Hide resolved

AnnaShaleva force-pushed the blocktime-policy branch from 6b6ddf6 to 27bc3b6 Compare March 12, 2025 12:30

AnnaShaleva marked this pull request as ready for review March 12, 2025 12:30

AnnaShaleva force-pushed the blocktime-policy branch 2 times, most recently from 066c578 to 39ff457 Compare March 12, 2025 12:35

AnnaShaleva force-pushed the blocktime-policy branch 2 times, most recently from 65f746b to 500381f Compare March 13, 2025 07:57

AnnaShaleva mentioned this pull request Mar 19, 2025

*: adapt state-dependent block producing time nspcc-dev/dbft#147

Merged

AnnaShaleva force-pushed the blocktime-policy branch 2 times, most recently from c1e4821 to 1afea7c Compare March 19, 2025 12:56

AnnaShaleva changed the title ~~native: store TimePerBlock setting inside native Policy~~ native: adapt dynamic block time Mar 19, 2025

AnnaShaleva force-pushed the blocktime-policy branch from 1afea7c to f72ee1a Compare March 20, 2025 16:40

AnnaShaleva force-pushed the blocktime-policy branch from f72ee1a to 6ec21af Compare March 20, 2025 16:43

AnnaShaleva requested a review from AliceInHunterland March 20, 2025 16:47

roman-khimov reviewed Mar 25, 2025

View reviewed changes

pkg/core/blockchain.go Outdated Show resolved Hide resolved

pkg/network/tcp_peer.go Outdated Show resolved Hide resolved

AnnaShaleva added a commit that referenced this pull request Mar 26, 2025

network: sanitize write timeout for TCP peer

56570d8

Ref. #3835 (comment), sub-second write timeout is too harsh for real networks. Signed-off-by: Anna Shaleva <shaleva.ann@nspcc.ru>

AnnaShaleva force-pushed the blocktime-policy branch 3 times, most recently from d6b0d59 to 56570d8 Compare March 26, 2025 16:23

AnnaShaleva mentioned this pull request Mar 26, 2025

native: move MaxValidUntilBlockIncrement to Policy #3849

Merged

AnnaShaleva added a commit that referenced this pull request Mar 27, 2025

network: sanitize write timeout for TCP peer

32c5da9

Ref. #3835 (comment), sub-second write timeout is too harsh for real networks. Signed-off-by: Anna Shaleva <shaleva.ann@nspcc.ru>

AnnaShaleva force-pushed the blocktime-policy branch from 56570d8 to 32c5da9 Compare March 27, 2025 17:02

AnnaShaleva added the blocked Can't be done because of something label Apr 1, 2025

AnnaShaleva added a commit that referenced this pull request Apr 1, 2025

network: sanitize write timeout for TCP peer

7a19283

Ref. #3835 (comment), sub-second write timeout is too harsh for real networks. Signed-off-by: Anna Shaleva <shaleva.ann@nspcc.ru>

AnnaShaleva force-pushed the blocktime-policy branch from 32c5da9 to 7a19283 Compare April 1, 2025 13:17

AnnaShaleva added a commit that referenced this pull request Apr 1, 2025

network: sanitize write timeout for TCP peer

a909ea6

Ref. #3835 (comment), sub-second write timeout is too harsh for real networks. Signed-off-by: Anna Shaleva <shaleva.ann@nspcc.ru>

AnnaShaleva force-pushed the blocktime-policy branch 2 times, most recently from a909ea6 to 2abea29 Compare April 7, 2025 10:56

AnnaShaleva added a commit that referenced this pull request Apr 7, 2025

network: sanitize write timeout for TCP peer

2abea29

Ref. #3835 (comment), sub-second write timeout is too harsh for real networks. Signed-off-by: Anna Shaleva <shaleva.ann@nspcc.ru>

AnnaShaleva mentioned this pull request Apr 14, 2025

Native: move MillisecondsPerBlock setting to native Policy neo-project/neo#3895

Merged

10 tasks

core: add documentation to echidnaCSS map of contract states

103eacc

Signed-off-by: Anna Shaleva <shaleva.ann@nspcc.ru>

AnnaShaleva force-pushed the blocktime-policy branch from 2abea29 to e03fdc8 Compare April 16, 2025 11:42

AnnaShaleva added a commit that referenced this pull request Apr 16, 2025

network: sanitize write timeout for TCP peer

e03fdc8

Ref. #3835 (comment), sub-second write timeout is too harsh for real networks. Signed-off-by: Anna Shaleva <shaleva.ann@nspcc.ru>

AnnaShaleva removed the blocked Can't be done because of something label Apr 16, 2025

native: move TimePerBlock setting to native Policy

17829ea

A part of #3745. Signed-off-by: Anna Shaleva <shaleva.ann@nspcc.ru>

AnnaShaleva added a commit that referenced this pull request Apr 16, 2025

network: sanitize write timeout for TCP peer

e0fbeb5

Ref. #3835 (comment), sub-second write timeout is too harsh for real networks. Signed-off-by: Anna Shaleva <shaleva.ann@nspcc.ru>

AnnaShaleva force-pushed the blocktime-policy branch from e03fdc8 to e0fbeb5 Compare April 16, 2025 11:44

AnnaShaleva requested a review from roman-khimov April 16, 2025 11:44

roman-khimov reviewed Apr 18, 2025

View reviewed changes

AnnaShaleva added 2 commits April 18, 2025 12:29

*: integrate Policy's MSPerBlock setting with consensus

de1048c

Close #3745. Signed-off-by: Anna Shaleva <shaleva.ann@nspcc.ru>

network: sanitize write timeout for TCP peer

1d15db3

Ref. #3835 (comment), sub-second write timeout is too harsh for real networks. Signed-off-by: Anna Shaleva <shaleva.ann@nspcc.ru>

AnnaShaleva force-pushed the blocktime-policy branch from e0fbeb5 to 1d15db3 Compare April 18, 2025 09:35

AnnaShaleva requested a review from roman-khimov April 18, 2025 09:35

roman-khimov approved these changes Apr 18, 2025

View reviewed changes

roman-khimov merged commit 3106647 into master Apr 18, 2025
33 of 34 checks passed

roman-khimov deleted the blocktime-policy branch April 18, 2025 10:11

AnnaShaleva added a commit that referenced this pull request Apr 23, 2025

interop, rpcclient: add missing wrappers for Policy Echidna extensions

0e55bd8

Should be a part of #3849 and #3835. Signed-off-by: Anna Shaleva <shaleva.ann@nspcc.ru>

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

native: adapt dynamic block time#3835

native: adapt dynamic block time#3835
roman-khimov merged 4 commits intomasterfrom
blocktime-policy

AnnaShaleva commented Mar 10, 2025 •

edited

Loading

Uh oh!

Uh oh!

Uh oh!

codecov bot commented Mar 12, 2025 •

edited

Loading

Uh oh!

AnnaShaleva commented Mar 19, 2025

Uh oh!

AnnaShaleva commented Mar 20, 2025

Uh oh!

AnnaShaleva commented Mar 20, 2025

Uh oh!

Uh oh!

Uh oh!

AnnaShaleva commented Apr 17, 2025

Uh oh!

roman-khimov left a comment

Uh oh!

AnnaShaleva commented Apr 18, 2025

Uh oh!

AnnaShaleva commented Apr 18, 2025

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants

Conversation

AnnaShaleva commented Mar 10, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

Uh oh!

Uh oh!

codecov bot commented Mar 12, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Codecov Report

Uh oh!

AnnaShaleva commented Mar 19, 2025

Uh oh!

AnnaShaleva commented Mar 20, 2025

Uh oh!

AnnaShaleva commented Mar 20, 2025

Uh oh!

Uh oh!

Uh oh!

AnnaShaleva commented Apr 17, 2025

Uh oh!

roman-khimov left a comment

Choose a reason for hiding this comment

Uh oh!

AnnaShaleva commented Apr 18, 2025

Uh oh!

AnnaShaleva commented Apr 18, 2025

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants

AnnaShaleva commented Mar 10, 2025 •

edited

Loading

codecov bot commented Mar 12, 2025 •

edited

Loading