*: adapt state-dependent block producing time#147
Merged
roman-khimov merged 1 commit intomasterfrom Mar 20, 2025
Merged
Conversation
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #147 +/- ##
==========================================
- Coverage 57.86% 57.66% -0.20%
==========================================
Files 33 33
Lines 2283 2277 -6
==========================================
- Hits 1321 1313 -8
- Misses 873 875 +2
Partials 89 89 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
Member
roman-khimov
left a comment
There was a problem hiding this comment.
height parameter
But why if we're always running dbft for the next block?
Member
Author
As I said, I don't think it's needed, because every dependent service is OK with the current behaviour. I just wanted to hear your opinion. |
Ref. nspcc-dev/neo-go#3745. Signed-off-by: Anna Shaleva <shaleva.ann@nspcc.ru>
0cd7c07 to
b5dd36e
Compare
Member
Author
|
@roman-khimov, ready for review, it's the final implementation, we can merge it. |
roman-khimov
approved these changes
Mar 20, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Ref. nspcc-dev/neo-go#3745.
Let's firstly finalize nspcc-dev/neo-go#3835 before the merge, because we might want to add
heightparameter toWithSecondsPerBlocksetting (to me it's not needed, but still may be considered).