native: move MaxValidUntilBlockIncrement to Policy#3849
Merged
roman-khimov merged 3 commits intomasterfrom Apr 10, 2025
Merged
Conversation
AnnaShaleva
commented
Mar 26, 2025
d2d91f1 to
3d1c143
Compare
Member
Author
|
@roman-khimov, MaxVUBIncrement change relatively simple, but MaxTraceableBlocks is a little bit more unobvious, there's a couple of places where "hacks" need to be used to properly handle some situations. Take a look at the TODO comments, please. |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #3849 +/- ##
==========================================
+ Coverage 82.54% 82.56% +0.01%
==========================================
Files 342 342
Lines 47970 48023 +53
==========================================
+ Hits 39599 39648 +49
- Misses 6735 6737 +2
- Partials 1636 1638 +2 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
3d1c143 to
3c7cc19
Compare
Member
Author
|
Let's use this PR for |
AnnaShaleva
added a commit
to neo-project/neo
that referenced
this pull request
Mar 31, 2025
The problem is described in nspcc-dev/neo-go#3841. In short words, the chain's state is dependent on MaxValidUntilBlockIncrement setting, whereas this setting depends on the block time. Since block generation time is a part of native Policy (#3622), MaxValidUntilBlockIncrement should follow, we need the same value to be applied at all CNs simultaneously. Port nspcc-dev/neo-go#3849. Signed-off-by: Anna Shaleva <shaleva.ann@nspcc.ru>
AnnaShaleva
added a commit
to neo-project/neo
that referenced
this pull request
Mar 31, 2025
The problem is described in nspcc-dev/neo-go#3841. In short words, the chain's state is dependent on MaxValidUntilBlockIncrement setting, whereas this setting depends on the block time. Since block generation time is a part of native Policy (#3622), MaxValidUntilBlockIncrement should follow, we need the same value to be applied at all CNs simultaneously. Port nspcc-dev/neo-go#3849. Signed-off-by: Anna Shaleva <shaleva.ann@nspcc.ru>
10 tasks
3c7cc19 to
da5deec
Compare
NGDAdmin
pushed a commit
to neo-project/neo
that referenced
this pull request
Apr 10, 2025
* Native: move MaxValidUntilBlockIncrement to native Policy The problem is described in nspcc-dev/neo-go#3841. In short words, the chain's state is dependent on MaxValidUntilBlockIncrement setting, whereas this setting depends on the block time. Since block generation time is a part of native Policy (#3622), MaxValidUntilBlockIncrement should follow, we need the same value to be applied at all CNs simultaneously. Port nspcc-dev/neo-go#3849. Signed-off-by: Anna Shaleva <shaleva.ann@nspcc.ru> * Extensions: improve formatting No functional changes. Signed-off-by: Anna Shaleva <shaleva.ann@nspcc.ru> * Native: set maximum constraint for MaxValidUntilBlockIncrement It's set to be a day of 1-second blocks, that should be enough, ref. #3861 (comment). Signed-off-by: Anna Shaleva <shaleva.ann@nspcc.ru> --------- Signed-off-by: Anna Shaleva <shaleva.ann@nspcc.ru> Co-authored-by: Shargon <shargon@gmail.com> Co-authored-by: Will <201105916+Wi1l-B0t@users.noreply.github.com> Co-authored-by: Christopher Schuchardt <cschuchardt88@gmail.com> Co-authored-by: Jimmy <jinghui@wayne.edu>
e3eeaf5 to
e481f71
Compare
A part of #3841. Signed-off-by: Anna Shaleva <shaleva.ann@nspcc.ru>
e481f71 to
d414d8a
Compare
Signed-off-by: Anna Shaleva <shaleva.ann@nspcc.ru>
Signed-off-by: Anna Shaleva <shaleva.ann@nspcc.ru>
roman-khimov
approved these changes
Apr 10, 2025
cschuchardt88
added a commit
to cschuchardt88/neo
that referenced
this pull request
Jun 8, 2025
…ect#3861) * Native: move MaxValidUntilBlockIncrement to native Policy The problem is described in nspcc-dev/neo-go#3841. In short words, the chain's state is dependent on MaxValidUntilBlockIncrement setting, whereas this setting depends on the block time. Since block generation time is a part of native Policy (neo-project#3622), MaxValidUntilBlockIncrement should follow, we need the same value to be applied at all CNs simultaneously. Port nspcc-dev/neo-go#3849. Signed-off-by: Anna Shaleva <shaleva.ann@nspcc.ru> * Extensions: improve formatting No functional changes. Signed-off-by: Anna Shaleva <shaleva.ann@nspcc.ru> * Native: set maximum constraint for MaxValidUntilBlockIncrement It's set to be a day of 1-second blocks, that should be enough, ref. neo-project#3861 (comment). Signed-off-by: Anna Shaleva <shaleva.ann@nspcc.ru> --------- Signed-off-by: Anna Shaleva <shaleva.ann@nspcc.ru> Co-authored-by: Shargon <shargon@gmail.com> Co-authored-by: Will <201105916+Wi1l-B0t@users.noreply.github.com> Co-authored-by: Christopher Schuchardt <cschuchardt88@gmail.com> Co-authored-by: Jimmy <jinghui@wayne.edu>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
A part of #3841. Port neo-project/neo#3861.