Skip to content

Language VHDL updated#2659

Closed
cmeriaux wants to merge 1 commit intonotepad-plus-plus:masterfrom
cmeriaux:vhdl
Closed

Language VHDL updated#2659
cmeriaux wants to merge 1 commit intonotepad-plus-plus:masterfrom
cmeriaux:vhdl

Conversation

@cmeriaux
Copy link
Contributor

Fixes #1848

Reserved keyword from IEEE 1076-2008 LRM §15.10

Comments for reviewer : news keywords have been appened on line 247

<Language name="vhdl" ext="vhd vhdl" commentLine="--">
<Keywords name="instre1">access after alias all architecture array assert attribute begin block body buffer bus case component configuration constant disconnect downto else elsif end entity exit file for function generate generic group guarded if impure in inertial inout is label library linkage literal loop map new next null of on open others out package port postponed procedure process pure range record register reject report return select severity shared signal subtype then to transport type unaffected units until use variable wait when while with</Keywords>
<Keywords name="instre1">access after alias all architecture array assert attribute begin block body buffer bus case component configuration constant disconnect downto else elsif end entity exit file for function generate generic group guarded if impure in inertial inout is label library linkage literal loop map new next null of on open others out package port postponed procedure process pure range record register reject report return select severity shared signal subtype then to transport type unaffected units until use variable wait when while with
assume assume_guarantee context cover default fairness force parameter property protected release restrict restrict_guarantee sequence strong vmode vprop vunit</Keywords>
Copy link
Member

@donho donho Dec 23, 2016

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

why such space between "with" and "assume"?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

"assume" is on a new line and is aligned with the first keyword of the previous line. I did it to makes the review easier.
Do you wants me to put it back on one line ?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@donho can you give me an update please ?

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@cmeriaux It's nice to make review easier but inserting the spaces for such purpose is just pointless - these spaces will be merged into code base. Not reformating the current code for such purpose is reasonable enough to me.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@donho OK I will remove those spaces

@cmeriaux cmeriaux force-pushed the vhdl branch 3 times, most recently from 736521e to e91e9f8 Compare January 17, 2017 06:32
Reserved keyword from IEEE 1076-2008 LRM §15.10
@donho donho self-assigned this Jan 18, 2017
@donho donho added the accepted label Jan 18, 2017
@donho donho added this to the 7.x (master) milestone Jan 18, 2017
@donho donho closed this in 96ed68c Jan 22, 2017
SinghRajenM added a commit to SinghRajenM/notepad-plus-plus that referenced this pull request Jan 30, 2017
* Simplify determination of URL at click location

Closes notepad-plus-plus#1248, Closes notepad-plus-plus#1255, Closes notepad-plus-plus#1595, Closes notepad-plus-plus#1762, Closes notepad-plus-plus#1768, Closes notepad-plus-plus#2583

* Get back Find dialog while you lost it

In the environment of multi-monitor with a laptop + a stantion, it
happens all the time that users have lost Find dialog after detaching
and retatching - the solution: Ctrl-F twice will get back your Find
dialog.

* Add to recent file history only if file is removed from all the views

There might be cases when file is cloned/moved to view. Don't add to recent list unless file is removed from all the views
Closes notepad-plus-plus#2665, Fixes notepad-plus-plus#2277

* Fix the problem of launch Notepad++ with Admin right after installation.

Launch N++ with same privileges as explorer
FIxes notepad-plus-plus#2641, fixes notepad-plus-plus#159, fixes notepad-plus-plus#556, closes notepad-plus-plus#2643

* Add MD5 functionalities

* Notepad++ v7.3 release

* Fix "Don't check at launch time" not working problem

Preferences... -> Recent Files History -> Don't check at launch time
does not work anymore. If it is unchecked, it will be checked again on
next Notepad++ launch time.
Fixes notepad-plus-plus#2746

* Fix geneation of MD5 on Unicode bug

"Geneate MD5 fom text dialog" has geneated wrong result on non ANSI
character (Unicode text).  This bug is due to wong input data.

Fixes notepad-plus-plus#2743

* Add some functions for future use

* Fix the shadow declarations & make VS2015 compile again

* Fix VS 2015 post build error

* Enhancement of  "Word characters list"

While double-clicking to select or searching with "Match whole word
only" option, the selected characters stop on non-word characters. With
this enhancement, users can include any non-word character into word
characters list, to change its default behaviour.

* Update 3 translations

* Fix an issue due to VS2015 compiling result (bug)

* Add new language Breton

* Update chineseSimplified.xml

Closes notepad-plus-plus#2748

* Add some missing AutoIt keywords

Closes notepad-plus-plus#2728

* Update german.xml to 7.3.1

Including the suggestion notepad-plus-plus#2737 from notepad-plus-plus#2737

Closes notepad-plus-plus#2741

* Update bulgarian.xml

Closes notepad-plus-plus#2751

* Improve Folder Browse And Save Dialog

Enable the new user interface for "Folder Browse Dialog" including the
edit box and enable Vista style for "Save Dialog".

Closes notepad-plus-plus#2631

* Fix warning display for Word char list bug

* Notepad++ v7.3.1 release

* Add Plugins Administrator (UI part, in progress)

* Make VS2015 compile again

* update japanese.xml to v7.3.1

Closes notepad-plus-plus#2697

* Update ukrainian.xml to v7.3.1

Closes notepad-plus-plus#2787

* Update italian to v7.3.1

Update italian translation according to version 7.3.1 (MD5 tool &
Customization of Word char set)

Closes notepad-plus-plus#2745

* Hungarian translation update for 7.3.1

Closes notepad-plus-plus#2742

* Language VHDL updated

Reserved keyword from IEEE 1076-2008 LRM §15.10
Closes notepad-plus-plus#2659

* Update danish.xml to 7.3.1

Closes notepad-plus-plus#2810

* Enable Scintilla Lexer SCLEX_BAAN (BaanC Language)

Closes notepad-plus-plus#2696

* Fix the regression in settings

Closes notepad-plus-plus#2814

* FunctionList Update 2

* Implemented XML Schema for functionList.xml.
* functionList.xml:
1. new layout of association map;
2. placed `displayName` before `id` attribute where applicable;
3. utilize inline comments;
4. parsers added: 'XML for FunctionList', Assembly, AutoIt3, InnoSetup, PowerShell, KRL, Sinumerik and UniVerse BASIC;
5. parsers improved: C, Java, Batch, Bash, XML and NSIS;
6. replaced `[\t\x20]` with `\h` where possible;
7. using upper case notation for hexadecimal values e.g. `\x7F-\xFF`;

Closes notepad-plus-plus#2602

* Go to correct position after word completion

Closes notepad-plus-plus#2675, Closes notepad-plus-plus#2802
SinghRajenM added a commit to SinghRajenM/notepad-plus-plus that referenced this pull request Jan 30, 2017
* Simplify determination of URL at click location

Closes notepad-plus-plus#1248, Closes notepad-plus-plus#1255, Closes notepad-plus-plus#1595, Closes notepad-plus-plus#1762, Closes notepad-plus-plus#1768, Closes notepad-plus-plus#2583

* Get back Find dialog while you lost it

In the environment of multi-monitor with a laptop + a stantion, it
happens all the time that users have lost Find dialog after detaching
and retatching - the solution: Ctrl-F twice will get back your Find
dialog.

* Add to recent file history only if file is removed from all the views

There might be cases when file is cloned/moved to view. Don't add to recent list unless file is removed from all the views
Closes notepad-plus-plus#2665, Fixes notepad-plus-plus#2277

* Fix the problem of launch Notepad++ with Admin right after installation.

Launch N++ with same privileges as explorer
FIxes notepad-plus-plus#2641, fixes notepad-plus-plus#159, fixes notepad-plus-plus#556, closes notepad-plus-plus#2643

* Add MD5 functionalities

* Notepad++ v7.3 release

* Fix "Don't check at launch time" not working problem

Preferences... -> Recent Files History -> Don't check at launch time
does not work anymore. If it is unchecked, it will be checked again on
next Notepad++ launch time.
Fixes notepad-plus-plus#2746

* Fix geneation of MD5 on Unicode bug

"Geneate MD5 fom text dialog" has geneated wrong result on non ANSI
character (Unicode text).  This bug is due to wong input data.

Fixes notepad-plus-plus#2743

* Add some functions for future use

* Fix the shadow declarations & make VS2015 compile again

* Fix VS 2015 post build error

* Enhancement of  "Word characters list"

While double-clicking to select or searching with "Match whole word
only" option, the selected characters stop on non-word characters. With
this enhancement, users can include any non-word character into word
characters list, to change its default behaviour.

* Update 3 translations

* Fix an issue due to VS2015 compiling result (bug)

* Add new language Breton

* Update chineseSimplified.xml

Closes notepad-plus-plus#2748

* Add some missing AutoIt keywords

Closes notepad-plus-plus#2728

* Update german.xml to 7.3.1

Including the suggestion notepad-plus-plus#2737 from notepad-plus-plus#2737

Closes notepad-plus-plus#2741

* Update bulgarian.xml

Closes notepad-plus-plus#2751

* Improve Folder Browse And Save Dialog

Enable the new user interface for "Folder Browse Dialog" including the
edit box and enable Vista style for "Save Dialog".

Closes notepad-plus-plus#2631

* Fix warning display for Word char list bug

* Notepad++ v7.3.1 release

* Add Plugins Administrator (UI part, in progress)

* Make VS2015 compile again

* update japanese.xml to v7.3.1

Closes notepad-plus-plus#2697

* Update ukrainian.xml to v7.3.1

Closes notepad-plus-plus#2787

* Update italian to v7.3.1

Update italian translation according to version 7.3.1 (MD5 tool &
Customization of Word char set)

Closes notepad-plus-plus#2745

* Hungarian translation update for 7.3.1

Closes notepad-plus-plus#2742

* Language VHDL updated

Reserved keyword from IEEE 1076-2008 LRM §15.10
Closes notepad-plus-plus#2659

* Update danish.xml to 7.3.1

Closes notepad-plus-plus#2810

* Enable Scintilla Lexer SCLEX_BAAN (BaanC Language)

Closes notepad-plus-plus#2696

* Fix the regression in settings

Closes notepad-plus-plus#2814

* FunctionList Update 2

* Implemented XML Schema for functionList.xml.
* functionList.xml:
1. new layout of association map;
2. placed `displayName` before `id` attribute where applicable;
3. utilize inline comments;
4. parsers added: 'XML for FunctionList', Assembly, AutoIt3, InnoSetup, PowerShell, KRL, Sinumerik and UniVerse BASIC;
5. parsers improved: C, Java, Batch, Bash, XML and NSIS;
6. replaced `[\t\x20]` with `\h` where possible;
7. using upper case notation for hexadecimal values e.g. `\x7F-\xFF`;

Closes notepad-plus-plus#2602

* Go to correct position after word completion

Closes notepad-plus-plus#2675, Closes notepad-plus-plus#2802
@cmeriaux cmeriaux deleted the vhdl branch February 1, 2017 07:02
iczelia pushed a commit to iczelia/notepad-plus-plus that referenced this pull request Jan 17, 2021
Reserved keyword from IEEE 1076-2008 LRM §15.10
Closes notepad-plus-plus#2659
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants