FunctionList Update 2 by MAPJe71 · Pull Request #2602 · notepad-plus-plus/notepad-plus-plus

MAPJe71 · 2016-11-24T06:56:20Z

Implemented XML Schema for functionList.xml.
functionList.xml:
- new layout of association map;
- placed displayName before id attribute where applicable;
- utilize inline comments;
- parsers added: 'XML for FunctionList', Assembly, AutoIt3 (Community topic 12070), InnoSetup, PowerShell (Add Powershell support to function List #2317 and Community topic 12475), KRL (half of Community topic 12264), Sinumerik (Community topic 12520) and UniVerse BASIC (Community topic 12742);
- parsers improved: C (Community topics 12263 and 12917), Java (Function List not working with Java files with AutoDoc comments #1015 and Community topic 12691), Batch, Bash (Enhance shell support in function List #2318), XML and NSIS (Improved FunctionList's NSIS parser #2462);
- replaced [\t\x20] with \h where possible;
- using upper case notation for hexadecimal values e.g. \x7F-\xFF;

donho · 2016-11-25T13:48:54Z

I see a regression so far in NSIS:

!macro define_detectVersionToInstall threadid
Var common_15
Function detectVersionToInstall
	Pop $common_15
FunctionEnd
Function detectVersionToInstall_${threadid}
	${If} $VER != "noVersion"
		return
	${EndIf}
FunctionEnd
!macroend

The code above has 1 macro and 2 functions. With the current functionList all 3 are listed. Whereas in yours only 2 are listed, the middle function entry is skipped.

donho · 2016-11-25T14:07:43Z

In C, it's better than old one (according the sample I use to test), and I like the idea of parameters including .
However, not all macros are detected, and one wrong entry (see attatched file).
INFBLOCK.zip

donho · 2016-11-25T14:29:52Z

Java : I have tried with attached file, and got the following declarations are listed as function entries:

    native public void onErrorNative(int what, int extra, long id);
    native public void onBufferingUpdateNative(int percent, long id);
    native public void onProgressUpdateNative(int progress, long id);
    native public void onDurationChangedNative(int duration, long id);
    native public void onInfoNative(int what, int extra, long id);
    native public void onVideoSizeChangedNative(int width, int height, long id);
    native public void onStateChangedNative(int state, long id);

For me, function list provides only entries of function denition. What do you think?

QtAndroidMediaPlayer.zip

donho · 2016-11-25T15:08:18Z

It seems OK for me for Batch and Bash. Good work, @MAPJe71

MAPJe71 · 2016-11-26T02:39:11Z

I try to base a languages parser on its grammar. When I can't find a/the grammar I use gathered source files and presume they are proper examples knowing the latter is not always the case. Furthermore, I'm not familiar with every language and their quirks so any comment to improve a parser is appreciated.

@donho

NSIS:
When the functions contained in a macro are indented it will show the macro only.

!macro define_detectVersionToInstall threadid
    Var common_15
    Function detectVersionToInstall
        Pop $common_15
    FunctionEnd
    Function detectVersionToInstall_${threadid}
        ${If} $VER != "noVersion"
            return
        ${EndIf}
    FunctionEnd
!macroend

Q: How should functions contained in a macro be listed?

separately (i.e. in addition to the macro itself);

    [-] example.nsi
     +--- define_detectVersionToInstall threadid
     +--- detectVersionToInstall
     \--- detectVersionToInstall_${threadid}

as 'members/leafs' of a macro 'class/branch'.

    [-] example.nsi
     \---[-] define_detectVersionToInstall threadid
          +--- detectVersionToInstall
          \--- detectVersionToInstall_${threadid}

C:
Macros are a PITA :) I'll have another look.

Java:
Oops, will update.
And yes I agree FunctionList should only display definitions.

donho · 2016-11-26T10:33:38Z

Q: How should functions contained in a macro be listed?

I'm not an expert of NSIS, but I'm sure that a macro can contain several functions - the sample I provided is a piece of code come from a compilable nsis file. Unfortunately I cannot provide you the whole code source here.

Macros are a PITA :)

Macro entries is a "nice to have" feature. However, it's not indispensable in "function" list. :)

MAPJe71 · 2016-11-27T03:31:51Z

Fixed Java parser.

donho · 2016-11-27T11:29:02Z

@MAPJe71 Please let me know while C and NSIS are fixed.

* Implemented XML Schema for functionList.xml. * functionList.xml: 1. new layout of association map; 2. placed `displayName` before `id` attribute where applicable; 3. utilize inline comments; 4. parsers added: 'XML for FunctionList', Assembly, AutoIt3, InnoSetup, PowerShell, KRL, Sinumerik and UniVerse BASIC; 5. parsers improved: C, Java, Batch, Bash, XML and NSIS; 6. replaced `[\t\x20]` with `\h` where possible; 7. using upper case notation for hexadecimal values e.g. `\x7F-\xFF`;

MAPJe71 · 2016-12-29T06:48:52Z

@donho Fixed C, NSIS, KRL and UniVerse BASIC parsers.

dail8859 · 2017-01-27T22:30:13Z

@MAPJe71 can #1015 be closed now? (All the other issues you referenced in the original post are already closed.)

MAPJe71 · 2017-01-27T22:50:57Z

@dail8859 Yes.

dail8859 · 2017-01-27T22:53:13Z

Thanks

* Simplify determination of URL at click location Closes notepad-plus-plus#1248, Closes notepad-plus-plus#1255, Closes notepad-plus-plus#1595, Closes notepad-plus-plus#1762, Closes notepad-plus-plus#1768, Closes notepad-plus-plus#2583 * Get back Find dialog while you lost it In the environment of multi-monitor with a laptop + a stantion, it happens all the time that users have lost Find dialog after detaching and retatching - the solution: Ctrl-F twice will get back your Find dialog. * Add to recent file history only if file is removed from all the views There might be cases when file is cloned/moved to view. Don't add to recent list unless file is removed from all the views Closes notepad-plus-plus#2665, Fixes notepad-plus-plus#2277 * Fix the problem of launch Notepad++ with Admin right after installation. Launch N++ with same privileges as explorer FIxes notepad-plus-plus#2641, fixes notepad-plus-plus#159, fixes notepad-plus-plus#556, closes notepad-plus-plus#2643 * Add MD5 functionalities * Notepad++ v7.3 release * Fix "Don't check at launch time" not working problem Preferences... -> Recent Files History -> Don't check at launch time does not work anymore. If it is unchecked, it will be checked again on next Notepad++ launch time. Fixes notepad-plus-plus#2746 * Fix geneation of MD5 on Unicode bug "Geneate MD5 fom text dialog" has geneated wrong result on non ANSI character (Unicode text). This bug is due to wong input data. Fixes notepad-plus-plus#2743 * Add some functions for future use * Fix the shadow declarations & make VS2015 compile again * Fix VS 2015 post build error * Enhancement of "Word characters list" While double-clicking to select or searching with "Match whole word only" option, the selected characters stop on non-word characters. With this enhancement, users can include any non-word character into word characters list, to change its default behaviour. * Update 3 translations * Fix an issue due to VS2015 compiling result (bug) * Add new language Breton * Update chineseSimplified.xml Closes notepad-plus-plus#2748 * Add some missing AutoIt keywords Closes notepad-plus-plus#2728 * Update german.xml to 7.3.1 Including the suggestion notepad-plus-plus#2737 from notepad-plus-plus#2737 Closes notepad-plus-plus#2741 * Update bulgarian.xml Closes notepad-plus-plus#2751 * Improve Folder Browse And Save Dialog Enable the new user interface for "Folder Browse Dialog" including the edit box and enable Vista style for "Save Dialog". Closes notepad-plus-plus#2631 * Fix warning display for Word char list bug * Notepad++ v7.3.1 release * Add Plugins Administrator (UI part, in progress) * Make VS2015 compile again * update japanese.xml to v7.3.1 Closes notepad-plus-plus#2697 * Update ukrainian.xml to v7.3.1 Closes notepad-plus-plus#2787 * Update italian to v7.3.1 Update italian translation according to version 7.3.1 (MD5 tool & Customization of Word char set) Closes notepad-plus-plus#2745 * Hungarian translation update for 7.3.1 Closes notepad-plus-plus#2742 * Language VHDL updated Reserved keyword from IEEE 1076-2008 LRM §15.10 Closes notepad-plus-plus#2659 * Update danish.xml to 7.3.1 Closes notepad-plus-plus#2810 * Enable Scintilla Lexer SCLEX_BAAN (BaanC Language) Closes notepad-plus-plus#2696 * Fix the regression in settings Closes notepad-plus-plus#2814 * FunctionList Update 2 * Implemented XML Schema for functionList.xml. * functionList.xml: 1. new layout of association map; 2. placed `displayName` before `id` attribute where applicable; 3. utilize inline comments; 4. parsers added: 'XML for FunctionList', Assembly, AutoIt3, InnoSetup, PowerShell, KRL, Sinumerik and UniVerse BASIC; 5. parsers improved: C, Java, Batch, Bash, XML and NSIS; 6. replaced `[\t\x20]` with `\h` where possible; 7. using upper case notation for hexadecimal values e.g. `\x7F-\xFF`; Closes notepad-plus-plus#2602 * Go to correct position after word completion Closes notepad-plus-plus#2675, Closes notepad-plus-plus#2802

* Implemented XML Schema for functionList.xml. * functionList.xml: 1. new layout of association map; 2. placed `displayName` before `id` attribute where applicable; 3. utilize inline comments; 4. parsers added: 'XML for FunctionList', Assembly, AutoIt3, InnoSetup, PowerShell, KRL, Sinumerik and UniVerse BASIC; 5. parsers improved: C, Java, Batch, Bash, XML and NSIS; 6. replaced `[\t\x20]` with `\h` where possible; 7. using upper case notation for hexadecimal values e.g. `\x7F-\xFF`; Closes notepad-plus-plus#2602

MAPJe71 mentioned this pull request Nov 24, 2016

Function list not working when JavaScript function name is followed by a space #2604

Closed

MAPJe71 force-pushed the FunctionList-Update2 branch from bb8a743 to c907339 Compare November 27, 2016 03:29

donho added the suspended label Nov 30, 2016

MAPJe71 force-pushed the FunctionList-Update2 branch from c907339 to a67fb50 Compare December 29, 2016 06:19

donho added accepted and removed suspended labels Jan 18, 2017

donho self-assigned this Jan 18, 2017

donho added this to the 7.x (master) milestone Jan 18, 2017

donho closed this in 9dc109f Jan 27, 2017

MAPJe71 deleted the FunctionList-Update2 branch January 27, 2017 10:48

dail8859 mentioned this pull request Jan 27, 2017

Function List not working with Java files with AutoDoc comments #1015

Closed

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

FunctionList Update 2#2602

FunctionList Update 2#2602
MAPJe71 wants to merge 1 commit intonotepad-plus-plus:masterfrom
MAPJe71:FunctionList-Update2

MAPJe71 commented Nov 24, 2016 •

edited

Loading

Uh oh!

donho commented Nov 25, 2016 •

edited

Loading

Uh oh!

donho commented Nov 25, 2016 •

edited

Loading

Uh oh!

donho commented Nov 25, 2016 •

edited

Loading

Uh oh!

donho commented Nov 25, 2016

Uh oh!

MAPJe71 commented Nov 26, 2016

Uh oh!

donho commented Nov 26, 2016

Uh oh!

MAPJe71 commented Nov 27, 2016

Uh oh!

donho commented Nov 27, 2016

Uh oh!

MAPJe71 commented Dec 29, 2016

Uh oh!

dail8859 commented Jan 27, 2017

Uh oh!

MAPJe71 commented Jan 27, 2017

Uh oh!

dail8859 commented Jan 27, 2017

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

Conversation

MAPJe71 commented Nov 24, 2016 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

donho commented Nov 25, 2016 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

donho commented Nov 25, 2016 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

donho commented Nov 25, 2016 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

donho commented Nov 25, 2016

Uh oh!

MAPJe71 commented Nov 26, 2016

Uh oh!

donho commented Nov 26, 2016

Uh oh!

MAPJe71 commented Nov 27, 2016

Uh oh!

donho commented Nov 27, 2016

Uh oh!

MAPJe71 commented Dec 29, 2016

Uh oh!

dail8859 commented Jan 27, 2017

Uh oh!

MAPJe71 commented Jan 27, 2017

Uh oh!

dail8859 commented Jan 27, 2017

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

MAPJe71 commented Nov 24, 2016 •

edited

Loading

donho commented Nov 25, 2016 •

edited

Loading

donho commented Nov 25, 2016 •

edited

Loading

donho commented Nov 25, 2016 •

edited

Loading