Patch for #1595 and #1762 (incorrect URL)#1768
Closed
AlyxMoon wants to merge 1 commit intonotepad-plus-plus:masterfrom
Closed
Patch for #1595 and #1762 (incorrect URL)#1768AlyxMoon wants to merge 1 commit intonotepad-plus-plus:masterfrom
AlyxMoon wants to merge 1 commit intonotepad-plus-plus:masterfrom
Conversation
…t URL) URL's were getting cutoff when certain characters were included in the URL, they were not considered appropriate characters in the function. Added the following deliminators to the function responsible for parsing a URL (in SCN_HOTSPOTDOUBLECLICK): "!" ";" "$" "*" Fixes issues notepad-plus-plus#1595 and
|
Thank you @AlyxMoon, |
Member
|
Could you provid a example of url which doesn't work in the current version? |
Contributor
|
Any url with |
|
@donho for example the one mentioned in issue #1595 |
dail8859
added a commit
to dail8859/notepad-plus-plus
that referenced
this pull request
Nov 15, 2016
Closes notepad-plus-plus#1248, Closes notepad-plus-plus#1255, Closes notepad-plus-plus#1595, Closes notepad-plus-plus#1762, Closes notepad-plus-plus#1768
dail8859
added a commit
to dail8859/notepad-plus-plus
that referenced
this pull request
Nov 19, 2016
Closes notepad-plus-plus#1248, Closes notepad-plus-plus#1255, Closes notepad-plus-plus#1595, Closes notepad-plus-plus#1762, Closes notepad-plus-plus#1768
dail8859
added a commit
to dail8859/notepad-plus-plus
that referenced
this pull request
Nov 19, 2016
Closes notepad-plus-plus#1248, Closes notepad-plus-plus#1255, Closes notepad-plus-plus#1595, Closes notepad-plus-plus#1762, Closes notepad-plus-plus#1768
SinghRajenM
added a commit
to SinghRajenM/notepad-plus-plus
that referenced
this pull request
Jan 30, 2017
* Simplify determination of URL at click location Closes notepad-plus-plus#1248, Closes notepad-plus-plus#1255, Closes notepad-plus-plus#1595, Closes notepad-plus-plus#1762, Closes notepad-plus-plus#1768, Closes notepad-plus-plus#2583 * Get back Find dialog while you lost it In the environment of multi-monitor with a laptop + a stantion, it happens all the time that users have lost Find dialog after detaching and retatching - the solution: Ctrl-F twice will get back your Find dialog. * Add to recent file history only if file is removed from all the views There might be cases when file is cloned/moved to view. Don't add to recent list unless file is removed from all the views Closes notepad-plus-plus#2665, Fixes notepad-plus-plus#2277 * Fix the problem of launch Notepad++ with Admin right after installation. Launch N++ with same privileges as explorer FIxes notepad-plus-plus#2641, fixes notepad-plus-plus#159, fixes notepad-plus-plus#556, closes notepad-plus-plus#2643 * Add MD5 functionalities * Notepad++ v7.3 release * Fix "Don't check at launch time" not working problem Preferences... -> Recent Files History -> Don't check at launch time does not work anymore. If it is unchecked, it will be checked again on next Notepad++ launch time. Fixes notepad-plus-plus#2746 * Fix geneation of MD5 on Unicode bug "Geneate MD5 fom text dialog" has geneated wrong result on non ANSI character (Unicode text). This bug is due to wong input data. Fixes notepad-plus-plus#2743 * Add some functions for future use * Fix the shadow declarations & make VS2015 compile again * Fix VS 2015 post build error * Enhancement of "Word characters list" While double-clicking to select or searching with "Match whole word only" option, the selected characters stop on non-word characters. With this enhancement, users can include any non-word character into word characters list, to change its default behaviour. * Update 3 translations * Fix an issue due to VS2015 compiling result (bug) * Add new language Breton * Update chineseSimplified.xml Closes notepad-plus-plus#2748 * Add some missing AutoIt keywords Closes notepad-plus-plus#2728 * Update german.xml to 7.3.1 Including the suggestion notepad-plus-plus#2737 from notepad-plus-plus#2737 Closes notepad-plus-plus#2741 * Update bulgarian.xml Closes notepad-plus-plus#2751 * Improve Folder Browse And Save Dialog Enable the new user interface for "Folder Browse Dialog" including the edit box and enable Vista style for "Save Dialog". Closes notepad-plus-plus#2631 * Fix warning display for Word char list bug * Notepad++ v7.3.1 release * Add Plugins Administrator (UI part, in progress) * Make VS2015 compile again * update japanese.xml to v7.3.1 Closes notepad-plus-plus#2697 * Update ukrainian.xml to v7.3.1 Closes notepad-plus-plus#2787 * Update italian to v7.3.1 Update italian translation according to version 7.3.1 (MD5 tool & Customization of Word char set) Closes notepad-plus-plus#2745 * Hungarian translation update for 7.3.1 Closes notepad-plus-plus#2742 * Language VHDL updated Reserved keyword from IEEE 1076-2008 LRM §15.10 Closes notepad-plus-plus#2659 * Update danish.xml to 7.3.1 Closes notepad-plus-plus#2810 * Enable Scintilla Lexer SCLEX_BAAN (BaanC Language) Closes notepad-plus-plus#2696 * Fix the regression in settings Closes notepad-plus-plus#2814 * FunctionList Update 2 * Implemented XML Schema for functionList.xml. * functionList.xml: 1. new layout of association map; 2. placed `displayName` before `id` attribute where applicable; 3. utilize inline comments; 4. parsers added: 'XML for FunctionList', Assembly, AutoIt3, InnoSetup, PowerShell, KRL, Sinumerik and UniVerse BASIC; 5. parsers improved: C, Java, Batch, Bash, XML and NSIS; 6. replaced `[\t\x20]` with `\h` where possible; 7. using upper case notation for hexadecimal values e.g. `\x7F-\xFF`; Closes notepad-plus-plus#2602 * Go to correct position after word completion Closes notepad-plus-plus#2675, Closes notepad-plus-plus#2802
SinghRajenM
added a commit
to SinghRajenM/notepad-plus-plus
that referenced
this pull request
Jan 30, 2017
* Simplify determination of URL at click location Closes notepad-plus-plus#1248, Closes notepad-plus-plus#1255, Closes notepad-plus-plus#1595, Closes notepad-plus-plus#1762, Closes notepad-plus-plus#1768, Closes notepad-plus-plus#2583 * Get back Find dialog while you lost it In the environment of multi-monitor with a laptop + a stantion, it happens all the time that users have lost Find dialog after detaching and retatching - the solution: Ctrl-F twice will get back your Find dialog. * Add to recent file history only if file is removed from all the views There might be cases when file is cloned/moved to view. Don't add to recent list unless file is removed from all the views Closes notepad-plus-plus#2665, Fixes notepad-plus-plus#2277 * Fix the problem of launch Notepad++ with Admin right after installation. Launch N++ with same privileges as explorer FIxes notepad-plus-plus#2641, fixes notepad-plus-plus#159, fixes notepad-plus-plus#556, closes notepad-plus-plus#2643 * Add MD5 functionalities * Notepad++ v7.3 release * Fix "Don't check at launch time" not working problem Preferences... -> Recent Files History -> Don't check at launch time does not work anymore. If it is unchecked, it will be checked again on next Notepad++ launch time. Fixes notepad-plus-plus#2746 * Fix geneation of MD5 on Unicode bug "Geneate MD5 fom text dialog" has geneated wrong result on non ANSI character (Unicode text). This bug is due to wong input data. Fixes notepad-plus-plus#2743 * Add some functions for future use * Fix the shadow declarations & make VS2015 compile again * Fix VS 2015 post build error * Enhancement of "Word characters list" While double-clicking to select or searching with "Match whole word only" option, the selected characters stop on non-word characters. With this enhancement, users can include any non-word character into word characters list, to change its default behaviour. * Update 3 translations * Fix an issue due to VS2015 compiling result (bug) * Add new language Breton * Update chineseSimplified.xml Closes notepad-plus-plus#2748 * Add some missing AutoIt keywords Closes notepad-plus-plus#2728 * Update german.xml to 7.3.1 Including the suggestion notepad-plus-plus#2737 from notepad-plus-plus#2737 Closes notepad-plus-plus#2741 * Update bulgarian.xml Closes notepad-plus-plus#2751 * Improve Folder Browse And Save Dialog Enable the new user interface for "Folder Browse Dialog" including the edit box and enable Vista style for "Save Dialog". Closes notepad-plus-plus#2631 * Fix warning display for Word char list bug * Notepad++ v7.3.1 release * Add Plugins Administrator (UI part, in progress) * Make VS2015 compile again * update japanese.xml to v7.3.1 Closes notepad-plus-plus#2697 * Update ukrainian.xml to v7.3.1 Closes notepad-plus-plus#2787 * Update italian to v7.3.1 Update italian translation according to version 7.3.1 (MD5 tool & Customization of Word char set) Closes notepad-plus-plus#2745 * Hungarian translation update for 7.3.1 Closes notepad-plus-plus#2742 * Language VHDL updated Reserved keyword from IEEE 1076-2008 LRM §15.10 Closes notepad-plus-plus#2659 * Update danish.xml to 7.3.1 Closes notepad-plus-plus#2810 * Enable Scintilla Lexer SCLEX_BAAN (BaanC Language) Closes notepad-plus-plus#2696 * Fix the regression in settings Closes notepad-plus-plus#2814 * FunctionList Update 2 * Implemented XML Schema for functionList.xml. * functionList.xml: 1. new layout of association map; 2. placed `displayName` before `id` attribute where applicable; 3. utilize inline comments; 4. parsers added: 'XML for FunctionList', Assembly, AutoIt3, InnoSetup, PowerShell, KRL, Sinumerik and UniVerse BASIC; 5. parsers improved: C, Java, Batch, Bash, XML and NSIS; 6. replaced `[\t\x20]` with `\h` where possible; 7. using upper case notation for hexadecimal values e.g. `\x7F-\xFF`; Closes notepad-plus-plus#2602 * Go to correct position after word completion Closes notepad-plus-plus#2675, Closes notepad-plus-plus#2802
iczelia
pushed a commit
to iczelia/notepad-plus-plus
that referenced
this pull request
Jan 17, 2021
Closes notepad-plus-plus#1248, Closes notepad-plus-plus#1255, Closes notepad-plus-plus#1595, Closes notepad-plus-plus#1762, Closes notepad-plus-plus#1768, Closes notepad-plus-plus#2583
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
URL's were getting cutoff when certain characters were included in the URL, they were not considered appropriate characters in the function.
Added the following deliminators to the function responsible for parsing a URL (in SCN_HOTSPOTDOUBLECLICK):
"!" ";" "$" "*"
Fixes issues #1595 and #1762