Skip to content

Conversation

@shizhMSFT
Copy link
Contributor

@shizhMSFT shizhMSFT commented Nov 6, 2023

Release

This would mean tagging e2f4237 as v1.0.1 to release.

Vote

We need at least 4 approvals from 6 maintainers to release notation v1.0.1.

Changes

The code changes compared to v1.0.0 include:

Full Changelog: v1.0.0...e2f4237

Action Requested

Please respond LGTM (approve) or REJECT (request for changes).

Signed-off-by: Shiwei Zhang <shizh@microsoft.com>
@codecov-commenter
Copy link

Codecov Report

Merging #820 (e2f4237) into release-1.0 (7f8e86c) will not change coverage.
The diff coverage is n/a.

❗ Your organization needs to install the Codecov GitHub app to enable full functionality.

@@             Coverage Diff              @@
##           release-1.0     #820   +/-   ##
============================================
  Coverage        63.94%   63.94%           
============================================
  Files               40       40           
  Lines             2291     2291           
============================================
  Hits              1465     1465           
  Misses             700      700           
  Partials           126      126           
Files Coverage Δ
internal/version/version.go 100.00% <ø> (ø)

📣 Codecov offers a browser extension for seamless coverage viewing on GitHub. Try it in Chrome or Firefox today!

@shizhMSFT
Copy link
Contributor Author

Since v1.0.1 is a patch release, the following feature in the main branch is NOT cherry-picked.

Copy link
Contributor

@JeyJeyGao JeyJeyGao left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link

@ghost ghost left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Contributor

@priteshbandi priteshbandi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@shizhMSFT shizhMSFT merged commit 89c96ef into notaryproject:release-1.0 Nov 7, 2023
@shizhMSFT shizhMSFT deleted the prep-v1.0.1 branch November 7, 2023 02:09
@ghost ghost mentioned this pull request Jan 25, 2024
6 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants