Skip to content

Conversation

@sajayantony
Copy link
Contributor

Addresses the feedback from #750
/cc @gokarnm

Signed-off-by: Sajay Antony <sajaya@microsoft.com>
@sajayantony sajayantony requested a review from a user August 3, 2023 02:16
@shizhMSFT shizhMSFT changed the title update readme from feedback from #750 doc: update readme from feedback from #750 Aug 3, 2023
Copy link
Contributor

@shizhMSFT shizhMSFT left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@shizhMSFT shizhMSFT changed the title doc: update readme from feedback from #750 docs: update readme from feedback from #750 Aug 3, 2023
@codecov-commenter
Copy link

Codecov Report

Merging #757 (7adc1bb) into main (7574cea) will not change coverage.
The diff coverage is n/a.

❗ Your organization is not using the GitHub App Integration. As a result you may experience degraded service beginning May 15th. Please install the Github App Integration for your organization. Read more.

@@           Coverage Diff           @@
##             main     #757   +/-   ##
=======================================
  Coverage   63.98%   63.98%           
=======================================
  Files          40       40           
  Lines        2252     2252           
=======================================
  Hits         1441     1441           
  Misses        689      689           
  Partials      122      122           

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

Copy link

@ghost ghost left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Member

@FeynmanZhou FeynmanZhou left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Contributor

@JeyJeyGao JeyJeyGao left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Contributor

@priteshbandi priteshbandi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@priteshbandi priteshbandi merged commit df2aa57 into notaryproject:main Aug 16, 2023
@shizhMSFT shizhMSFT mentioned this pull request Nov 6, 2023
6 tasks
@ghost ghost mentioned this pull request Jan 25, 2024
6 tasks
7h3-3mp7y-m4n pushed a commit to 7h3-3mp7y-m4n/notation that referenced this pull request Mar 29, 2025
…ct#757)

Addresses [the feedback](notaryproject#750 (comment)) from notaryproject#750
/cc @gokarnm

Signed-off-by: Sajay Antony <sajaya@microsoft.com>
FeynmanZhou pushed a commit to FeynmanZhou/notation that referenced this pull request May 15, 2025
…ct#757)

Addresses [the feedback](notaryproject#750 (comment)) from notaryproject#750
/cc @gokarnm

Signed-off-by: Sajay Antony <sajaya@microsoft.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

6 participants