Skip to content

Conversation

@ghost
Copy link

@ghost ghost commented Oct 31, 2023

Bumping up to notation-go v1.0.1.

Note: The build fails due to E2E test. Therefore, this PR depends on #810

As #810 is merged, bumping up build is successful now.

Patrick Zheng added 2 commits October 31, 2023 10:26
Signed-off-by: Patrick Zheng <patrickzheng@microsoft.com>
Signed-off-by: Patrick Zheng <patrickzheng@microsoft.com>
@JeyJeyGao
Copy link
Contributor

Looks like we need to update E2E testing?

@ghost
Copy link
Author

ghost commented Nov 1, 2023

Looks like we need to update E2E testing?

Yes, as I mentioned, this is fixed in PR #810

priteshbandi
priteshbandi previously approved these changes Nov 1, 2023
Copy link
Contributor

@priteshbandi priteshbandi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@ghost ghost closed this Nov 3, 2023
Signed-off-by: Patrick Zheng <patrickzheng@microsoft.com>
@ghost ghost reopened this Nov 3, 2023
@ghost ghost requested a review from priteshbandi November 3, 2023 00:41
@codecov-commenter
Copy link

Codecov Report

Merging #815 (a787e0d) into main (bb2669b) will not change coverage.
The diff coverage is n/a.

❗ Your organization needs to install the Codecov GitHub app to enable full functionality.

@@           Coverage Diff           @@
##             main     #815   +/-   ##
=======================================
  Coverage   64.05%   64.05%           
=======================================
  Files          40       40           
  Lines        2323     2323           
=======================================
  Hits         1488     1488           
  Misses        709      709           
  Partials      126      126           

📣 Codecov offers a browser extension for seamless coverage viewing on GitHub. Try it in Chrome or Firefox today!

Copy link
Contributor

@JeyJeyGao JeyJeyGao left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Contributor

@shizhMSFT shizhMSFT left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Contributor

@priteshbandi priteshbandi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@priteshbandi priteshbandi merged commit ed70c9d into notaryproject:main Nov 3, 2023
@ghost ghost deleted the bump-up branch November 3, 2023 02:11
shizhMSFT pushed a commit that referenced this pull request Nov 3, 2023
Bumping up to notation-go v1.0.1.
As #810 is merged, bumping
up build is successful now.

---------

Signed-off-by: Patrick Zheng <patrickzheng@microsoft.com>
shizhMSFT pushed a commit that referenced this pull request Nov 3, 2023
Bumping up to notation-go v1.0.1.
As #810 is merged, bumping
up build is successful now.

---------

Signed-off-by: Patrick Zheng <patrickzheng@microsoft.com>
@shizhMSFT shizhMSFT mentioned this pull request Nov 6, 2023
6 tasks
@ghost ghost mentioned this pull request Jan 25, 2024
6 tasks
rgnote pushed a commit to rgnote/notation that referenced this pull request Mar 8, 2024
Bumping up to notation-go v1.0.1.
As notaryproject#810 is merged, bumping
up build is successful now.

---------

Signed-off-by: Patrick Zheng <patrickzheng@microsoft.com>
rgnote pushed a commit to rgnote/notation that referenced this pull request Mar 8, 2024
Bumping up to notation-go v1.0.1.
As notaryproject#810 is merged, bumping
up build is successful now.

---------

Signed-off-by: Patrick Zheng <patrickzheng@microsoft.com>
Signed-off-by: rgnote <5878554+rgnote@users.noreply.github.com>
7h3-3mp7y-m4n pushed a commit to 7h3-3mp7y-m4n/notation that referenced this pull request Mar 29, 2025
Bumping up to notation-go v1.0.1.
As notaryproject#810 is merged, bumping
up build is successful now.

---------

Signed-off-by: Patrick Zheng <patrickzheng@microsoft.com>
FeynmanZhou pushed a commit to FeynmanZhou/notation that referenced this pull request May 15, 2025
Bumping up to notation-go v1.0.1.
As notaryproject#810 is merged, bumping
up build is successful now.

---------

Signed-off-by: Patrick Zheng <patrickzheng@microsoft.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants