Skip to content

Conversation

@JeyJeyGao
Copy link
Contributor

@JeyJeyGao JeyJeyGao commented Oct 10, 2023

Fix:

  • Token-Permissions issue for dev-release.yml: delete the file
  • Token-Permissions issue for license-checker.yml: update the global permission to be read

Resolves part of #408
Signed-off-by: Junjie Gao junjiegao@microsoft.com

@JeyJeyGao JeyJeyGao requested a review from a user October 10, 2023 08:45
@JeyJeyGao JeyJeyGao changed the title fix: scorecard fix: Code scanning issues Oct 10, 2023
@codecov-commenter
Copy link

codecov-commenter commented Oct 10, 2023

Codecov Report

Merging #799 (925f9ab) into main (93e6853) will increase coverage by 63.98%.
The diff coverage is n/a.

❗ Your organization needs to install the Codecov GitHub app to enable full functionality.

@@            Coverage Diff            @@
##           main     #799       +/-   ##
=========================================
+ Coverage      0   63.98%   +63.98%     
=========================================
  Files         0       40       +40     
  Lines         0     2252     +2252     
=========================================
+ Hits          0     1441     +1441     
- Misses        0      689      +689     
- Partials      0      122      +122     

see 40 files with indirect coverage changes

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

ghost
ghost previously approved these changes Oct 10, 2023
Copy link

@ghost ghost left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

shizhMSFT
shizhMSFT previously approved these changes Oct 10, 2023
Copy link
Contributor

@shizhMSFT shizhMSFT left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Glad to see we deprecate the dev release which is not used for a long time.

priteshbandi
priteshbandi previously approved these changes Oct 10, 2023
Copy link
Contributor

@priteshbandi priteshbandi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Signed-off-by: Junjie Gao <junjiegao@microsoft.com>
@JeyJeyGao JeyJeyGao dismissed stale reviews from priteshbandi, shizhMSFT, and ghost via 925f9ab October 11, 2023 07:34
Copy link
Contributor

@priteshbandi priteshbandi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link

@ghost ghost left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@ghost ghost merged commit 6265bf8 into notaryproject:main Oct 12, 2023
shizhMSFT pushed a commit that referenced this pull request Nov 3, 2023
Signed-off-by: Junjie Gao <junjiegao@microsoft.com>
shizhMSFT pushed a commit that referenced this pull request Nov 3, 2023
Signed-off-by: Junjie Gao <junjiegao@microsoft.com>
@shizhMSFT shizhMSFT mentioned this pull request Nov 6, 2023
6 tasks
@ghost ghost mentioned this pull request Jan 25, 2024
6 tasks
7h3-3mp7y-m4n pushed a commit to 7h3-3mp7y-m4n/notation that referenced this pull request Mar 29, 2025
Signed-off-by: Junjie Gao <junjiegao@microsoft.com>
FeynmanZhou pushed a commit to FeynmanZhou/notation that referenced this pull request May 15, 2025
Signed-off-by: Junjie Gao <junjiegao@microsoft.com>
This pull request was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants