-
Notifications
You must be signed in to change notification settings - Fork 10
Backports to v20.x #245
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Closed
Closed
Backports to v20.x #245
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
PR-URL: #216 Reviewed-By: Rafael Gonzaga <rafael.nunu@hotmail.com>
So we can subscribe to the `flagsUpdated` event to receive notifications when the tracing flags have changed. Use it in the otel/core.js:register() method. PR-URL: #216 Reviewed-By: Rafael Gonzaga <rafael.nunu@hotmail.com>
PR-URL: #216 Reviewed-By: Rafael Gonzaga <rafael.nunu@hotmail.com>
Also, a couple of fixes in the updater: - Fix OPENTELEMETRY_VERSION extraction. - Use `third_party_release` file to get the `opentelemetry-proto`. PR-URL: #221 Reviewed-By: Juan José Arboleda <soyjuanarbol@gmail.com>
PR-URL: #221 Reviewed-By: Juan José Arboleda <soyjuanarbol@gmail.com>
`lineNumber`, `columnNumber` and `url` node fields can be actually undefined. Make sure we avoid integer overflows and potential crashes. As an example, if `lineNumber` or `columnNumber` are undefined, they were taking the `4294967295` which obviously doesn't make any sense. PR-URL: #233 Reviewed-By: Juan José Arboleda <soyjuanarbol@gmail.com>
PR-URL: #238 Reviewed-By: Juan José Arboleda <soyjuanarbol@gmail.com>
The runtime now stores the `scriptId` and `url` or `path` of all the loaded cjs and esm modules. A new grpc command has been added to retrieve the source code for any `scriptId`-`url|path` pair by reading the source code from file. In case the specific `scriptId`-`url|path` pair wasn't stored, it returns an error. In the rare case where a ESM is not loaded from a file URL, the code would be stored on loading time. PR-URL: #240 Reviewed-By: Rafael Gonzaga <rafael.nunu@hotmail.com>
PR-URL: #239 Reviewed-By: Juan José Arboleda <soyjuanarbol@gmail.com>
PR-URL: #241 Reviewed-By: Juan José Arboleda <soyjuanarbol@gmail.com>
This will allow less grpc threads/resources to be used. PR-URL: #242 Reviewed-By: Juan José Arboleda <soyjuanarbol@gmail.com>
PR-URL: #236 Reviewed-By: Juan José Arboleda <soyjuanarbol@gmail.com>
While also making sure we're able to connect correctly to both production and staging hosts. PR-URL: #237 Reviewed-By: Juan José Arboleda <soyjuanarbol@gmail.com>
PR-URL: #243 Reviewed-By: Juan José Arboleda <soyjuanarbol@gmail.com>
RafaelGSS
approved these changes
Jan 9, 2025
Member
RafaelGSS
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
RSLGTM
PR-URL: #248 Reviewed-By: Rafael Gonzaga <rafael.nunu@hotmail.com>
`OtlpGrpcClientOptions.use_ssl_credentials` is not initialized by default to `false` as it happens with all their children. Make sure it is otherwise it can produce undesired behaviour. PR-URL: #247 Reviewed-By: Rafael Gonzaga <rafael.nunu@hotmail.com>
And in general, make the `saas` config option handling more robust and consistent. PR-URL: #235 Reviewed-By: Juan José Arboleda <soyjuanarbol@gmail.com>
santigimeno
added a commit
that referenced
this pull request
Jan 13, 2025
`lineNumber`, `columnNumber` and `url` node fields can be actually undefined. Make sure we avoid integer overflows and potential crashes. As an example, if `lineNumber` or `columnNumber` are undefined, they were taking the `4294967295` which obviously doesn't make any sense. PR-URL: #233 Reviewed-By: Juan José Arboleda <soyjuanarbol@gmail.com> PR-URL: #245 Reviewed-By: Rafael Gonzaga <rafael.nunu@hotmail.com>
santigimeno
added a commit
that referenced
this pull request
Jan 13, 2025
The runtime now stores the `scriptId` and `url` or `path` of all the loaded cjs and esm modules. A new grpc command has been added to retrieve the source code for any `scriptId`-`url|path` pair by reading the source code from file. In case the specific `scriptId`-`url|path` pair wasn't stored, it returns an error. In the rare case where a ESM is not loaded from a file URL, the code would be stored on loading time. PR-URL: #240 Reviewed-By: Rafael Gonzaga <rafael.nunu@hotmail.com> PR-URL: #245
santigimeno
added a commit
that referenced
this pull request
Jan 13, 2025
PR-URL: #245 Reviewed-By: Rafael Gonzaga <rafael.nunu@hotmail.com>
Member
Author
santigimeno
added a commit
that referenced
this pull request
Feb 14, 2025
So we can subscribe to the `flagsUpdated` event to receive notifications when the tracing flags have changed. Use it in the otel/core.js:register() method. PR-URL: #216 Reviewed-By: Rafael Gonzaga <rafael.nunu@hotmail.com> PR-URL: #245 PR-URL: #269 Reviewed-By: Juan José Arboleda <soyjuanarbol@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.