lib: fix crash if invalid SaaS token #235
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
8a1d310 to
1cb6216
Compare
8d7b1c5 to
f8db450
Compare
juanarbol
approved these changes
Jan 2, 2025
Contributor
juanarbol
left a comment
There was a problem hiding this comment.
LGTM! Thanks for the extra tests!
And in general, make the `saas` config option handling more robust and consistent.
fcece8f to
f68cad6
Compare
santigimeno
added a commit
that referenced
this pull request
Jan 9, 2025
And in general, make the `saas` config option handling more robust and consistent. PR-URL: #235 Reviewed-By: Juan José Arboleda <soyjuanarbol@gmail.com>
Member
Author
|
Landed in 6b23418 |
santigimeno
added a commit
that referenced
this pull request
Jan 9, 2025
And in general, make the `saas` config option handling more robust and consistent. PR-URL: #235 Reviewed-By: Juan José Arboleda <soyjuanarbol@gmail.com>
santigimeno
added a commit
that referenced
this pull request
Jan 9, 2025
And in general, make the `saas` config option handling more robust and consistent. PR-URL: #235 Reviewed-By: Juan José Arboleda <soyjuanarbol@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
And in general, make the
saasconfig option handling more robust and consistent.