Skip to content

lib: add tracing support for fetch(undici) #216

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
santigimeno wants to merge 3 commits into from
Closed

lib: add tracing support for fetch(undici) #216

santigimeno wants to merge 3 commits into from

Conversation

@santigimeno
Copy link
Member

@santigimeno santigimeno commented Nov 12, 2024 •
edited
Loading

No description provided.

@santigimeno santigimeno force-pushed the santi/undici_fetch_tracing branch 3 times, most recently from e7f8d9c to 4dfb76c Compare November 14, 2024 23:48
@edsadr
Copy link
Member

edsadr commented Dec 9, 2024

this reference https://github.com/nodesource/nsolid-console-ng/issues/3836

@santigimeno
deps: update undici adding code from nodejs/undici#2701
c478c4f
@santigimeno
lib: add nsolidTracer EventEmitter
3451a4c 
So we can subscribe to the `flagsUpdated` event to receive notifications
when the tracing flags have changed.
Use it in the otel/core.js:register() method.
@santigimeno santigimeno force-pushed the santi/undici_fetch_tracing branch from 4dfb76c to 319a658 Compare December 9, 2024 18:06
@RafaelGSS
Copy link
Member

RafaelGSS commented Dec 9, 2024

@santigimeno feel free to ping me when the PR is ready to review.

@santigimeno santigimeno changed the base branch from node-v20.x-nsolid-v5.x to node-v22.x-nsolid-v5.x December 9, 2024 22:16
@santigimeno santigimeno force-pushed the santi/undici_fetch_tracing branch from 319a658 to 1af3ef0 Compare December 9, 2024 22:20
@santigimeno santigimeno force-pushed the santi/undici_fetch_tracing branch from 2ef62d6 to 924a2d1 Compare December 10, 2024 10:58
@santigimeno santigimeno requested review from juanarbol and removed request for trevnorris December 10, 2024 12:58
RafaelGSS
RafaelGSS reviewed Dec 10, 2024
View reviewed changes
santigimeno added a commit that referenced this pull request Dec 16, 2024
@santigimeno
deps: update undici adding code from nodejs/undici#2701
2ab4a1e 
PR-URL: #216
Reviewed-By: Rafael Gonzaga <rafael.nunu@hotmail.com>
santigimeno added a commit that referenced this pull request Dec 16, 2024
@santigimeno
lib: add nsolidTracer EventEmitter
16c1b8c 
So we can subscribe to the `flagsUpdated` event to receive notifications
when the tracing flags have changed.
Use it in the otel/core.js:register() method.

PR-URL: #216
Reviewed-By: Rafael Gonzaga <rafael.nunu@hotmail.com>
santigimeno added a commit that referenced this pull request Dec 16, 2024
@santigimeno
lib: add tracing support for fetch(undici)
f8697d4 
PR-URL: #216
Reviewed-By: Rafael Gonzaga <rafael.nunu@hotmail.com>
@santigimeno
Copy link
Member Author

santigimeno commented Dec 16, 2024

Landed in e858e0c...f8697d4.

@santigimeno santigimeno deleted the santi/undici_fetch_tracing branch December 16, 2024 10:34
santigimeno added a commit that referenced this pull request Jan 3, 2025
@santigimeno
deps: update undici adding code from nodejs/undici#2701
ca42ea0 
PR-URL: #216
Reviewed-By: Rafael Gonzaga <rafael.nunu@hotmail.com>
santigimeno added a commit that referenced this pull request Jan 3, 2025
@santigimeno
lib: add nsolidTracer EventEmitter
6025342 
So we can subscribe to the `flagsUpdated` event to receive notifications
when the tracing flags have changed.
Use it in the otel/core.js:register() method.

PR-URL: #216
Reviewed-By: Rafael Gonzaga <rafael.nunu@hotmail.com>
santigimeno added a commit that referenced this pull request Jan 3, 2025
@santigimeno
lib: add tracing support for fetch(undici)
2b63736 
PR-URL: #216
Reviewed-By: Rafael Gonzaga <rafael.nunu@hotmail.com>
santigimeno added a commit that referenced this pull request Jan 13, 2025
@santigimeno
deps: update undici adding code from nodejs/undici#2701
ab0eea8 
PR-URL: #216
Reviewed-By: Rafael Gonzaga <rafael.nunu@hotmail.com>
PR-URL: #245
santigimeno added a commit that referenced this pull request Jan 13, 2025
@santigimeno
lib: add nsolidTracer EventEmitter
9085399 
So we can subscribe to the `flagsUpdated` event to receive notifications
when the tracing flags have changed.
Use it in the otel/core.js:register() method.

PR-URL: #216
Reviewed-By: Rafael Gonzaga <rafael.nunu@hotmail.com>
PR-URL: #245
santigimeno added a commit that referenced this pull request Jan 13, 2025
@santigimeno
lib: add tracing support for fetch(undici)
41edf02 
PR-URL: #216
Reviewed-By: Rafael Gonzaga <rafael.nunu@hotmail.com>
PR-URL: #245
santigimeno added a commit that referenced this pull request Feb 14, 2025
@santigimeno
lib: add nsolidTracer EventEmitter
a170e11 
So we can subscribe to the `flagsUpdated` event to receive notifications
when the tracing flags have changed.
Use it in the otel/core.js:register() method.

PR-URL: #216
Reviewed-By: Rafael Gonzaga <rafael.nunu@hotmail.com>
PR-URL: #245
santigimeno added a commit that referenced this pull request Feb 14, 2025
@santigimeno
lib: add nsolidTracer EventEmitter
6ece3ef 
So we can subscribe to the `flagsUpdated` event to receive notifications
when the tracing flags have changed.
Use it in the otel/core.js:register() method.

PR-URL: #216
Reviewed-By: Rafael Gonzaga <rafael.nunu@hotmail.com>
PR-URL: #245
PR-URL: #269
Reviewed-By: Juan José Arboleda <soyjuanarbol@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@RafaelGSS RafaelGSS RafaelGSS approved these changes

@juanarbol juanarbol Awaiting requested review from juanarbol

Assignees

@santigimeno santigimeno

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@santigimeno @edsadr @RafaelGSS