chore(setImmediate): use global.setImmediate instead of timers.setImmediate#1270
Merged
gr2m merged 1 commit intonock:masterfrom Dec 14, 2018
taylor1791:chore/setImmediate
Merged
chore(setImmediate): use global.setImmediate instead of timers.setImmediate#1270gr2m merged 1 commit intonock:masterfrom taylor1791:chore/setImmediate
gr2m merged 1 commit intonock:masterfrom
taylor1791:chore/setImmediate
Conversation
…ediate When unit testing, it is not uncommon to mock the clock. This includes controlling when setImmediate fires. By using global.setImmediate, we adhere to this expectation. This also avoids consumers having to mock the timers module. Resolves #677
Collaborator
|
🎉 This PR is included in version 11.0.0-beta.1 🎉 The release is available on: Your semantic-release bot 📦🚀 |
Collaborator
|
🎉 This PR is included in version 10.0.5 🎉 The release is available on: Your semantic-release bot 📦🚀 |
paulmelnikow
pushed a commit
that referenced
this pull request
Jan 2, 2019
paulmelnikow
pushed a commit
that referenced
this pull request
Jan 3, 2019
|
This thread has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue and add a reference to this one if it’s related. Thank you! |
Collaborator
|
🎉 This PR is included in version 11.0.0 🎉 The release is available on: Your semantic-release bot 📦🚀 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When unit testing, it is not uncommon to mock the clock. This includes controlling when setImmediate fires. By using global.setImmediate, we adhere to this expectation. This also avoids consumers having to mock the timers module.
Resolves #677