Skip to content

Mixed usage of setTimeout and timers.setTimeout #677

@taylor1791

Description

@taylor1791

nock/lib/request_overrider.js uses both setTimeout and timers.setTimeout. Should the project use one or the other for the sake of consistency?

Using setTimeout is nice because if a someone is mocking the clock, then nock will use a mocked clock as well. They can still do it, but have to do additional work to mock timers.

Metadata

Metadata

Assignees

No one assigned

    Type

    No type

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions