I want to see Travis fail on the above commit before I push the implementation. I did see the added test failing locally on my laptop, but not in the other PR. I suspect it's due to how travis has been configured for this project.

This test has failed twice in a row on this branch:

./tests/test_intercept.js ......................... 529/531
  delay works with replyWithError
  not ok this is an error message
    stack: >
      end (lib/request_overrider.js:28:785)
    
      lib/request_overrider.js:13:2146
    
      OverriddenClientRequest.RequestOverrider.req.write
      (lib/request_overrider.js:13:1355)
    
      OverriddenClientRequest.RequestOverrider.req.end
      (lib/request_overrider.js:13:1924)
    
      Object.module.get (lib/common.js:41:287)
    
      Test.<anonymous> (tests/test_intercept.js:4008:20)
    at:
      line: 28
      column: 785
      file: lib/request_overrider.js
      function: end
    test: delay works with replyWithError
    source: |
      function setHeader(request, name, value) {

Any idea what could be causing that? I don't think it's related to this change. I don't believe the tests are running concurrently.

Passing now 🤔

🎉 This PR is included in version 11.0.0-beta.3 🎉

The release is available on:

• npm package (@beta dist-tag)
• GitHub release

Your semantic-release bot 📦🚀

This thread has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue and add a reference to this one if it’s related. Thank you!

🎉 This PR is included in version 11.0.0 🎉

The release is available on:

• npm package (@next dist-tag)
• GitHub release

Your semantic-release bot 📦🚀