Changes to adapt mod files for MOD to CPP translation#11
Conversation
* Remove random123 APIs as they are now included via headers * Avoid passing void* * Avoid assignement of void* See neuronsimulator/nrn#1597
olupton
left a comment
There was a problem hiding this comment.
Generally looks good, all my comments are basically the same.
nullptr is not going to work with the current master of NEURON.
I tend to think we will make our lives easier if we initially make these external models/tests dual C/C++ compatible, but I am open to other options.
In this case it's trivial do doesn't hurt. Done. (But in near future we might need bite the bulltet) |
|
Before we merge this we should test the |
Will create PR where we can gather these updated masters. |
- [x] Update nrntest : @olupton: neuronsimulator/nrntest#26 is merged. - [x] Update tqperf : @pramodk : neuronsimulator/tqperf#11 - [x] Update reduced_dentate: @pramodk : neuronsimulator/reduced_dentate#5 - [ ] olfactory-bulb-3d: @iomaganaris - [ ] testcorenrn: @alkino - [ ] channel-benchmark: @jorblancoa All CI here in master should pass to make sure model changes are backward compatible with MOD to C translation.
* channel-benchmark!9 * HumanBrainProject/olfactory-bulb-3d#19, actually this PR merged into 2to3 branch. * neuronsimulator/nrntest#26 * neuronsimulator/reduced_dentate#5 * neuronsimulator/testcorenrn#10 * neuronsimulator/tqperf#11 * BlueBrain/CoreNeuron#792 * BlueBrain/CoreNeuron#793 The new versions should still support being translated to C code by NEURON versions with #1755, but should additionally support being translated to C++ code: see #1597. Co-authored-by: Olli Lupton <oliver.lupton@epfl.ch> Co-authored-by: Ioannis Magkanaris <iomagkanaris@gmail.com> Co-authored-by: Jorge Blanco Alonso <jorge.blancoalonso@epfl.ch>
See neuronsimulator/nrn#1597