Changes to adapt mod files for MOD to CPP translation#5
Merged
Conversation
* Remove random123 APIs as they are now included via headers * fix vec_* api usage * Avoid passing void* See neuronsimulator/nrn#1597
6 tasks
nrnhines
approved these changes
Mar 29, 2022
nrnhines
left a comment
Member
There was a problem hiding this comment.
I think it is ok to do this without regard to legacy NEURON versions since we are maintaining it with regard to performance. The old versions are available in this repository.
7 tasks
olupton
reviewed
Mar 29, 2022
pramodk
commented
Mar 29, 2022
olupton
reviewed
Mar 31, 2022
olupton
pushed a commit
to neuronsimulator/nrn
that referenced
this pull request
Mar 31, 2022
- [x] Update nrntest : @olupton: neuronsimulator/nrntest#26 is merged. - [x] Update tqperf : @pramodk : neuronsimulator/tqperf#11 - [x] Update reduced_dentate: @pramodk : neuronsimulator/reduced_dentate#5 - [ ] olfactory-bulb-3d: @iomaganaris - [ ] testcorenrn: @alkino - [ ] channel-benchmark: @jorblancoa All CI here in master should pass to make sure model changes are backward compatible with MOD to C translation.
olupton
approved these changes
Apr 1, 2022
olupton
added a commit
to neuronsimulator/nrn
that referenced
this pull request
Apr 1, 2022
* channel-benchmark!9 * HumanBrainProject/olfactory-bulb-3d#19, actually this PR merged into 2to3 branch. * neuronsimulator/nrntest#26 * neuronsimulator/reduced_dentate#5 * neuronsimulator/testcorenrn#10 * neuronsimulator/tqperf#11 * BlueBrain/CoreNeuron#792 * BlueBrain/CoreNeuron#793 The new versions should still support being translated to C code by NEURON versions with #1755, but should additionally support being translated to C++ code: see #1597. Co-authored-by: Olli Lupton <oliver.lupton@epfl.ch> Co-authored-by: Ioannis Magkanaris <iomagkanaris@gmail.com> Co-authored-by: Jorge Blanco Alonso <jorge.blancoalonso@epfl.ch>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
See neuronsimulator/nrn#1597