This repository was archived by the owner on Mar 20, 2023. It is now read-only.
vector_new1: make return type match NEURON.#793
Merged
Conversation
pramodk
approved these changes
Mar 31, 2022
Collaborator
olupton
added a commit
to neuronsimulator/nrn
that referenced
this pull request
Apr 1, 2022
* channel-benchmark!9 * HumanBrainProject/olfactory-bulb-3d#19, actually this PR merged into 2to3 branch. * neuronsimulator/nrntest#26 * neuronsimulator/reduced_dentate#5 * neuronsimulator/testcorenrn#10 * neuronsimulator/tqperf#11 * BlueBrain/CoreNeuron#792 * BlueBrain/CoreNeuron#793 The new versions should still support being translated to C code by NEURON versions with #1755, but should additionally support being translated to C++ code: see #1597. Co-authored-by: Olli Lupton <oliver.lupton@epfl.ch> Co-authored-by: Ioannis Magkanaris <iomagkanaris@gmail.com> Co-authored-by: Jorge Blanco Alonso <jorge.blancoalonso@epfl.ch>
pramodk
pushed a commit
to neuronsimulator/nrn
that referenced
this pull request
Nov 2, 2022
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
In NEURON the return type is
IvocVect*:https://github.com/neuronsimulator/nrn/blob/331e75096ea984d2945ba675b44d969470fbfb1b/src/oc/oc_ansi.h#L191
This helps us to prepare for neuronsimulator/nrn#1597.
Use certain branches in CI pipelines.
CI_BRANCHES:NEURON_BRANCH=master,NMODL_BRANCH=master,SPACK_BRANCH=develop