CheckGitDescribeCompatibility.cmake is PEP 440 compliant.#3384
Conversation
|
✔️ 18b87a1 -> Azure artifacts URL |
|
✔️ aa13b42 -> Azure artifacts URL |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #3384 +/- ##
=======================================
Coverage 68.34% 68.34%
=======================================
Files 682 682
Lines 116452 116452
=======================================
Hits 79584 79584
Misses 36868 36868 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
JCGoran
left a comment
There was a problem hiding this comment.
I see there are some regexes being used, I assume they capture whatever the spec says (see https://packaging.python.org/en/latest/specifications/version-specifiers/#appendix-parsing-version-strings-with-regular-expressions). Moreover, if this will get rid of that annoying "fatal: git describe" message, I'm all for it.
I need to add the equivalent cmake function for is_canonical and do some more testing. |
|
For a long time, the previous tag of the master has been 8987974 attempts to handle a tag containing dev with the regex group Presently for this PR, CheckGitDescribeCompatibility.cmake does not raise a FATAL_ERROR. Allowing the common .dev or .a and removing the '.' for the normalization would be easy. And 'dev' with no number could be a special case so that instead of normalizing 9.0.1dev-3-g898797455 to 9.0.1.post3.dev0, it could be normalized to 9.0.1.dev3 |
|
|
✔️ b7c9964 -> Azure artifacts URL |
* wheel build generally uses numpy >= 2 for python >= 3.9 * for wheel and mac pgk distributions, rx3d cython compiled with -O1 * adopt PYTHONPATH feature from master _binwrapper.py * correct nmodl signatures for _getelm and getarg. (windows gcc-15) * Yet a few more nmodl function signatures. * Turn off hoc_association test. * Use platform appropriate separator for PYTHONPATH. * At least Apple arm64 needs last argtype of ctypes._CFuncPtr (#2046) Co-authored-by: Olli Lupton <oliver.lupton@epfl.ch> * CheckGitDescribeCompatibility.cmake is PEP 440 compliant. (#3384) * version macros test computes (major, minor, pat) from pep440 version * An rxd/species.py string should be raw. * See #3407 work around a problem sphinx has with itself. * PEP440 regex too complicated for cmake 3.22.1 . Use Python * Some ModelDB uses M_PI, struct timezone, and u_int32_t * update changelog --------- Co-authored-by: Olli Lupton <oliver.lupton@epfl.ch>
At the moment this does not have much of a substantive use since wheel names are chosen by setup.py call to setuptoosls_scm. However it does validate and normalize user chosen tags and git describe versions. E.g.
The normalized version is in ${PROJECT_VERSION}