At least Apple arm64 needs last argtype of ctypes._CFuncPtr#2046
Merged
Conversation
olupton
approved these changes
Oct 31, 2022
olupton
left a comment
Collaborator
There was a problem hiding this comment.
Looks reasonable to me, but I don't have any Apple/arm64 hardware to run any checks on.
Member
Author
|
I'm using What am I doing wrong? |
Collaborator
I would guess that it's the Line 8 in 0184c48 so it sounds like a bug if it silently accepts/uses a different version... |
This reverts commit 1c81f39.
Codecov Report
@@ Coverage Diff @@
## master #2046 +/- ##
=======================================
Coverage 48.63% 48.63%
=======================================
Files 519 519
Lines 116059 116059
=======================================
Hits 56440 56440
Misses 59619 59619
📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
|
✔️ b7df3ba -> Azure artifacts URL |
|
✔️ 6c13552 -> Azure artifacts URL |
olupton
approved these changes
Nov 1, 2022
ramcdougal
pushed a commit
that referenced
this pull request
May 4, 2025
Co-authored-by: Olli Lupton <oliver.lupton@epfl.ch>
nrnhines
added a commit
that referenced
this pull request
May 20, 2025
* wheel build generally uses numpy >= 2 for python >= 3.9 * for wheel and mac pgk distributions, rx3d cython compiled with -O1 * adopt PYTHONPATH feature from master _binwrapper.py * correct nmodl signatures for _getelm and getarg. (windows gcc-15) * Yet a few more nmodl function signatures. * Turn off hoc_association test. * Use platform appropriate separator for PYTHONPATH. * At least Apple arm64 needs last argtype of ctypes._CFuncPtr (#2046) Co-authored-by: Olli Lupton <oliver.lupton@epfl.ch> * CheckGitDescribeCompatibility.cmake is PEP 440 compliant. (#3384) * version macros test computes (major, minor, pat) from pep440 version * An rxd/species.py string should be raw. * See #3407 work around a problem sphinx has with itself. * PEP440 regex too complicated for cmake 3.22.1 . Use Python * Some ModelDB uses M_PI, struct timezone, and u_int32_t * update changelog --------- Co-authored-by: Olli Lupton <oliver.lupton@epfl.ch>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This fixes
ctest -R rxdmod_tests::rxd_testson my Apple M1The symptom before this is that the called function received a NULL function pointer arg.