Skip to content

More fixes for 8.2.7#3397

Merged
nrnhines merged 17 commits into
release/8.2from
hines/827-fixes
May 20, 2025
Merged

More fixes for 8.2.7#3397
nrnhines merged 17 commits into
release/8.2from
hines/827-fixes

Conversation

@nrnhines

@nrnhines nrnhines commented May 1, 2025 •
edited
Loading

Copy link
Copy Markdown
Member

Adopting master version of _binwrapper.py fixes a nrnpyenv.sh issue where a launch of nrniv in the context of being installed (pip install neuron) with python being a virtual environment, does not have sufficient sys.path to successfully import neuron. Note that importlib.metatdata is not available in python3.7 and we are now making wheels only for python 3.9 and above. It would be possible to fallback to from pkg_resources import working_set if anyone thinks it is worth it.

@codecov

codecov Bot commented May 1, 2025 •
edited
Loading

Copy link
Copy Markdown

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 46.58%. Comparing base (a8cd8f5) to head (b00a1b3).
Report is 17 commits behind head on release/8.2.

❗ Current head b00a1b3 differs from pull request most recent head 303569e

Please upload reports for the commit 303569e to get more accurate results.

Additional details and impacted files 
@@             Coverage Diff              @@
##           release/8.2    #3397   +/-   ##
============================================
  Coverage        46.58%   46.58%           
============================================
  Files              527      527           
  Lines           119282   119300   +18     
============================================
+ Hits             55565    55579   +14     
- Misses           63717    63721    +4

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@azure-pipelines

azure-pipelines Bot commented May 1, 2025

Copy link
Copy Markdown

✔️ e0578f6 -> Azure artifacts URL

@nrnhines nrnhines requested review from JCGoran and ramcdougal May 1, 2025 12:46
@azure-pipelines

azure-pipelines Bot commented May 1, 2025

Copy link
Copy Markdown

✔️ d2161a9 -> Azure artifacts URL

@nrnhines nrnhines force-pushed the hines/827-fixes branch from d2161a9 to f851ab3 Compare May 1, 2025 16:09
@nrnhines nrnhines force-pushed the hines/827-fixes branch from f851ab3 to e560702 Compare May 1, 2025 17:54
@azure-pipelines

azure-pipelines Bot commented May 2, 2025

Copy link
Copy Markdown

✔️ c7dba13 -> Azure artifacts URL

@ramcdougal

ramcdougal commented May 2, 2025

Copy link
Copy Markdown
Member

Anything less than 3.9 is past EOL, so I think that's okay.

ramcdougal
ramcdougal reviewed May 2, 2025
View reviewed changes
Comment thread share/lib/python/scripts/_binwrapper.py Outdated
@azure-pipelines

azure-pipelines Bot commented May 3, 2025

Copy link
Copy Markdown

✔️ b00a1b3 -> Azure artifacts URL

@nrnhines @olupton @ramcdougal
At least Apple arm64 needs last argtype of ctypes._CFuncPtr (#2046)
6dfa825 
Co-authored-by: Olli Lupton <oliver.lupton@epfl.ch>
@azure-pipelines

azure-pipelines Bot commented May 4, 2025

Copy link
Copy Markdown

✔️ 6dfa825 -> Azure artifacts URL

@azure-pipelines

azure-pipelines Bot commented May 8, 2025

Copy link
Copy Markdown

✔️ a4a0159 -> Azure artifacts URL

@azure-pipelines

azure-pipelines Bot commented May 9, 2025

Copy link
Copy Markdown

✔️ a8aef66 -> Azure artifacts URL

@azure-pipelines

azure-pipelines Bot commented May 9, 2025

Copy link
Copy Markdown

✔️ cd4f14f -> Azure artifacts URL

@nrnhines nrnhines force-pushed the hines/827-fixes branch from cd4f14f to 4ecdab0 Compare May 9, 2025 14:46
@azure-pipelines

azure-pipelines Bot commented May 9, 2025

Copy link
Copy Markdown

✔️ 4ecdab0 -> Azure artifacts URL

@azure-pipelines

azure-pipelines Bot commented May 10, 2025

Copy link
Copy Markdown

✔️ cc41aac -> Azure artifacts URL

@sonarqubecloud

sonarqubecloud Bot commented May 14, 2025

Copy link
Copy Markdown

Quality Gate Passed Quality Gate passed

Issues
4 New issues
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarQube Cloud

@azure-pipelines

azure-pipelines Bot commented May 14, 2025

Copy link
Copy Markdown

✔️ 303569e -> Azure artifacts URL

@nrnhines nrnhines merged commit e25d968 into release/8.2 May 20, 2025
@nrnhines nrnhines deleted the hines/827-fixes branch May 20, 2025 18:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@ramcdougal ramcdougal ramcdougal approved these changes
@JCGoran JCGoran Awaiting requested review from JCGoran

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@nrnhines @ramcdougal