Pin bokeh<3, don't pin matplotlib#2048
Merged
Merged
Conversation
pramodk
approved these changes
Nov 1, 2022
nrnhines
approved these changes
Nov 1, 2022
Member
There was a problem hiding this comment.
I'm glad you diagnosed and fixed this. Clearly #2046 needs it. I've been unable to get ninja docs to work on my Apple M1 with a last of many errors being (don't let it affect this PR):
File /Library/Frameworks/Python.framework/Versions/3.8/lib/python3.8/urllib/request.py:1357, in AbstractHTTPHandler.do_open(self, http_class, req, **http_conn_args)
1354 h.request(req.get_method(), req.selector, req.data, headers,
1355 encode_chunked=req.has_header('Transfer-encoding'))
1356 except OSError as err: # timeout error
-> 1357 raise URLError(err)
1358 r = h.getresponse()
1359 except:
URLError: <urlopen error [SSL: CERTIFICATE_VERIFY_FAILED] certificate verify failed: unable to get local issuer certificate (_ssl.c:1131)>
Edit: Seems the certificate issues were resolved by running /Applications/Python3.8/Install Certificates.command. But now I'm seeing
Thread 0 Crashed:: Dispatch queue: com.apple.main-thread
0 ??? 0x0 ???
1 libnrnpython3.dylib 0x10587080c run_threaded_reactions(ReactGridData*) + 144 (rxd_extracellular.cpp:582)
So this machine apparently needs #2046 for ninja docs success.
Edit 2: Yep. After git merge hines/rxd-funcptr-fix, ninja docs succeeds on my machine.
|
✔️ 8ff20e4 -> Azure artifacts URL |
iomaganaris
pushed a commit
that referenced
this pull request
Nov 9, 2022
* Add list(...) for new matplotlib.
nrnhines
added a commit
that referenced
this pull request
Nov 9, 2022
* refactoring: drop java code (#1937) * Update removed_features.rst * Fine tune clang-format and fix CI (#2041) * Delete return statement to avoid ASan error. * CVode.poolshrink(1) deletes unused mechanism pools. (#2033) * Pin bokeh<3, don't pin matplotlib (#2048) * Add list(...) for new matplotlib. Co-authored-by: Alexandru Săvulescu <alexandru.savulescu@epfl.ch> Co-authored-by: Olli Lupton <oliver.lupton@epfl.ch> Co-authored-by: nrnhines <michael.hines@yale.edu>
alexsavulescu
added a commit
that referenced
this pull request
Dec 15, 2022
* refactoring: drop java code (#1937) * Update removed_features.rst * Fine tune clang-format and fix CI (#2041) * Delete return statement to avoid ASan error. * CVode.poolshrink(1) deletes unused mechanism pools. (#2033) * Pin bokeh<3, don't pin matplotlib (#2048) * Add list(...) for new matplotlib. Co-authored-by: Alexandru Săvulescu <alexandru.savulescu@epfl.ch> Co-authored-by: Olli Lupton <oliver.lupton@epfl.ch> Co-authored-by: nrnhines <michael.hines@yale.edu>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.