refactoring: drop java code#1937
Merged
Merged
Conversation
|
✔️ b885c56 -> Azure artifacts URL |
Codecov Report
@@ Coverage Diff @@
## master #1937 +/- ##
==========================================
+ Coverage 47.19% 47.33% +0.13%
==========================================
Files 543 543
Lines 112939 112603 -336
==========================================
- Hits 53307 53306 -1
+ Misses 59632 59297 -335
📣 Codecov can now indicate which changes are the most critical in Pull Requests. Learn more |
nrnhines
approved these changes
Jul 31, 2022
Member
There was a problem hiding this comment.
I don't see any reason not to approve. It will remain in the attic. This isn't the last candidate for removal in the same way. The last substantive change was
commit 324b821a0a8dfef1da8d56748d6ae043e329eb0b
Author: Michael Hines <michael.hines@yale.edu>
Date: Thu Oct 22 11:07:01 2015 -0400
Resurrect Java support for linux and mac using configure option --with-nrnjava
Note that LD_LIBRARY_PATH will likely be necessary to find libjvm and
that path can be determined by searching for -ljvm in config.log
and I never implemented configuration with cmake.
There is some mention of the "Java catacomb channel builder tool" in docs/hoc/modelspec/programmatic/kschan.rst of which KSChan is a slight generalization. But I don't think it is worth the bother of editing.
Member
Looks like 336 executable lines were removed (and no files). I guess some old code was surrounded by |
|
✔️ 5ef0db8 -> Azure artifacts URL |
iomaganaris
pushed a commit
that referenced
this pull request
Nov 9, 2022
* refactoring: drop java code * Update removed_features.rst
nrnhines
added a commit
that referenced
this pull request
Nov 9, 2022
* refactoring: drop java code (#1937) * Update removed_features.rst * Fine tune clang-format and fix CI (#2041) * Delete return statement to avoid ASan error. * CVode.poolshrink(1) deletes unused mechanism pools. (#2033) * Pin bokeh<3, don't pin matplotlib (#2048) * Add list(...) for new matplotlib. Co-authored-by: Alexandru Săvulescu <alexandru.savulescu@epfl.ch> Co-authored-by: Olli Lupton <oliver.lupton@epfl.ch> Co-authored-by: nrnhines <michael.hines@yale.edu>
alexsavulescu
added a commit
that referenced
this pull request
Dec 15, 2022
* refactoring: drop java code (#1937) * Update removed_features.rst * Fine tune clang-format and fix CI (#2041) * Delete return statement to avoid ASan error. * CVode.poolshrink(1) deletes unused mechanism pools. (#2033) * Pin bokeh<3, don't pin matplotlib (#2048) * Add list(...) for new matplotlib. Co-authored-by: Alexandru Săvulescu <alexandru.savulescu@epfl.ch> Co-authored-by: Olli Lupton <oliver.lupton@epfl.ch> Co-authored-by: nrnhines <michael.hines@yale.edu>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is more of a question, shall we drop java support? Also curious about coverage.