Introduce MacOSDnsServerAddressStreamProvider which correctly detect … by normanmaurer · Pull Request #9161 · netty/netty

normanmaurer · 2019-05-20T08:53:48Z

…all nameserver configuration on MacOS

Motivation:

On MacOS it is not really good enough to check /etc/resolv.conf to determine the nameservers to use. We should retrieve the nameservers using the same way as mDNSResponser and chromium does by doing a JNI call.

Modifications:

Add MacOSDnsServerAddressStreamProvider and testcase

Result:

Use correct nameservers by default on MacOS.

normanmaurer · 2019-05-20T14:20:23Z

@netty-bot test this please

normanmaurer · 2019-05-20T17:55:54Z

pom.xml

        <version>0.13.1</version>
        <configuration>
          <parameter>
+            <ignoreMissingOldVersion>true</ignoreMissingOldVersion>


this was added as otherwise it would fail as there can be no previous version found of resolver-dns-native-macos.

normanmaurer · 2019-06-27T13:10:34Z

I will merge this one after the next release is out.

normanmaurer · 2019-08-16T11:00:01Z

@netty-bot test this please

normanmaurer · 2019-08-16T13:04:07Z

@netty-bot test this please

…all nameserver configuration on MacOS Motivation: On MacOS it is not really good enough to check /etc/resolv.conf to determine the nameservers to use. We should retrieve the nameservers using the same way as mDNSResponser and chromium does by doing a JNI call. Modifications: Add MacOSDnsServerAddressStreamProvider and testcase Result: Use correct nameservers by default on MacOS.

…all nameserver configuration on MacOS (#9161) Motivation: On MacOS it is not really good enough to check /etc/resolv.conf to determine the nameservers to use. We should retrieve the nameservers using the same way as mDNSResponser and chromium does by doing a JNI call. Modifications: Add MacOSDnsServerAddressStreamProvider and testcase Result: Use correct nameservers by default on MacOS.

anuraaga · 2019-11-22T07:47:09Z

Hi @normanmaurer I happened to find this while looking into netty-dns resolution issues on Windows.

line/armeria#2243

Do you think we may need to use a similar JNI approach on Windows too? https://github.com/chromium/chromium/blob/master/net/dns/dns_config_service_win.cc#L498

normanmaurer · 2019-11-22T07:50:51Z

@anuraaga good question... unfortunately I am not very into windows at all, so its hard for me to judge :/

anuraaga · 2019-11-22T08:17:49Z

@normanmaurer Yeah me too ;) Luckily the stream is pluggable so will experiment with some approaches and see if I find any need for something different.

anuraaga · 2019-11-22T09:49:49Z

@normanmaurer Did a deep investigation and we might want a native implementation for Windows too. Java has inherited from the old days a legacy way pre-Windows XP of enumerating DNS server addresses - list all the adapters and query registry for their DNS config

https://github.com/AdoptOpenJDK/openjdk-jdk11/blob/master/src/java.base/windows/native/libnet/ResolverConfigurationImpl.c#L129

Now adays, it's much better to use GetAdapterAddresses, which by default only returns information about bound adapters

https://github.com/chromium/chromium/blob/master/net/dns/dns_config_service_win.cc#L498

https://docs.microsoft.com/en-us/windows/win32/api/iphlpapi/nf-iphlpapi-getadaptersaddresses
https://docs.microsoft.com/en-us/windows/win32/api/iphlpapi/nf-iphlpapi-getadaptersinfo

I very much don't want to learn how to use WIndows SDK for this sort of development ;) But can give it a stab if you're open to adding a windows native DNS module. What do you think?

anuraaga · 2019-11-22T10:05:25Z

Sorry for spamming this PR - went ahead and created an issue for more discussion #9796

…` license ### What changes were proposed in this pull request? This PR aims to update `NOTICE-binary` with `Netty` 4.2.7 license. - https://github.com/netty/netty/blob/netty-4.2.7.Final/NOTICE.txt ### Why are the changes needed? It seems that we updated `Netty Notice` at Apache Spark `3.0.0-preview` with `Netty 4.1.30.Final`. - #25544 Since there are many changes like the following, we need to update it by simply copying and pasting. - Netty 4.1.38.Final - netty/netty#9344 - Netty 4.1.44.Final - netty/netty#9161 - Netty 4.1.54.Final - netty/netty#10773 - Netty 4.1.66.Final - netty/netty#11256 - netty/netty#11437 - Netty 4.1.108.Final - netty/netty#13864 - Netty 4.2.1.Final - netty/netty#14979 - Netty 4.2.7.Final - netty/netty#15658 Additionally, I also double-checked newly added transitive license through ASF [LEGAL-700](https://issues.apache.org/jira/browse/LEGAL-700). We are good to go. - **Apple Public Source License 2.0** - https://spdx.org/licenses/APSL-2.0.html ### Does this PR introduce _any_ user-facing change? No behavior change. ### How was this patch tested? Manual review. ### Was this patch authored or co-authored using generative AI tooling? No. Closes #53335 from dongjoon-hyun/SPARK-54602. Authored-by: Dongjoon Hyun <dongjoon@apache.org> Signed-off-by: Dongjoon Hyun <dongjoon@apache.org>

…` license ### What changes were proposed in this pull request? This PR aims to update `NOTICE-binary` with `Netty` 4.2.7 license. - https://github.com/netty/netty/blob/netty-4.2.7.Final/NOTICE.txt ### Why are the changes needed? It seems that we updated `Netty Notice` at Apache Spark `3.0.0-preview` with `Netty 4.1.30.Final`. - #25544 Since there are many changes like the following, we need to update it by simply copying and pasting. - Netty 4.1.38.Final - netty/netty#9344 - Netty 4.1.44.Final - netty/netty#9161 - Netty 4.1.54.Final - netty/netty#10773 - Netty 4.1.66.Final - netty/netty#11256 - netty/netty#11437 - Netty 4.1.108.Final - netty/netty#13864 - Netty 4.2.1.Final - netty/netty#14979 - Netty 4.2.7.Final - netty/netty#15658 Additionally, I also double-checked newly added transitive license through ASF [LEGAL-700](https://issues.apache.org/jira/browse/LEGAL-700). We are good to go. - **Apple Public Source License 2.0** - https://spdx.org/licenses/APSL-2.0.html ### Does this PR introduce _any_ user-facing change? No behavior change. ### How was this patch tested? Manual review. ### Was this patch authored or co-authored using generative AI tooling? No. Closes #53335 from dongjoon-hyun/SPARK-54602. Authored-by: Dongjoon Hyun <dongjoon@apache.org> Signed-off-by: Dongjoon Hyun <dongjoon@apache.org> (cherry picked from commit 191ce4c) Signed-off-by: Dongjoon Hyun <dongjoon@apache.org>

normanmaurer mentioned this pull request May 20, 2019

Introduce MacOSDnsServerAddressStreamProvider which uses scutil --dns… #9142

Closed

normanmaurer force-pushed the resolver_macos branch from a441c9c to 9bd8566 Compare May 20, 2019 08:56

normanmaurer added this to the 4.1.37.Final milestone May 20, 2019

normanmaurer requested review from Scottmitch, ejona86 and trustin May 20, 2019 08:59

normanmaurer force-pushed the resolver_macos branch 3 times, most recently from f2f7732 to 81c6058 Compare May 20, 2019 13:27

normanmaurer commented May 20, 2019

View reviewed changes

normanmaurer force-pushed the resolver_macos branch from 81c6058 to 2fbe6fe Compare May 22, 2019 09:35

normanmaurer force-pushed the resolver_macos branch from 2fbe6fe to 334dabd Compare June 27, 2019 13:29

normanmaurer modified the milestones: 4.1.37.Final, 4.1.38.Final Jun 28, 2019

normanmaurer modified the milestones: 4.1.38.Final, 4.1.39.Final Jul 24, 2019

normanmaurer modified the milestones: 4.1.39.Final, 4.1.40.Final Aug 13, 2019

normanmaurer force-pushed the resolver_macos branch from 334dabd to 0a77e8d Compare August 16, 2019 12:00

normanmaurer modified the milestones: 4.1.40.Final, 4.1.41.Final, 4.1.42.Final Sep 11, 2019

normanmaurer force-pushed the resolver_macos branch from 0a77e8d to e501a01 Compare September 23, 2019 14:10

normanmaurer removed this from the 4.1.42.Final milestone Sep 25, 2019

normanmaurer added this to the 4.1.43.Final milestone Sep 25, 2019

normanmaurer modified the milestones: 4.1.43.Final, 4.1.44.Final Oct 24, 2019

normanmaurer merged commit 939e928 into 4.1 Oct 28, 2019

normanmaurer deleted the resolver_macos branch October 28, 2019 14:02

This was referenced Nov 22, 2019

Domain name resolution failure in Windows line/armeria#2243

Open

DNS Servers on Windows include unreachable servers #9796

Closed

dongjoon-hyun mentioned this pull request Dec 5, 2025

[SPARK-54602][BUILD] Update NOTICE-binary with Netty 4.2.7.Final license apache/spark#53335

Closed

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

Introduce MacOSDnsServerAddressStreamProvider which correctly detect …#9161

Introduce MacOSDnsServerAddressStreamProvider which correctly detect …#9161
normanmaurer merged 1 commit into4.1from
resolver_macos

normanmaurer commented May 20, 2019

Uh oh!

normanmaurer commented May 20, 2019

Uh oh!

normanmaurer May 20, 2019

Uh oh!

normanmaurer commented Jun 27, 2019

Uh oh!

normanmaurer commented Aug 16, 2019

Uh oh!

normanmaurer commented Aug 16, 2019

Uh oh!

anuraaga commented Nov 22, 2019

Uh oh!

normanmaurer commented Nov 22, 2019

Uh oh!

anuraaga commented Nov 22, 2019

Uh oh!

anuraaga commented Nov 22, 2019

Uh oh!

anuraaga commented Nov 22, 2019

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants

Uh oh!

Conversation

normanmaurer commented May 20, 2019

Uh oh!

normanmaurer commented May 20, 2019

Uh oh!

normanmaurer May 20, 2019

Choose a reason for hiding this comment

Uh oh!

normanmaurer commented Jun 27, 2019

Uh oh!

normanmaurer commented Aug 16, 2019

Uh oh!

normanmaurer commented Aug 16, 2019

Uh oh!

anuraaga commented Nov 22, 2019

Uh oh!

normanmaurer commented Nov 22, 2019

Uh oh!

anuraaga commented Nov 22, 2019

Uh oh!

anuraaga commented Nov 22, 2019

Uh oh!

anuraaga commented Nov 22, 2019

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants