Merged
Conversation
Contributor
|
Please squash all commits into one. |
normanmaurer
requested changes
Jul 1, 2021
codec/src/main/java/io/netty/handler/codec/compression/ZstdEncoder.java
Outdated
Show resolved
Hide resolved
codec/src/main/java/io/netty/handler/codec/compression/ZstdEncoder.java
Outdated
Show resolved
Hide resolved
codec/src/main/java/io/netty/handler/codec/compression/ZstdEncoder.java
Outdated
Show resolved
Hide resolved
codec/src/main/java/io/netty/handler/codec/compression/ZstdEncoder.java
Outdated
Show resolved
Hide resolved
codec/src/main/java/io/netty/handler/codec/compression/ZstdEncoder.java
Outdated
Show resolved
Hide resolved
codec/src/main/java/io/netty/handler/codec/compression/ZstdEncoder.java
Outdated
Show resolved
Hide resolved
codec/src/test/java/io/netty/handler/codec/compression/ZstdEncoderTest.java
Outdated
Show resolved
Hide resolved
codec/src/main/java/io/netty/handler/codec/compression/ZstdEncoder.java
Outdated
Show resolved
Hide resolved
Contributor
Author
|
@idelpivnitskiy PTAL if you have some time, thanks |
normanmaurer
requested changes
Jul 2, 2021
codec/src/main/java/io/netty/handler/codec/compression/ZstdEncoder.java
Outdated
Show resolved
Hide resolved
codec/src/test/java/io/netty/handler/codec/compression/ZstdEncoderTest.java
Outdated
Show resolved
Hide resolved
codec/src/test/java/io/netty/handler/codec/compression/ZstdEncoderTest.java
Outdated
Show resolved
Hide resolved
codec/src/test/java/io/netty/handler/codec/compression/ZstdEncoderTest.java
Outdated
Show resolved
Hide resolved
codec/src/test/java/io/netty/handler/codec/compression/ZstdEncoderTest.java
Outdated
Show resolved
Hide resolved
codec/src/test/java/io/netty/handler/codec/compression/ZstdEncoderTest.java
Outdated
Show resolved
Hide resolved
Contributor
Author
|
@normanmaurer Thanks |
Member
|
@skyguard1 can you please rebase |
Signed-off-by: xingrufei <xingrufei@sogou-inc.com>
fe1d4a6 to
97e0c95
Compare
Contributor
Author
|
@normanmaurer, I've done it |
Signed-off-by: xingrufei <xingrufei@sogou-inc.com>
Contributor
Author
|
@chrisvest PTAL |
normanmaurer
requested changes
Jul 5, 2021
codec/src/test/java/io/netty/handler/codec/compression/ZstdEncoderTest.java
Show resolved
Hide resolved
Signed-off-by: xingrufei <xingrufei@sogou-inc.com>
Signed-off-by: xingrufei <xingrufei@sogou-inc.com>
normanmaurer
approved these changes
Jul 6, 2021
Member
|
I think we can pull this in |
Member
|
@skyguard1 thanks a lot! |
normanmaurer
pushed a commit
that referenced
this pull request
Jul 6, 2021
Motivation: As discussed in #10422, ZstdEncoder can be added separately Modification: Add ZstdEncoder separately Result: netty supports ZSTD with ZstdEncoder Signed-off-by: xingrufei <xingrufei@sogou-inc.com> Co-authored-by: xingrufei <xingrufei@sogou-inc.com>
Contributor
Author
|
@normanmaurer It is my pleasure |
raidyue
pushed a commit
to raidyue/netty
that referenced
this pull request
Jul 8, 2022
Motivation: As discussed in netty#10422, ZstdEncoder can be added separately Modification: Add ZstdEncoder separately Result: netty supports ZSTD with ZstdEncoder Signed-off-by: xingrufei <xingrufei@sogou-inc.com> Co-authored-by: xingrufei <xingrufei@sogou-inc.com>
dongjoon-hyun
added a commit
to apache/spark
that referenced
this pull request
Dec 5, 2025
…` license ### What changes were proposed in this pull request? This PR aims to update `NOTICE-binary` with `Netty` 4.2.7 license. - https://github.com/netty/netty/blob/netty-4.2.7.Final/NOTICE.txt ### Why are the changes needed? It seems that we updated `Netty Notice` at Apache Spark `3.0.0-preview` with `Netty 4.1.30.Final`. - #25544 Since there are many changes like the following, we need to update it by simply copying and pasting. - Netty 4.1.38.Final - netty/netty#9344 - Netty 4.1.44.Final - netty/netty#9161 - Netty 4.1.54.Final - netty/netty#10773 - Netty 4.1.66.Final - netty/netty#11256 - netty/netty#11437 - Netty 4.1.108.Final - netty/netty#13864 - Netty 4.2.1.Final - netty/netty#14979 - Netty 4.2.7.Final - netty/netty#15658 Additionally, I also double-checked newly added transitive license through ASF [LEGAL-700](https://issues.apache.org/jira/browse/LEGAL-700). We are good to go. - **Apple Public Source License 2.0** - https://spdx.org/licenses/APSL-2.0.html ### Does this PR introduce _any_ user-facing change? No behavior change. ### How was this patch tested? Manual review. ### Was this patch authored or co-authored using generative AI tooling? No. Closes #53335 from dongjoon-hyun/SPARK-54602. Authored-by: Dongjoon Hyun <dongjoon@apache.org> Signed-off-by: Dongjoon Hyun <dongjoon@apache.org>
dongjoon-hyun
added a commit
to apache/spark
that referenced
this pull request
Dec 5, 2025
…` license ### What changes were proposed in this pull request? This PR aims to update `NOTICE-binary` with `Netty` 4.2.7 license. - https://github.com/netty/netty/blob/netty-4.2.7.Final/NOTICE.txt ### Why are the changes needed? It seems that we updated `Netty Notice` at Apache Spark `3.0.0-preview` with `Netty 4.1.30.Final`. - #25544 Since there are many changes like the following, we need to update it by simply copying and pasting. - Netty 4.1.38.Final - netty/netty#9344 - Netty 4.1.44.Final - netty/netty#9161 - Netty 4.1.54.Final - netty/netty#10773 - Netty 4.1.66.Final - netty/netty#11256 - netty/netty#11437 - Netty 4.1.108.Final - netty/netty#13864 - Netty 4.2.1.Final - netty/netty#14979 - Netty 4.2.7.Final - netty/netty#15658 Additionally, I also double-checked newly added transitive license through ASF [LEGAL-700](https://issues.apache.org/jira/browse/LEGAL-700). We are good to go. - **Apple Public Source License 2.0** - https://spdx.org/licenses/APSL-2.0.html ### Does this PR introduce _any_ user-facing change? No behavior change. ### How was this patch tested? Manual review. ### Was this patch authored or co-authored using generative AI tooling? No. Closes #53335 from dongjoon-hyun/SPARK-54602. Authored-by: Dongjoon Hyun <dongjoon@apache.org> Signed-off-by: Dongjoon Hyun <dongjoon@apache.org> (cherry picked from commit 191ce4c) Signed-off-by: Dongjoon Hyun <dongjoon@apache.org>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Motivation:
As discussed in #10422, ZstdEncoder can be added separately
Modification:
Add ZstdEncoder separately
Result:
netty supports ZSTD with ZstdEncoder