[SPARK-54602][BUILD] Update NOTICE-binary with Netty 4.2.7.Final license#53335
Closed
dongjoon-hyun wants to merge 1 commit intoapache:masterfrom
Closed
[SPARK-54602][BUILD] Update NOTICE-binary with Netty 4.2.7.Final license#53335dongjoon-hyun wants to merge 1 commit intoapache:masterfrom
NOTICE-binary with Netty 4.2.7.Final license#53335dongjoon-hyun wants to merge 1 commit intoapache:masterfrom
Conversation
NOTICE-binary with Netty 4.2.7 licenseNOTICE-binary with Netty 4.2.7.Final license
dongjoon-hyun
commented
Dec 5, 2025
| Please visit the Netty web site for more information: | ||
|
|
||
| * http://netty.io/ | ||
| * https://netty.io/ |
Member
Author
There was a problem hiding this comment.
This is changed at Netty 4.1.38.Final
dongjoon-hyun
commented
Dec 5, 2025
| * license/LICENSE.lz4.txt (Apache License 2.0) | ||
| * HOMEPAGE: | ||
| * https://github.com/yawkat/lz4-java | ||
| * https://github.com/jpountz/lz4-java |
Member
Author
There was a problem hiding this comment.
Hi, @LuciferYang . I recovered this becauseI realized that this is a part of Netty's NOTICE file instead of ours.
https://github.com/netty/netty/blob/511cbacea64c3348078948e8cb424749afeaeefc/NOTICE.txt#L118
Member
Author
|
If you have a chance, please review this, @yaooqinn . |
dongjoon-hyun
commented
Dec 5, 2025
| mDNSResponder (https://opensource.apple.com/tarballs/mDNSResponder/). | ||
|
|
||
| * LICENSE: | ||
| * license/LICENSE.dnsinfo.txt (Apple Public Source License 2.0) |
Member
Author
There was a problem hiding this comment.
Apple Public Source License 2.0 is the following.
Member
Author
There was a problem hiding this comment.
Member
Author
There was a problem hiding this comment.
Since Netty only uses its header file, dnsinfo.h, ASF decided to consider it's okay here, LEGAL-700.
Member
Author
|
FYI, @peter-toth . |
LuciferYang
approved these changes
Dec 5, 2025
Contributor
LuciferYang
left a comment
There was a problem hiding this comment.
+1, LGTM
Thank you @dongjoon-hyun
Member
Author
|
Thank you, @LuciferYang . Merged to master/4.1. |
dongjoon-hyun
added a commit
that referenced
this pull request
Dec 5, 2025
…` license ### What changes were proposed in this pull request? This PR aims to update `NOTICE-binary` with `Netty` 4.2.7 license. - https://github.com/netty/netty/blob/netty-4.2.7.Final/NOTICE.txt ### Why are the changes needed? It seems that we updated `Netty Notice` at Apache Spark `3.0.0-preview` with `Netty 4.1.30.Final`. - #25544 Since there are many changes like the following, we need to update it by simply copying and pasting. - Netty 4.1.38.Final - netty/netty#9344 - Netty 4.1.44.Final - netty/netty#9161 - Netty 4.1.54.Final - netty/netty#10773 - Netty 4.1.66.Final - netty/netty#11256 - netty/netty#11437 - Netty 4.1.108.Final - netty/netty#13864 - Netty 4.2.1.Final - netty/netty#14979 - Netty 4.2.7.Final - netty/netty#15658 Additionally, I also double-checked newly added transitive license through ASF [LEGAL-700](https://issues.apache.org/jira/browse/LEGAL-700). We are good to go. - **Apple Public Source License 2.0** - https://spdx.org/licenses/APSL-2.0.html ### Does this PR introduce _any_ user-facing change? No behavior change. ### How was this patch tested? Manual review. ### Was this patch authored or co-authored using generative AI tooling? No. Closes #53335 from dongjoon-hyun/SPARK-54602. Authored-by: Dongjoon Hyun <dongjoon@apache.org> Signed-off-by: Dongjoon Hyun <dongjoon@apache.org> (cherry picked from commit 191ce4c) Signed-off-by: Dongjoon Hyun <dongjoon@apache.org>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What changes were proposed in this pull request?
This PR aims to update
NOTICE-binarywithNetty4.2.7 license.Why are the changes needed?
It seems that we updated
Netty Noticeat Apache Spark3.0.0-previewwithNetty 4.1.30.Final.Since there are many changes like the following, we need to update it by simply copying and pasting.
Additionally, I also double-checked newly added transitive license through ASF LEGAL-700. We are good to go.
Does this PR introduce any user-facing change?
No behavior change.
How was this patch tested?
Manual review.
Was this patch authored or co-authored using generative AI tooling?
No.