Skip to content

print-stack#873

Merged
shargon merged 9 commits intoneo-project:masterfrom
Jim8y:print-stack
Feb 8, 2024
Merged

print-stack#873
shargon merged 9 commits intoneo-project:masterfrom
Jim8y:print-stack

Conversation

@Jim8y
Copy link
Contributor

@Jim8y Jim8y commented Jan 17, 2024

Print the execution stack while running the unit test contract.

Jim8y added 3 commits January 18, 2024 01:35
* master:
  [Framework: Add] Define Standard Enum (#877)
  Fix: Fix dependency (#876)
  create seperate test contracts (#868)
  fix-nep11token (#874)
  add comments to statements (#875)
  move neo-core projects into a dependency folder to make it clear. (#871)
@Jim8y
Copy link
Contributor Author

Jim8y commented Jan 31, 2024

@shargon

@shargon
Copy link
Member

shargon commented Feb 1, 2024

@Jim8y Didn't we already merge a PR that did this?

@Jim8y
Copy link
Contributor Author

Jim8y commented Feb 1, 2024

@Jim8y Didn't we already merge a PR that did this?

Its in the core, but roman and chris think it is not good to add test features into the core, so i have to add them seperately into the test.

Co-authored-by: Shargon <shargon@gmail.com>
Copy link
Member

@shargon shargon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Wait for neo-project/neo#3110 and use this extension here

@Jim8y
Copy link
Contributor Author

Jim8y commented Feb 1, 2024

Wait for neo-project/neo#3110 and use this extension here

Its in the unit tests, we can not access them here.

@shargon
Copy link
Member

shargon commented Feb 1, 2024

Wait for neo-project/neo#3110 and use this extension here

Its in the unit tests, we can not access them here.

Is right, and is not better to reuse, and don't move the method outside vm? (https://github.com/neo-project/neo/pull/3110/files#diff-30362cba3801f54b23b08a98f1a0887bee8e3b611fd6cc8e412ec58800633f62L39)

@Jim8y
Copy link
Contributor Author

Jim8y commented Feb 1, 2024

Wait for neo-project/neo#3110 and use this extension here

Its in the unit tests, we can not access them here.

Is right, and is not better to reuse, and don't move the method outside vm? (https://github.com/neo-project/neo/pull/3110/files#diff-30362cba3801f54b23b08a98f1a0887bee8e3b611fd6cc8e412ec58800633f62L39)

That one is the one you merged, not in any release yet, for the same purpose here but have a bug in parsing string.

@Jim8y
Copy link
Contributor Author

Jim8y commented Feb 8, 2024

@shargon good to merge now.

@shargon shargon merged commit 7c28d32 into neo-project:master Feb 8, 2024
@Jim8y Jim8y deleted the print-stack branch February 8, 2024 11:17
Jim8y added a commit that referenced this pull request Aug 3, 2025
* print-stack
* update stack print
* Update tests/Neo.SmartContract.TestEngine/Extensions.cs
Co-authored-by: Shargon <shargon@gmail.com>
* adapt latest neo.
* fotmat
---------
Co-authored-by: Shargon <shargon@gmail.com>
Jim8y added a commit that referenced this pull request Aug 18, 2025
* print-stack

* update stack print

* Update tests/Neo.SmartContract.TestEngine/Extensions.cs

Co-authored-by: Shargon <shargon@gmail.com>

* adapt latest neo.

* fotmat

---------

Co-authored-by: Shargon <shargon@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants