Skip to content

move neo-core projects into a dependency folder to make it clear.#871

Merged
Jim8y merged 1 commit intoneo-project:masterfrom
Jim8y:dependency
Jan 19, 2024
Merged

move neo-core projects into a dependency folder to make it clear.#871
Jim8y merged 1 commit intoneo-project:masterfrom
Jim8y:dependency

Conversation

@Jim8y
Copy link
Contributor

@Jim8y Jim8y commented Jan 17, 2024

Just find it misleading to mix everything in the src folder. so move the neo-core to a dependency folder. No logic is changed

@vncoelho
Copy link
Member

vncoelho commented Jan 17, 2024

Why not move to neo-core the devpack instead?

I think we should archive here as we discussed in the examples PR.

@Jim8y
Copy link
Contributor Author

Jim8y commented Jan 18, 2024 •
edited
Loading

@vncoelho

  1. Adding submodule is much faster than merging into monorrpo, i need it to debug the devpack, can't wait for months.

  2. Monorepo is for the ease of maintaining and debugging, now the submodule also work.

  3. A problem with the monorepo is that it needs to release files, might be too big since nccs also need to release files.

  4. Community members have asked to keep the devpack separate.

@Jim8y Jim8y merged commit 768f62c into neo-project:master Jan 19, 2024
@Jim8y Jim8y deleted the dependency branch January 19, 2024 02:41
Jim8y added a commit that referenced this pull request Aug 3, 2025
@Jim8y
move neo-core projects into a dependency folder to make it clear. (#871)
1d8a6f1
Jim8y added a commit that referenced this pull request Aug 18, 2025
@Jim8y
move neo-core projects into a dependency folder to make it clear. (#871)
1f5641b
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@shargon shargon shargon approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@Jim8y @vncoelho @shargon