add comments to statements#875
Merged
Jim8y merged 3 commits intoneo-project:masterfrom Jan 22, 2024
Jim8y:statement-comments
Merged
add comments to statements#875Jim8y merged 3 commits intoneo-project:masterfrom Jim8y:statement-comments
Jim8y merged 3 commits intoneo-project:masterfrom
Jim8y:statement-comments
Conversation
shargon
reviewed
Jan 22, 2024
src/Neo.Compiler.CSharp/MethodConvert/Statement/WhileStatement.cs
Outdated
Show resolved
Hide resolved
src/Neo.Compiler.CSharp/MethodConvert/Statement/TryStatement.cs
Outdated
Show resolved
Hide resolved
src/Neo.Compiler.CSharp/MethodConvert/Statement/ThrowStatement.cs
Outdated
Show resolved
Hide resolved
src/Neo.Compiler.CSharp/MethodConvert/Statement/SwitchStatement.cs
Outdated
Show resolved
Hide resolved
src/Neo.Compiler.CSharp/MethodConvert/Statement/ReturnStatement.cs
Outdated
Show resolved
Hide resolved
src/Neo.Compiler.CSharp/MethodConvert/Statement/GotoStatement.cs
Outdated
Show resolved
Hide resolved
src/Neo.Compiler.CSharp/MethodConvert/Statement/ForStatement.cs
Outdated
Show resolved
Hide resolved
src/Neo.Compiler.CSharp/MethodConvert/Statement/ExpressionStatement.cs
Outdated
Show resolved
Hide resolved
src/Neo.Compiler.CSharp/MethodConvert/Statement/ContinueStatement.cs
Outdated
Show resolved
Hide resolved
Clean empty lines
shargon
approved these changes
Jan 22, 2024
Contributor
Author
|
So many empty lines...... it must be the dotnet format |
Jim8y
added a commit
that referenced
this pull request
Aug 3, 2025
* add comments to statements * Clean empty lines * Apply suggestions from code review Clean empty lines --------- Co-authored-by: Shargon <shargon@gmail.com>
Jim8y
added a commit
that referenced
this pull request
Aug 18, 2025
* add comments to statements * Clean empty lines * Apply suggestions from code review Clean empty lines --------- Co-authored-by: Shargon <shargon@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This pr adds comments to the statements convert. Part of my plan to comment the compiler.
This one is much easier cause statements are easy to understand, but will reach to the point where expressions are not easy to understand, for instance
ConvertElementAccessCoalesceAssignment.