Load plugins before initializing the system and call OnPluginsLoaded afterward.#633
Merged
Load plugins before initializing the system and call OnPluginsLoaded afterward.#633
Conversation
…afterward. This supports: * ... persist plugins running on persisting the genesis block. * ... import blocks plugin to be able to load blocks after other plugins are loaded.
vncoelho
reviewed
Mar 11, 2019
Member
There was a problem hiding this comment.
Sounds precise and simple, @jsolman.
It was great that this was found during this journey of UTXO to plugin, it is a good improvement for several other plugins to come.
Let`s wait for @shargon and @erikzhang to give their feedback as well.
vncoelho
reviewed
Mar 11, 2019
This was referenced Mar 11, 2019
vncoelho
reviewed
Mar 12, 2019
vncoelho
previously approved these changes
Mar 12, 2019
Member
|
From my perspective it is ready and it a quite useful modification. |
jsolman
commented
Mar 12, 2019
erikzhang
requested changes
Mar 12, 2019
…ore all plugins loaded." This reverts commit c3cf527.
erikzhang
reviewed
Mar 12, 2019
erikzhang
reviewed
Mar 12, 2019
erikzhang
approved these changes
Mar 12, 2019
vncoelho
approved these changes
Mar 12, 2019
Thacryba
pushed a commit
to simplitech/neo
that referenced
this pull request
Feb 17, 2020
Change applicationlog introduction for v2.9
Thacryba
pushed a commit
to simplitech/neo
that referenced
this pull request
Feb 17, 2020
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The plugins need to be loaded first in order to facilitate:
This is also needed by neo-project/neo-modules/pull/52
This change also requires the following change in the ApplicationLogs plugin:
neo-project/neo-modules/pull/55