Fix application logs after adding EventStream usage and OnPluginsLoaded.#55
Fix application logs after adding EventStream usage and OnPluginsLoaded.#55jsolman merged 11 commits intoplugins-2.10.1from
Conversation
|
Sounds good, Jeff, I will soon take a look. |
|
|
||
| <ItemGroup> | ||
| <PackageReference Include="Neo" Version="2.9.4" /> | ||
| <PackageReference Include="Neo" Version="2.10.1-CI00001" /> |
There was a problem hiding this comment.
Should wait for the release of neo core.
There was a problem hiding this comment.
That is fine, this will just stay here for reference for people building master that need this plugin to work, right?
There was a problem hiding this comment.
Hi @erikzhang,
Do you think that we should create another branch, for example, "plugins dev" and merge this and other upcoming changes there?
In this sense we could aggregate everything that is needed for the next release.
vncoelho
left a comment
There was a problem hiding this comment.
It looks good, let's wait for the next release.
vncoelho
left a comment
There was a problem hiding this comment.
Tested locally and plugin was working as expected with the last up to date neo master.
|
This also still references NuGet CI build, thus waiting to merge. |
|
closes #50 |
Closes #50