This repository was archived by the owner on Nov 10, 2025. It is now read-only.
Import blocks after plugins are loaded.#53
Merged
jsolman merged 6 commits intoplugins-2.10.1from Mar 14, 2019
Merged
Conversation
vncoelho
previously approved these changes
Mar 12, 2019
Member
vncoelho
left a comment
There was a problem hiding this comment.
I agree, the design looks good to me!
But let's wait for @erikzhang to check this new ideas.
jsolman
commented
Mar 12, 2019
shargon
previously approved these changes
Mar 13, 2019
Contributor
Author
|
This also still references NuGet CI build, thus waiting to merge. |
vncoelho
approved these changes
Mar 14, 2019
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
All persist plugins need to be loaded before blocks start importing.
Depends on neo-project/neo/pull/633