NeoToken: add NEP-27 to supported standards list starting from Echidna by AnnaShaleva · Pull Request #3643 · neo-project/neo

AnnaShaleva · 2024-12-23T05:52:03Z

Description

#3597 introduces onNEP17Payment handler to native NeoToken contract starting from Echidna hardfork. We need to update the list of supported standards respectively.

Type of change

Optimization (the change is only an optimization)
Style (the change is only a code style for better maintenance or standard purpose)
Bug fix (non-breaking change which fixes an issue)
New feature (non-breaking change which adds functionality)
Breaking change (fix or feature that would cause existing functionality to not work as expected)
This change requires a documentation update

How Has This Been Tested?

TestGenesisNativeState unit-test.

Checklist:

My code follows the style guidelines of this project
I have performed a self-review of my code
I have commented my code, particularly in hard-to-understand areas
I have made corresponding changes to the documentation
My changes generate no new warnings
I have added tests that prove my fix is effective or that my feature works
New and existing unit tests pass locally with my changes
Any dependent changes have been merged and published in downstream modules

roman-khimov

Should be OK, technically it's correct to have NEP-27 in standards.

src/Neo/SmartContract/Native/FungibleToken.cs

AnnaShaleva · 2024-12-23T08:47:13Z

Tests are failing, but not due to this PR:

 expect: read eof
expect: set expect_out(spawn_id) "exp3"
expect: set expect_out(buffer) "System.ArgumentException: Invalid multisig parameters: m=0, publicKeys.Count=0\r\n   at Neo.SmartContract.Contract.CreateMultiSigRedeemScript(Int32 m, IReadOnlyCollection`1 publicKeys) in /home/runner/work/neo/neo/src/Neo/SmartContract/Contract.cs:line 106\r\n   at Neo.SmartContract.Contract.GetBFTAddress(IReadOnlyCollection`1 pubkeys) in /home/runner/work/neo/neo/src/Neo/SmartContract/Contract.cs:line 152\r\n   at Neo.NeoSystem.CreateGenesisBlock(ProtocolSettings settings) in /home/runner/work/neo/neo/src/Neo/NeoSystem.cs:line 153\r\n   at Neo.NeoSystem..ctor(ProtocolSettings settings, IStoreProvider storageProvider, String storagePath) in /home/runner/work/neo/neo/src/Neo/NeoSystem.cs:line 135\r\n   at Neo.NeoSystem..ctor(ProtocolSettings settings, String storageProvider, String storagePath) in /home/runner/work/neo/neo/src/Neo/NeoSystem.cs:line 121\r\n   at Neo.CLI.MainService.Start(CommandLineOptions options) in /home/runner/work/neo/neo/src/Neo.CLI/CLI/MainService.cs:line 381\r\n   at System.Threading.Tasks.Task.<>c.<ThrowAsync>b__128_1(Object state)\r\n   at System.Threading.ThreadPoolWorkQueue.Dispatch()\r\n   at System.Threading.PortableThreadPool.WorkerThread.WorkerThreadStart()\r\ncreate wallet ./bin/Neo.CLI/test-wallet1.json\r\n"
expect: spawn id exp3 not open
    while executing
"expect {
    "password:" { send "asd\n" }
    "error" { exit 2 }
    timeout { exit 1 }
}"

Jim8y · 2024-12-24T14:05:02Z

Tests are failing, but not due to this PR:

 expect: read eof
expect: set expect_out(spawn_id) "exp3"
expect: set expect_out(buffer) "System.ArgumentException: Invalid multisig parameters: m=0, publicKeys.Count=0\r\n   at Neo.SmartContract.Contract.CreateMultiSigRedeemScript(Int32 m, IReadOnlyCollection`1 publicKeys) in /home/runner/work/neo/neo/src/Neo/SmartContract/Contract.cs:line 106\r\n   at Neo.SmartContract.Contract.GetBFTAddress(IReadOnlyCollection`1 pubkeys) in /home/runner/work/neo/neo/src/Neo/SmartContract/Contract.cs:line 152\r\n   at Neo.NeoSystem.CreateGenesisBlock(ProtocolSettings settings) in /home/runner/work/neo/neo/src/Neo/NeoSystem.cs:line 153\r\n   at Neo.NeoSystem..ctor(ProtocolSettings settings, IStoreProvider storageProvider, String storagePath) in /home/runner/work/neo/neo/src/Neo/NeoSystem.cs:line 135\r\n   at Neo.NeoSystem..ctor(ProtocolSettings settings, String storageProvider, String storagePath) in /home/runner/work/neo/neo/src/Neo/NeoSystem.cs:line 121\r\n   at Neo.CLI.MainService.Start(CommandLineOptions options) in /home/runner/work/neo/neo/src/Neo.CLI/CLI/MainService.cs:line 381\r\n   at System.Threading.Tasks.Task.<>c.<ThrowAsync>b__128_1(Object state)\r\n   at System.Threading.ThreadPoolWorkQueue.Dispatch()\r\n   at System.Threading.PortableThreadPool.WorkerThread.WorkerThreadStart()\r\ncreate wallet ./bin/Neo.CLI/test-wallet1.json\r\n"
expect: spawn id exp3 not open
    while executing
"expect {
    "password:" { send "asd\n" }
    "error" { exit 2 }
    timeout { exit 1 }
}"

Test fails only in the workflow, i could not reproduce it locally,,, thus i can not debug it.... @cschuchardt88 any idea how to fix?

#3597 introduces `onNEP17Payment` handler to native NeoToke contract starting from Echidna hardfork. We need to update the list of supported standards respectively. Signed-off-by: Anna Shaleva <shaleva.ann@nspcc.ru>

shargon · 2024-12-27T09:05:44Z

UT problem could be fixed in a different PR

Port neo-project/neo#3643. Signed-off-by: Anna Shaleva <shaleva.ann@nspcc.ru>

* add hardofork HF_Echidna * Add entries to `Designation` event (#3397) * Add entries to Designation event * Change to HF_Echidna * Add UT * Add count * [Neo Core StdLib] Add Base64url (#3453) * add base64url * active in * update placehold hf height * fix hf issue and move methods to proper place. * fix test * use identifymodel instead. * add hardofork HF_Echidna * Add entries to `Designation` event (#3397) * Add entries to Designation event * Change to HF_Echidna * Add UT * Add count * [Neo Core StdLib] Add Base64url (#3453) * add base64url * active in * update placehold hf height * fix hf issue and move methods to proper place. * fix test * use identifymodel instead. * add hardofork HF_Echidna * Add entries to `Designation` event (#3397) * Add entries to Designation event * Change to HF_Echidna * Add UT * Add count * [Neo Core StdLib] Add Base64url (#3453) * add base64url * active in * update placehold hf height * fix hf issue and move methods to proper place. * fix test * use identifymodel instead. * format * Fixed typo * Added back #3397 * Fixed tests * fixed global.json * Update src/Neo/Neo.csproj * Update src/Neo/Neo.csproj * [`Fix`]: integer overflow in `JumpTable.SubStr ` (#3496) * fix: int overflow in SubStr * fix: int overflow in SubStr * format * Versioning change * Clean * Rename * Show change * Space * remove duplicated lines in gitignroe --------- Co-authored-by: Jimmy <jinghui@wayne.edu> Co-authored-by: Shargon <shargon@gmail.com> * Fix NEO callstates (#3599) * Allow callstates to use HF * Rename to method * Other rename * Change the way * Reduce changes * Reduce changes * Adapt name always * Avoid string when only is lower the first char * UT * Test all * Update src/Neo/ProtocolSettings.cs Co-authored-by: Christopher Schuchardt <cschuchardt88@gmail.com> * Update src/Neo/ProtocolSettings.cs Co-authored-by: Christopher Schuchardt <cschuchardt88@gmail.com> * Reuse Load from stream * Unify * Fix default logic * Change ContractMethod to allowMultiple * Use LowerInvariant * Move CheckingHardfork * Remove optional arg * Fix build * Avoid file not found error --------- Co-authored-by: Christopher Schuchardt <cschuchardt88@gmail.com> * fix tests error (#3636) * fux build error * Update src/Neo/SmartContract/ApplicationEngine.cs --------- Co-authored-by: Shargon <shargon@gmail.com> * NeoToken: accept candidate registration via onNEP17Payment (#3597) Solves two problems: * inability to estimate GAS needed for registerCandidate in a regular way because of its very high fee (more than what normal RPC servers allow) * inability to have MaxBlockSystemFee lower than the registration price which is very high on its own (more than practically possible to execute) Fixes #3552. Signed-off-by: Roman Khimov <roman@nspcc.ru> * specify the argument exception information. * Fix Ut (#3635) * NeoToken: add NEP-27 to supported standards list starting from Echidna (#3643) #3597 introduces `onNEP17Payment` handler to native NeoToke contract starting from Echidna hardfork. We need to update the list of supported standards respectively. Signed-off-by: Anna Shaleva <shaleva.ann@nspcc.ru> * ut: fix HF_Echidna unit tests (#3646) * Fix UT * Update src/Neo/ProtocolSettings.cs Co-authored-by: nan01ab <yjcc201374@outlook.com> * Update src/Neo/ProtocolSettings.cs Co-authored-by: nan01ab <yjcc201374@outlook.com> * Update src/Neo/ProtocolSettings.cs Co-authored-by: Christopher Schuchardt <cschuchardt88@gmail.com> --------- Co-authored-by: Jimmy <jinghui@wayne.edu> Co-authored-by: nan01ab <yjcc201374@outlook.com> Co-authored-by: Christopher Schuchardt <cschuchardt88@gmail.com> * [Core Add] Add support to Ed25519 (#3507) * fix unnecessary change * Clean using --------- Co-authored-by: Fernando Diaz Toledano <shargon@gmail.com> * Fix `HF_Echidna` comments (#3679) * Fix obsolete * Fix https://github.com/neo-project/neo/pull/3454/files#r1912152270 * Fix comment * Update RoleManagement.cs * Unset HF_Echidna * Revert getTransaction * Revert verifyWithECDsa * format --------- Signed-off-by: Roman Khimov <roman@nspcc.ru> Signed-off-by: Anna Shaleva <shaleva.ann@nspcc.ru> Co-authored-by: Shargon <shargon@gmail.com> Co-authored-by: Christopher Schuchardt <cschuchardt88@gmail.com> Co-authored-by: nan01ab <yjcc201374@outlook.com> Co-authored-by: Roman Khimov <roman@nspcc.ru> Co-authored-by: Anna Shaleva <shaleva.ann@nspcc.ru> Co-authored-by: Vitor Nazário Coelho <vncoelho@gmail.com>

AnnaShaleva added the Hardfork label Dec 23, 2024

AnnaShaleva requested review from Jim8y, cschuchardt88, nan01ab, roman-khimov, shargon and vncoelho December 23, 2024 05:52

roman-khimov reviewed Dec 23, 2024

View reviewed changes

src/Neo/SmartContract/Native/FungibleToken.cs Show resolved Hide resolved

AnnaShaleva force-pushed the nep27-neo branch from 0771b26 to 285ee2c Compare December 23, 2024 08:42

AnnaShaleva mentioned this pull request Dec 25, 2024

NEO candidate registration via NEP-27 callback nspcc-dev/neo-go#3700

Merged

NeoToken: add NEP-27 to supported standards list starting from Echidna

4e7b11e

#3597 introduces `onNEP17Payment` handler to native NeoToke contract starting from Echidna hardfork. We need to update the list of supported standards respectively. Signed-off-by: Anna Shaleva <shaleva.ann@nspcc.ru>

AnnaShaleva force-pushed the nep27-neo branch from 1fc6871 to 4e7b11e Compare December 25, 2024 07:33

Jim8y approved these changes Dec 25, 2024

View reviewed changes

roman-khimov approved these changes Dec 25, 2024

View reviewed changes

nan01ab approved these changes Dec 26, 2024

View reviewed changes

shargon approved these changes Dec 27, 2024

View reviewed changes

shargon merged commit 548bd05 into HF_Echidna Dec 27, 2024

shargon deleted the nep27-neo branch December 27, 2024 09:05

AnnaShaleva added a commit to nspcc-dev/neo-go that referenced this pull request Jan 20, 2025

native: add NEP-27 to Neo's supported standards

c800b2b

Port neo-project/neo#3643. Signed-off-by: Anna Shaleva <shaleva.ann@nspcc.ru>

AnnaShaleva added a commit to nspcc-dev/neo-go that referenced this pull request Jan 21, 2025

native: add NEP-27 to Neo's supported standards

1fccb56

Port neo-project/neo#3643. Signed-off-by: Anna Shaleva <shaleva.ann@nspcc.ru>

AnnaShaleva added a commit to nspcc-dev/neo-go that referenced this pull request Jan 21, 2025

native: add NEP-27 to Neo's supported standards

d1b4d89

Port neo-project/neo#3643. Signed-off-by: Anna Shaleva <shaleva.ann@nspcc.ru>

AnnaShaleva added a commit to nspcc-dev/neo-go that referenced this pull request Jan 21, 2025

native: add NEP-27 to Neo's supported standards

53be69f

Port neo-project/neo#3643. Signed-off-by: Anna Shaleva <shaleva.ann@nspcc.ru>

AnnaShaleva added a commit to nspcc-dev/neo-go that referenced this pull request Jan 21, 2025

native: add NEP-27 to Neo's supported standards

b2322a8

Port neo-project/neo#3643. Signed-off-by: Anna Shaleva <shaleva.ann@nspcc.ru>

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

NeoToken: add NEP-27 to supported standards list starting from Echidna#3643

NeoToken: add NEP-27 to supported standards list starting from Echidna#3643
shargon merged 1 commit intoHF_Echidnafrom
nep27-neo

AnnaShaleva commented Dec 23, 2024 •

edited

Loading

Uh oh!

roman-khimov left a comment

Uh oh!

Uh oh!

AnnaShaleva commented Dec 23, 2024 •

edited

Loading

Uh oh!

Jim8y commented Dec 24, 2024 •

edited

Loading

Uh oh!

shargon commented Dec 27, 2024

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

5 participants

Conversation

AnnaShaleva commented Dec 23, 2024 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Description

Type of change

How Has This Been Tested?

Checklist:

Uh oh!

roman-khimov left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

AnnaShaleva commented Dec 23, 2024 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

Jim8y commented Dec 24, 2024 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

shargon commented Dec 27, 2024

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

5 participants

AnnaShaleva commented Dec 23, 2024 •

edited

Loading

AnnaShaleva commented Dec 23, 2024 •

edited

Loading

Jim8y commented Dec 24, 2024 •

edited

Loading