Fix NEO callstates by shargon · Pull Request #3599 · neo-project/neo

shargon · 2024-11-26T11:31:38Z

Description

Fixes #3596

Type of change

Optimization (the change is only an optimization)
Style (the change is only a code style for better maintenance or standard purpose)
Bug fix (non-breaking change which fixes an issue)
New feature (non-breaking change which adds functionality)
Breaking change (fix or feature that would cause existing functionality to not work as expected)
This change requires a documentation update

How Has This Been Tested?

Manual

Test Configuration:

Checklist:

My code follows the style guidelines of this project
I have performed a self-review of my code
I have commented my code, particularly in hard-to-understand areas
I have made corresponding changes to the documentation
My changes generate no new warnings
I have added tests that prove my fix is effective or that my feature works
New and existing unit tests pass locally with my changes
Any dependent changes have been merged and published in downstream modules

roman-khimov

vote method requires this too.

src/Neo/SmartContract/Native/NativeContract.cs

roman-khimov

Much better this way. Probably solving any other similar problems (like CpuFee updates). I'd try avoiding unnecessary changes, but that's nitpicking mostly.

src/Neo/ProtocolSettings.cs

src/Neo/SmartContract/Native/ContractMethodMetadata.cs

cschuchardt88

Please fix these memory leaks

src/Neo/ProtocolSettings.cs

Co-authored-by: Christopher Schuchardt <cschuchardt88@gmail.com>

cschuchardt88 · 2024-11-26T23:04:05Z

src/Neo/ProtocolSettings.cs

        public static ProtocolSettings Load(Stream stream)
        {
-            var config = new ConfigurationBuilder().AddJsonStream(stream).Build();
+            using var config = new ConfigurationBuilder().AddJsonStream(stream).Build();


ConfigurationBuilder on build uses ConfigurationRoot may have to cast to it. either way needs to be fixed for memory leak.

or could do
((IDisposable)config).Dispose(); at of the method

https://github.com/dotnet/runtime/blob/9d5a6a9aa463d6d10b0b0ba6d5982cc82f363dc3/src/libraries/Microsoft.Extensions.Configuration/src/ConfigurationBuilder.cs#L53C24-L53C41

It was not a memory leak...

ConfiguationRoot is the class that is created for inherits from IConfigurationRoot

How isn't it a memory leak, The memory for the providers are still allocated? Streams and all.
https://github.com/dotnet/runtime/blob/9d5a6a9aa463d6d10b0b0ba6d5982cc82f363dc3/src/libraries/Microsoft.Extensions.Configuration/src/ConfigurationRoot.cs#L99C9-L112C10

Just do (config as IDisposable)?.Dispose() what's the big deal?

Fixed problem

src/Neo/SmartContract/Native/CryptoLib.cs

shargon · 2024-11-27T08:02:34Z

Ready to review again

src/Neo/ProtocolSettings.cs

src/Neo/SmartContract/Native/NeoToken.cs

AnnaShaleva

LGTM.

src/Neo/SmartContract/Native/NativeContract.cs

* add hardofork HF_Echidna * Add entries to `Designation` event (#3397) * Add entries to Designation event * Change to HF_Echidna * Add UT * Add count * [Neo Core StdLib] Add Base64url (#3453) * add base64url * active in * update placehold hf height * fix hf issue and move methods to proper place. * fix test * use identifymodel instead. * add hardofork HF_Echidna * Add entries to `Designation` event (#3397) * Add entries to Designation event * Change to HF_Echidna * Add UT * Add count * [Neo Core StdLib] Add Base64url (#3453) * add base64url * active in * update placehold hf height * fix hf issue and move methods to proper place. * fix test * use identifymodel instead. * add hardofork HF_Echidna * Add entries to `Designation` event (#3397) * Add entries to Designation event * Change to HF_Echidna * Add UT * Add count * [Neo Core StdLib] Add Base64url (#3453) * add base64url * active in * update placehold hf height * fix hf issue and move methods to proper place. * fix test * use identifymodel instead. * format * Fixed typo * Added back #3397 * Fixed tests * fixed global.json * Update src/Neo/Neo.csproj * Update src/Neo/Neo.csproj * [`Fix`]: integer overflow in `JumpTable.SubStr ` (#3496) * fix: int overflow in SubStr * fix: int overflow in SubStr * format * Versioning change * Clean * Rename * Show change * Space * remove duplicated lines in gitignroe --------- Co-authored-by: Jimmy <jinghui@wayne.edu> Co-authored-by: Shargon <shargon@gmail.com> * Fix NEO callstates (#3599) * Allow callstates to use HF * Rename to method * Other rename * Change the way * Reduce changes * Reduce changes * Adapt name always * Avoid string when only is lower the first char * UT * Test all * Update src/Neo/ProtocolSettings.cs Co-authored-by: Christopher Schuchardt <cschuchardt88@gmail.com> * Update src/Neo/ProtocolSettings.cs Co-authored-by: Christopher Schuchardt <cschuchardt88@gmail.com> * Reuse Load from stream * Unify * Fix default logic * Change ContractMethod to allowMultiple * Use LowerInvariant * Move CheckingHardfork * Remove optional arg * Fix build * Avoid file not found error --------- Co-authored-by: Christopher Schuchardt <cschuchardt88@gmail.com> * fix tests error (#3636) * fux build error * Update src/Neo/SmartContract/ApplicationEngine.cs --------- Co-authored-by: Shargon <shargon@gmail.com> * NeoToken: accept candidate registration via onNEP17Payment (#3597) Solves two problems: * inability to estimate GAS needed for registerCandidate in a regular way because of its very high fee (more than what normal RPC servers allow) * inability to have MaxBlockSystemFee lower than the registration price which is very high on its own (more than practically possible to execute) Fixes #3552. Signed-off-by: Roman Khimov <roman@nspcc.ru> * specify the argument exception information. * Fix Ut (#3635) * NeoToken: add NEP-27 to supported standards list starting from Echidna (#3643) #3597 introduces `onNEP17Payment` handler to native NeoToke contract starting from Echidna hardfork. We need to update the list of supported standards respectively. Signed-off-by: Anna Shaleva <shaleva.ann@nspcc.ru> * ut: fix HF_Echidna unit tests (#3646) * Fix UT * Update src/Neo/ProtocolSettings.cs Co-authored-by: nan01ab <yjcc201374@outlook.com> * Update src/Neo/ProtocolSettings.cs Co-authored-by: nan01ab <yjcc201374@outlook.com> * Update src/Neo/ProtocolSettings.cs Co-authored-by: Christopher Schuchardt <cschuchardt88@gmail.com> --------- Co-authored-by: Jimmy <jinghui@wayne.edu> Co-authored-by: nan01ab <yjcc201374@outlook.com> Co-authored-by: Christopher Schuchardt <cschuchardt88@gmail.com> * [Core Add] Add support to Ed25519 (#3507) * fix unnecessary change * Clean using --------- Co-authored-by: Fernando Diaz Toledano <shargon@gmail.com> * Fix `HF_Echidna` comments (#3679) * Fix obsolete * Fix https://github.com/neo-project/neo/pull/3454/files#r1912152270 * Fix comment * Update RoleManagement.cs * Unset HF_Echidna * Revert getTransaction * Revert verifyWithECDsa * format --------- Signed-off-by: Roman Khimov <roman@nspcc.ru> Signed-off-by: Anna Shaleva <shaleva.ann@nspcc.ru> Co-authored-by: Shargon <shargon@gmail.com> Co-authored-by: Christopher Schuchardt <cschuchardt88@gmail.com> Co-authored-by: nan01ab <yjcc201374@outlook.com> Co-authored-by: Roman Khimov <roman@nspcc.ru> Co-authored-by: Anna Shaleva <shaleva.ann@nspcc.ru> Co-authored-by: Vitor Nazário Coelho <vncoelho@gmail.com>

Allow callstates to use HF

4a1f660

shargon requested review from Jim8y and roman-khimov November 26, 2024 11:31

shargon added 2 commits November 26, 2024 12:33

Rename to method

6f31b4e

Other rename

a60bdac

shargon marked this pull request as ready for review November 26, 2024 11:37

shargon added the Waiting for Review label Nov 26, 2024

roman-khimov reviewed Nov 26, 2024

View reviewed changes

src/Neo/SmartContract/Native/NativeContract.cs Outdated Show resolved Hide resolved

shargon added 5 commits November 26, 2024 14:51

Change the way

6fa19aa

Reduce changes

66804dd

Reduce changes

4bced57

Adapt name always

2d760c1

Avoid string when only is lower the first char

4eb75bc

shargon requested a review from roman-khimov November 26, 2024 13:57

shargon added 2 commits November 26, 2024 16:12

UT

a989f9c

Test all

f860146

shargon added Bug Used to tag confirmed bugs Hardfork labels Nov 26, 2024

shargon changed the title ~~Allow callstates to use HF~~ Allow NEO callstates Nov 26, 2024

shargon changed the title ~~Allow NEO callstates~~ Fix NEO callstates Nov 26, 2024

roman-khimov reviewed Nov 26, 2024

View reviewed changes

src/Neo/ProtocolSettings.cs Outdated Show resolved Hide resolved

src/Neo/ProtocolSettings.cs Outdated Show resolved Hide resolved

src/Neo/SmartContract/Native/ContractMethodMetadata.cs Outdated Show resolved Hide resolved

cschuchardt88 previously requested changes Nov 26, 2024

View reviewed changes

src/Neo/ProtocolSettings.cs Outdated Show resolved Hide resolved

src/Neo/ProtocolSettings.cs Show resolved Hide resolved

shargon and others added 2 commits November 26, 2024 23:46

Update src/Neo/ProtocolSettings.cs

68f3fdd

Co-authored-by: Christopher Schuchardt <cschuchardt88@gmail.com>

Update src/Neo/ProtocolSettings.cs

9bebffe

Co-authored-by: Christopher Schuchardt <cschuchardt88@gmail.com>

cschuchardt88 reviewed Nov 26, 2024

View reviewed changes

Jim8y reviewed Nov 27, 2024

View reviewed changes

src/Neo/SmartContract/Native/CryptoLib.cs Show resolved Hide resolved

Jim8y added this to the v3.8.0 milestone Nov 27, 2024

Jim8y mentioned this pull request Nov 27, 2024

Add hardfork HF_Echidna #3454

Merged

11 tasks

Reuse Load from stream

2dd5e29

shargon added 4 commits November 27, 2024 08:55

Unify

6c7c89a

Fix default logic

c6db216

Change ContractMethod to allowMultiple

dad7e0d

Use LowerInvariant

ca9ddad

Move CheckingHardfork

753b66b

cschuchardt88 reviewed Nov 27, 2024

View reviewed changes

src/Neo/ProtocolSettings.cs Outdated Show resolved Hide resolved

roman-khimov approved these changes Nov 29, 2024

View reviewed changes

src/Neo/SmartContract/Native/NeoToken.cs Show resolved Hide resolved

shargon added 3 commits December 1, 2024 14:21

Remove optional arg

21444f0

Fix build

01ef226

Avoid file not found error

9432a2a

AnnaShaleva reviewed Dec 4, 2024

View reviewed changes

src/Neo/SmartContract/Native/NativeContract.cs Show resolved Hide resolved

AnnaShaleva approved these changes Dec 6, 2024

View reviewed changes

AnnaShaleva mentioned this pull request Dec 18, 2024

[Dec.19] Core Dev Regular Meeting Proposal Discussion #3632

Closed

Jim8y added the Ready to Merge label Dec 19, 2024

Jim8y approved these changes Dec 19, 2024

View reviewed changes

roman-khimov approved these changes Dec 19, 2024

View reviewed changes

NGDAdmin merged commit 705f4bb into HF_Echidna Dec 19, 2024

NGDAdmin deleted the call-states-hf branch December 19, 2024 07:37

shargon mentioned this pull request Jan 8, 2025

NEO contract violates security constraints (a bit) #3596

Closed

mialbu mentioned this pull request Feb 27, 2025

Change default Call Flags of provided Contract Interface Functions neow3j/neow3j#1098

Closed

Conversation

shargon commented Nov 26, 2024 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Description

Type of change

How Has This Been Tested?

Checklist:

Uh oh!

roman-khimov left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

roman-khimov left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

cschuchardt88 left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

cschuchardt88 Nov 26, 2024 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

shargon Nov 27, 2024

Choose a reason for hiding this comment

Uh oh!

cschuchardt88 Nov 27, 2024 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Uh oh!

shargon commented Nov 27, 2024

Uh oh!

Uh oh!

Uh oh!

AnnaShaleva left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

6 participants

shargon commented Nov 26, 2024 •

edited

Loading

cschuchardt88 Nov 26, 2024 •

edited

Loading

cschuchardt88 Nov 27, 2024 •

edited

Loading