[Core Add] Add support to Ed25519 by Jim8y · Pull Request #3507 · neo-project/neo

Jim8y · 2024-10-02T12:50:54Z

Description

This pr adds support to Ed25519 as is suggested in #3506

Tested with test vectors from RFC 8032 (https://datatracker.ietf.org/doc/html/rfc8032)

Fixes # #3506

Type of change

Optimization (the change is only an optimization)
Style (the change is only a code style for better maintenance or standard purpose)
Bug fix (non-breaking change which fixes an issue)
New feature (non-breaking change which adds functionality)
Breaking change (fix or feature that would cause existing functionality to not work as expected)
This change requires a documentation update

How Has This Been Tested?

Test Configuration:

Checklist:

My code follows the style guidelines of this project
I have performed a self-review of my code
I have commented my code, particularly in hard-to-understand areas
I have made corresponding changes to the documentation
My changes generate no new warnings
I have added tests that prove my fix is effective or that my feature works
New and existing unit tests pass locally with my changes
Any dependent changes have been merged and published in downstream modules

src/Neo.Cryptography.BLS12_381/ConstantTimeUtility.cs

Jim8y · 2024-10-02T13:01:53Z

@edgedlt

src/Neo/SmartContract/Native/CryptoLib.cs

src/Neo/SmartContract/Native/RoleManagement.cs

src/Neo/SmartContract/Native/CryptoLib.cs

shargon

Add ut for false verification?

src/Neo/SmartContract/Native/CryptoLib.cs

Jim8y · 2024-10-03T05:26:01Z

Add ut for false verification?

sure

src/Neo/SmartContract/Native/CryptoLib.cs

src/Neo/SmartContract/Native/RoleManagement.cs

AnnaShaleva · 2024-10-07T16:29:08Z

src/Neo/SmartContract/Native/CryptoLib.cs

+                verifier.BlockUpdate(message, 0, message.Length);
+                return verifier.VerifySignature(signature);
+            }
+            catch (Exception)


Well, I was talking only about ArgumentException, e.g. only about input data of invalid length and some other ArgumentException thrown by this part of code. However, catching any exception is a valid solution as far.

@roman-khimov, what do you think about cases when we should return true/false or FAULT VM?

Can be both ways, but we need to know all of the exceptions that can happen in this block. Some are likely OK to be converted to false result (invalid signature), some may not (verifier constructor failure?). I'd expect some symmetry to ECDSA verification function. Like what happens if the key is wrong?

src/Neo/VM/Helper.cs

nan01ab · 2025-01-03T11:43:05Z

LGTM

Jim8y · 2025-01-07T02:05:50Z

LGTM

need approval

Jim8y · 2025-01-08T01:11:16Z

@roman-khimov @AnnaShaleva i think neogo need to impl this as well, please take a look.

* add hardofork HF_Echidna * Add entries to `Designation` event (#3397) * Add entries to Designation event * Change to HF_Echidna * Add UT * Add count * [Neo Core StdLib] Add Base64url (#3453) * add base64url * active in * update placehold hf height * fix hf issue and move methods to proper place. * fix test * use identifymodel instead. * add hardofork HF_Echidna * Add entries to `Designation` event (#3397) * Add entries to Designation event * Change to HF_Echidna * Add UT * Add count * [Neo Core StdLib] Add Base64url (#3453) * add base64url * active in * update placehold hf height * fix hf issue and move methods to proper place. * fix test * use identifymodel instead. * add hardofork HF_Echidna * Add entries to `Designation` event (#3397) * Add entries to Designation event * Change to HF_Echidna * Add UT * Add count * [Neo Core StdLib] Add Base64url (#3453) * add base64url * active in * update placehold hf height * fix hf issue and move methods to proper place. * fix test * use identifymodel instead. * format * Fixed typo * Added back #3397 * Fixed tests * fixed global.json * Update src/Neo/Neo.csproj * Update src/Neo/Neo.csproj * [`Fix`]: integer overflow in `JumpTable.SubStr ` (#3496) * fix: int overflow in SubStr * fix: int overflow in SubStr * format * Versioning change * Clean * Rename * Show change * Space * remove duplicated lines in gitignroe --------- Co-authored-by: Jimmy <jinghui@wayne.edu> Co-authored-by: Shargon <shargon@gmail.com> * Fix NEO callstates (#3599) * Allow callstates to use HF * Rename to method * Other rename * Change the way * Reduce changes * Reduce changes * Adapt name always * Avoid string when only is lower the first char * UT * Test all * Update src/Neo/ProtocolSettings.cs Co-authored-by: Christopher Schuchardt <cschuchardt88@gmail.com> * Update src/Neo/ProtocolSettings.cs Co-authored-by: Christopher Schuchardt <cschuchardt88@gmail.com> * Reuse Load from stream * Unify * Fix default logic * Change ContractMethod to allowMultiple * Use LowerInvariant * Move CheckingHardfork * Remove optional arg * Fix build * Avoid file not found error --------- Co-authored-by: Christopher Schuchardt <cschuchardt88@gmail.com> * fix tests error (#3636) * fux build error * Update src/Neo/SmartContract/ApplicationEngine.cs --------- Co-authored-by: Shargon <shargon@gmail.com> * NeoToken: accept candidate registration via onNEP17Payment (#3597) Solves two problems: * inability to estimate GAS needed for registerCandidate in a regular way because of its very high fee (more than what normal RPC servers allow) * inability to have MaxBlockSystemFee lower than the registration price which is very high on its own (more than practically possible to execute) Fixes #3552. Signed-off-by: Roman Khimov <roman@nspcc.ru> * specify the argument exception information. * Fix Ut (#3635) * NeoToken: add NEP-27 to supported standards list starting from Echidna (#3643) #3597 introduces `onNEP17Payment` handler to native NeoToke contract starting from Echidna hardfork. We need to update the list of supported standards respectively. Signed-off-by: Anna Shaleva <shaleva.ann@nspcc.ru> * ut: fix HF_Echidna unit tests (#3646) * Fix UT * Update src/Neo/ProtocolSettings.cs Co-authored-by: nan01ab <yjcc201374@outlook.com> * Update src/Neo/ProtocolSettings.cs Co-authored-by: nan01ab <yjcc201374@outlook.com> * Update src/Neo/ProtocolSettings.cs Co-authored-by: Christopher Schuchardt <cschuchardt88@gmail.com> --------- Co-authored-by: Jimmy <jinghui@wayne.edu> Co-authored-by: nan01ab <yjcc201374@outlook.com> Co-authored-by: Christopher Schuchardt <cschuchardt88@gmail.com> * [Core Add] Add support to Ed25519 (#3507) * fix unnecessary change * Clean using --------- Co-authored-by: Fernando Diaz Toledano <shargon@gmail.com> * Fix `HF_Echidna` comments (#3679) * Fix obsolete * Fix https://github.com/neo-project/neo/pull/3454/files#r1912152270 * Fix comment * Update RoleManagement.cs * Unset HF_Echidna * Revert getTransaction * Revert verifyWithECDsa * format --------- Signed-off-by: Roman Khimov <roman@nspcc.ru> Signed-off-by: Anna Shaleva <shaleva.ann@nspcc.ru> Co-authored-by: Shargon <shargon@gmail.com> Co-authored-by: Christopher Schuchardt <cschuchardt88@gmail.com> Co-authored-by: nan01ab <yjcc201374@outlook.com> Co-authored-by: Roman Khimov <roman@nspcc.ru> Co-authored-by: Anna Shaleva <shaleva.ann@nspcc.ru> Co-authored-by: Vitor Nazário Coelho <vncoelho@gmail.com>

`verifyWithEd25519` was recently added in #3507 and is a part of Echidna, but its argument naming convention differs from the one we have in `verifyWithECDsa`. This change is reflected in the CryptoLib's manifest, so it's nice when we have a unified naming in native contract manifest. Signed-off-by: Anna Shaleva <shaleva.ann@nspcc.ru>

…3855) `verifyWithEd25519` was recently added in #3507 and is a part of Echidna, but its argument naming convention differs from the one we have in `verifyWithECDsa`. This change is reflected in the CryptoLib's manifest, so it's nice when we have a unified naming in native contract manifest. Signed-off-by: Anna Shaleva <shaleva.ann@nspcc.ru> Co-authored-by: NGD Admin <154295625+NGDAdmin@users.noreply.github.com>

…eo-project#3855) `verifyWithEd25519` was recently added in neo-project#3507 and is a part of Echidna, but its argument naming convention differs from the one we have in `verifyWithECDsa`. This change is reflected in the CryptoLib's manifest, so it's nice when we have a unified naming in native contract manifest. Signed-off-by: Anna Shaleva <shaleva.ann@nspcc.ru> Co-authored-by: NGD Admin <154295625+NGDAdmin@users.noreply.github.com>

Jim8y changed the base branch from master to HF_Echidna October 2, 2024 12:51

vncoelho reviewed Oct 2, 2024

View reviewed changes

src/Neo.Cryptography.BLS12_381/ConstantTimeUtility.cs Outdated Show resolved Hide resolved

Jim8y marked this pull request as draft October 2, 2024 12:59

Jim8y marked this pull request as ready for review October 2, 2024 13:01

Jim8y requested review from a team and vncoelho October 2, 2024 13:01

Jim8y added the Waiting for Review label Oct 2, 2024

roman-khimov reviewed Oct 2, 2024

View reviewed changes

src/Neo/SmartContract/Native/CryptoLib.cs Outdated Show resolved Hide resolved

src/Neo/SmartContract/Native/RoleManagement.cs Outdated Show resolved Hide resolved

Jim8y commented Oct 2, 2024

View reviewed changes

src/Neo/SmartContract/Native/RoleManagement.cs Outdated Show resolved Hide resolved

Jim8y commented Oct 2, 2024

View reviewed changes

src/Neo/SmartContract/Native/CryptoLib.cs Outdated Show resolved Hide resolved

shargon added the Waiting-Hardfork label Oct 2, 2024

shargon reviewed Oct 2, 2024

View reviewed changes

src/Neo/SmartContract/Native/CryptoLib.cs Outdated Show resolved Hide resolved

AnnaShaleva reviewed Oct 3, 2024

View reviewed changes

src/Neo/SmartContract/Native/CryptoLib.cs Outdated Show resolved Hide resolved

Jim8y commented Oct 4, 2024

View reviewed changes

src/Neo/SmartContract/Native/RoleManagement.cs Outdated Show resolved Hide resolved

shargon approved these changes Oct 4, 2024

View reviewed changes

AnnaShaleva reviewed Oct 7, 2024

View reviewed changes

shargon approved these changes Dec 13, 2024

View reviewed changes

shargon reviewed Jan 2, 2025

View reviewed changes

src/Neo/VM/Helper.cs Outdated Show resolved Hide resolved

src/Neo/VM/Helper.cs Outdated Show resolved Hide resolved

fix unnecessary change

2b057f9

Jim8y force-pushed the ed25519 branch from 65657d8 to 2b057f9 Compare January 3, 2025 03:21

Jim8y requested review from AnnaShaleva, cschuchardt88, nan01ab and shargon January 3, 2025 03:29

Clean using

4d4f883

shargon approved these changes Jan 3, 2025

View reviewed changes

nan01ab approved these changes Jan 7, 2025

View reviewed changes

Jim8y added the Ready to Merge label Jan 9, 2025

NGDAdmin merged commit b1a3ea3 into neo-project:HF_Echidna Jan 9, 2025

AnnaShaleva mentioned this pull request Jan 20, 2025

Add support for verifyWithEd25519 to CryptoLib nspcc-dev/neo-go#3791

Closed

mialbu mentioned this pull request Feb 25, 2025

[Neo 3.8] Add CryptoLib.verifyWithEd25519() neow3j/neow3j#1086

Closed

shargon mentioned this pull request Mar 10, 2025

Add Ed25519 support and corresponding CryptoLib.VerifyWithEdDsa method for signature verification #3506

Closed

AnnaShaleva mentioned this pull request Mar 28, 2025

Native: unify arguments naming of CryptoLib's verifyWith* methods #3855

Merged

15 tasks

Conversation

Jim8y commented Oct 2, 2024

Description

Type of change

How Has This Been Tested?

Checklist:

Uh oh!

Uh oh!

Jim8y commented Oct 2, 2024

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

shargon left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Jim8y commented Oct 3, 2024

Uh oh!

Uh oh!

Uh oh!

AnnaShaleva Oct 7, 2024

Choose a reason for hiding this comment

Uh oh!

roman-khimov Oct 8, 2024

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

nan01ab commented Jan 3, 2025

Uh oh!

Jim8y commented Jan 7, 2025

Uh oh!

Jim8y commented Jan 8, 2025

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

7 participants