Update script to skip publishing if no current users by mmathieum · Pull Request #582 · mtransitapps/commons

mmathieum · 2026-02-19T13:52:03Z

Change error handling for missing current users to success.

gemini-code-assist · 2026-02-19T13:52:17Z

Summary of Changes

Hello @mmathieum, I'm Gemini Code Assist¹! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!

This pull request refines the publish_to_current_users.sh script's error handling for scenarios where no current users are available for publishing. By changing the exit code from an error to a success, the script now gracefully skips the publishing step without causing build failures in automated environments, improving the robustness of the deployment pipeline.

Highlights

Script Exit Behavior: Modified the publish_to_current_users.sh script to exit with a success code (0) instead of an error code (1) when no current users are found.
Logging Improvement: Updated the console output message to clearly indicate that publishing is being skipped when no current users are present, rather than reporting an error.

Changelog

shared/app-android/publish_to_current_users.sh
- Changed the script's exit status from 1 (error) to 0 (success) when no current users are detected.
- Adjusted the log message to reflect that the publishing step is being skipped rather than indicating a failure.

Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point by creating a comment using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands on the current page.

Feature	Command	Description
Code Review	`/gemini review`	Performs a code review for the current pull request in its current state.
Pull Request Summary	`/gemini summary`	Provides a summary of the current pull request in its current state.
Comment	@gemini-code-assist	Responds in comments when explicitly tagged, both in pull request comments and review comments.
Help	`/gemini help`	Displays a list of available commands.

Customization

To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here.

You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.

Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution. ↩

gemini-code-assist

Code Review

This pull request correctly updates the script to exit successfully when no current users are found, which is a sensible change for a CI/CD pipeline. I've pointed out a minor issue with some unreachable code that could be removed to improve the script's clarity.

Copilot · 2026-02-19T13:53:34Z

@mmathieum I've opened a new pull request, #583, to work on those changes. Once the pull request is ready, I'll request review from you.

Addresses review feedback from PR #582 to refactor a multi-line conditional exit into a more concise single-line statement. **Changes:** - Replaced 3-line if/exit block with `&&` operator in `shared/app-android/publish_to_current_users.sh` **Before:** ```bash if [[ ${RESULT} != 0 ]]; then exit ${RESULT}; fi ``` **After:** ```bash [[ ${RESULT} != 0 ]] && exit ${RESULT}; ``` The logic and behavior remain identical - exit with the result code when non-zero.  --- 💡 You can make Copilot smarter by setting up custom instructions, customizing its development environment and configuring Model Context Protocol (MCP) servers. Learn more [Copilot coding agent tips](https://gh.io/copilot-coding-agent-tips) in the docs. --------- Co-authored-by: copilot-swe-agent[bot] <198982749+Copilot@users.noreply.github.com> Co-authored-by: mmathieum <177998+mmathieum@users.noreply.github.com>

Copilot · 2026-02-19T14:13:48Z

@mmathieum I've opened a new pull request, #584, to work on those changes. Once the pull request is ready, I'll request review from you.

Addresses feedback from PR #582 review comment about unnecessary variable usage when checking script exit codes. ## Changes - Replaced three-line exit handling pattern with single-line `|| exit` - Removed all RESULT variable assignments **Before:** ```bash $SCRIPT_DIR/publish_to_alpha.sh; RESULT=$?; [[ ${RESULT} != 0 ]] && exit ${RESULT}; ``` **After:** ```bash $SCRIPT_DIR/publish_to_alpha.sh || exit; ``` The `|| exit` pattern preserves exit codes correctly: when a command fails, `exit` without arguments uses the exit status of that failed command (last command executed).  --- ✨ Let Copilot coding agent [set things up for you](https://github.com/mtransitapps/commons/issues/new?title=✨+Set+up+Copilot+instructions&body=Configure%20instructions%20for%20this%20repository%20as%20documented%20in%20%5BBest%20practices%20for%20Copilot%20coding%20agent%20in%20your%20repository%5D%28https://gh.io/copilot-coding-agent-tips%29%2E%0A%0A%3COnboard%20this%20repo%3E&assignees=copilot) — coding agent works faster and does higher quality work when set up for your repo. --------- Co-authored-by: copilot-swe-agent[bot] <198982749+Copilot@users.noreply.github.com> Co-authored-by: mmathieum <177998+mmathieum@users.noreply.github.com>

Updated publish_to_current_users.sh to include production promotion for alpha and private-beta users, with error handling for each publish step.

mmathieum · 2026-02-19T14:33:42Z

/gemini review

gemini-code-assist

Code Review

This pull request refactors the logic for publishing to different user tracks, making it more explicit and robust. It correctly changes the exit status from an error to success when no current users are found, aligning with the pull request's objective. The use of || exit 1 for error handling in sub-script calls is a good improvement for shell script robustness. However, critical typos were identified in the script name being executed, which need to be corrected to ensure proper functionality.

Co-authored-by: gemini-code-assist[bot] <176961590+gemini-code-assist[bot]@users.noreply.github.com>

mmathieum · 2026-02-19T14:41:42Z

/gemini review

gemini-code-assist

Code Review

This pull request introduces a significant and beneficial change to the publishing logic, moving from publishing to a single track to a full promotion pipeline across alpha, beta, and production when configured. It also correctly changes the exit behavior to success when no user tracks are found. However, the PR title and description are understated and don't fully capture the scope of these changes. It would be helpful to update them to better reflect the new promotion pipeline logic for future reference. I've also pointed out a couple of minor indentation issues in the code that should be addressed for readability.

- commons: Build(deps): Bump com.google.android.gms:play-services-ads from 24.9.0 to 25.0.0 in the gms group mtransitapps/commons#580 - commons: Update script to skip publishing if no current users mtransitapps/commons#582 - commons-android: Update network command to hide WiFi and show 5G mtransitapps/commons-android#67

- commons: Build(deps): Bump com.google.android.gms:play-services-ads from 24.9.0 to 25.0.0 in the gms group mtransitapps/commons#580 - commons: Update script to skip publishing if no current users mtransitapps/commons#582 - commons: Build(deps): Bump android-gradlePlugin from 9.0.0 to 9.0.1 mtransitapps/commons#581 - commons: Build(deps): Bump com.google.devtools.ksp from 2.3.5 to 2.3.6 in the kotlin-ksp-compose group mtransitapps/commons#579 - commons: Address comment from mtransitapps/commons#576 - commons: CI > release workflow mtransitapps/commons#576 - commons: FF ON to export Vehicle Location providers in module apps mtransitapps/commons#556 - commons: CI > Enable/disable Store channels mtransitapps/commons#573 - commons-android: Modify network command broadcasts for demo - commons-android: Update network command to hide WiFi and show 5G mtransitapps/commons-android#67 - commons-android: Adjust sleep duration based on CI environment mtransitapps/commons-android#66 - commons-android: Shell > generate all screenshots mtransitapps/commons-android#65 - commons-android: YouTube providers > clean severity&noteworthy defaults - commons-android: Twitter/RSS providers > clean severity&noteworthy defaults - commons-java: Strings cleaner > FR support

…parser': - commons: Build(deps): Bump com.google.android.gms:play-services-ads from 24.9.0 to 25.0.0 in the gms group mtransitapps/commons#580 - commons: Update script to skip publishing if no current users mtransitapps/commons#582 - commons: Build(deps): Bump android-gradlePlugin from 9.0.0 to 9.0.1 mtransitapps/commons#581 - commons: Build(deps): Bump com.google.devtools.ksp from 2.3.5 to 2.3.6 in the kotlin-ksp-compose group mtransitapps/commons#579 - commons: Address comment from mtransitapps/commons#576 - commons: CI > release workflow mtransitapps/commons#576 - commons: FF ON to export Vehicle Location providers in module apps mtransitapps/commons#556 - commons: CI > Enable/disable Store channels mtransitapps/commons#573 - commons-android: Modify network command broadcasts for demo - commons-android: Update network command to hide WiFi and show 5G mtransitapps/commons-android#67 - commons-android: Adjust sleep duration based on CI environment mtransitapps/commons-android#66 - commons-android: Shell > generate all screenshots mtransitapps/commons-android#65 - commons-android: YouTube providers > clean severity&noteworthy defaults - commons-android: Twitter/RSS providers > clean severity&noteworthy defaults - commons-java: Strings cleaner > FR support - parser: Set default value for routeId in RouteColor data class - parser: JSON config > fail parsing if invalid (missing:OK), add "route_id_to_route_short_name_configs", "direction_splitter_enabled", "stop_headsign_cleanup_regex" ...

- commons: Build(deps): Bump com.google.android.gms:play-services-ads from 24.9.0 to 25.0.0 in the gms group mtransitapps/commons#580 - commons: Update script to skip publishing if no current users mtransitapps/commons#582 - commons: Build(deps): Bump android-gradlePlugin from 9.0.0 to 9.0.1 mtransitapps/commons#581 - commons: Build(deps): Bump com.google.devtools.ksp from 2.3.5 to 2.3.6 in the kotlin-ksp-compose group mtransitapps/commons#579 - commons: Address comment from mtransitapps/commons#576 - commons: CI > release workflow mtransitapps/commons#576 - commons: FF ON to export Vehicle Location providers in module apps mtransitapps/commons#556 - commons: CI > Enable/disable Store channels mtransitapps/commons#573 - commons-android: RSS news > use link (regex+format) to generate date (no `pubDate`) #BCTransit mtransitapps/commons-android#68 - commons-android: Modify network command broadcasts for demo - commons-android: Update network command to hide WiFi and show 5G mtransitapps/commons-android#67 - commons-android: Adjust sleep duration based on CI environment mtransitapps/commons-android#66 - commons-android: Shell > generate all screenshots mtransitapps/commons-android#65 - commons-android: YouTube providers > clean severity&noteworthy defaults - commons-android: Twitter/RSS providers > clean severity&noteworthy defaults - commons-java: Strings cleaner > FR support

- commons: Add allowNonDefault input to mt-release workflow mtransitapps/commons#587 - commons: Add workflow inputs to skip store releases in mt-release.yml mtransitapps/commons#586 - commons: Build(deps): Bump com.google.android.gms:play-services-ads from 24.9.0 to 25.0.0 in the gms group mtransitapps/commons#580 - commons: Update script to skip publishing if no current users mtransitapps/commons#582 - commons: Build(deps): Bump android-gradlePlugin from 9.0.0 to 9.0.1 mtransitapps/commons#581 - commons: Build(deps): Bump com.google.devtools.ksp from 2.3.5 to 2.3.6 in the kotlin-ksp-compose group mtransitapps/commons#579 - commons: Address comment from mtransitapps/commons#576 - commons: CI > release workflow mtransitapps/commons#576 - commons-android: RSS news > use link (regex+format) to generate date (no `pubDate`) #BCTransit mtransitapps/commons-android#68 - commons-android: Modify network command broadcasts for demo - commons-android: Update network command to hide WiFi and show 5G mtransitapps/commons-android#67 - commons-android: Adjust sleep duration based on CI environment mtransitapps/commons-android#66 - commons-android: Shell > generate all screenshots mtransitapps/commons-android#65 - parser: Migrate GTFS documentation links from developers.google.com to gtfs.org mtransitapps/parser#37 - parser: Set default value for routeId in RouteColor data class

…er': - commons: Add allowNonDefault input to mt-release workflow mtransitapps/commons#587 - commons: Add workflow inputs to skip store releases in mt-release.yml mtransitapps/commons#586 - commons: Build(deps): Bump com.google.android.gms:play-services-ads from 24.9.0 to 25.0.0 in the gms group mtransitapps/commons#580 - commons: Update script to skip publishing if no current users mtransitapps/commons#582 - commons: Build(deps): Bump android-gradlePlugin from 9.0.0 to 9.0.1 mtransitapps/commons#581 - commons: Build(deps): Bump com.google.devtools.ksp from 2.3.5 to 2.3.6 in the kotlin-ksp-compose group mtransitapps/commons#579 - commons: Address comment from mtransitapps/commons#576 - commons: CI > release workflow mtransitapps/commons#576 - commons: FF ON to export Vehicle Location providers in module apps mtransitapps/commons#556 - commons: CI > Enable/disable Store channels mtransitapps/commons#573 - commons-android: RSS news > use link (regex+format) to generate date (no `pubDate`) #BCTransit mtransitapps/commons-android#68 - commons-android: Modify network command broadcasts for demo - commons-android: Update network command to hide WiFi and show 5G mtransitapps/commons-android#67 - commons-android: Adjust sleep duration based on CI environment mtransitapps/commons-android#66 - commons-android: Shell > generate all screenshots mtransitapps/commons-android#65 - commons-android: YouTube providers > clean severity&noteworthy defaults - commons-android: Twitter/RSS providers > clean severity&noteworthy defaults - commons-java: Strings cleaner > FR support - parser: Migrate GTFS documentation links from developers.google.com to gtfs.org mtransitapps/parser#37 - parser: Set default value for routeId in RouteColor data class - parser: JSON config > fail parsing if invalid (missing:OK), add "route_id_to_route_short_name_configs", "direction_splitter_enabled", "stop_headsign_cleanup_regex" ...

- commons: CI > screenshots > fix no module APK when built - commons: CI > screenshots > fix no module APK log - commons: CI > screenshots > fix no module APK - commons: Add build-from-source fallback for screenshot workflow when no release exists mtransitapps/commons#588 - commons: Add workflow for recording Android screenshots with hardware-accelerated emulator mtransitapps/commons#578 - commons: Add allowNonDefault input to mt-release workflow mtransitapps/commons#587 - commons: Add workflow inputs to skip store releases in mt-release.yml mtransitapps/commons#586 - commons: Build(deps): Bump com.google.android.gms:play-services-ads from 24.9.0 to 25.0.0 in the gms group mtransitapps/commons#580 - commons: Update script to skip publishing if no current users mtransitapps/commons#582 - commons: Build(deps): Bump android-gradlePlugin from 9.0.0 to 9.0.1 mtransitapps/commons#581 - commons: Build(deps): Bump com.google.devtools.ksp from 2.3.5 to 2.3.6 in the kotlin-ksp-compose group mtransitapps/commons#579 - commons: Address comment from mtransitapps/commons#576 - commons: CI > release workflow mtransitapps/commons#576 - commons: FF ON to export Vehicle Location providers in module apps mtransitapps/commons#556 - commons: CI > Enable/disable Store channels mtransitapps/commons#573 - commons-android: RSS news > use link (regex+format) to generate date (no `pubDate`) #BCTransit mtransitapps/commons-android#68 - commons-android: Modify network command broadcasts for demo - commons-android: Update network command to hide WiFi and show 5G mtransitapps/commons-android#67 - commons-android: Adjust sleep duration based on CI environment mtransitapps/commons-android#66 - commons-android: Shell > generate all screenshots mtransitapps/commons-android#65 - commons-android: YouTube providers > clean severity&noteworthy defaults - commons-android: Twitter/RSS providers > clean severity&noteworthy defaults - commons-java: Strings cleaner > FR support

…parser': - commons: CI > screenshots > fix no module APK when built - commons: CI > screenshots > fix no module APK log - commons: CI > screenshots > fix no module APK - commons: Add build-from-source fallback for screenshot workflow when no release exists mtransitapps/commons#588 - commons: Add workflow for recording Android screenshots with hardware-accelerated emulator mtransitapps/commons#578 - commons: Add allowNonDefault input to mt-release workflow mtransitapps/commons#587 - commons: Add workflow inputs to skip store releases in mt-release.yml mtransitapps/commons#586 - commons: Build(deps): Bump com.google.android.gms:play-services-ads from 24.9.0 to 25.0.0 in the gms group mtransitapps/commons#580 - commons: Update script to skip publishing if no current users mtransitapps/commons#582 - commons: Build(deps): Bump android-gradlePlugin from 9.0.0 to 9.0.1 mtransitapps/commons#581 - commons: Build(deps): Bump com.google.devtools.ksp from 2.3.5 to 2.3.6 in the kotlin-ksp-compose group mtransitapps/commons#579 - commons: Address comment from mtransitapps/commons#576 - commons: CI > release workflow mtransitapps/commons#576 - commons: FF ON to export Vehicle Location providers in module apps mtransitapps/commons#556 - commons: CI > Enable/disable Store channels mtransitapps/commons#573 - commons-android: RSS news > use link (regex+format) to generate date (no `pubDate`) #BCTransit mtransitapps/commons-android#68 - commons-android: Modify network command broadcasts for demo - commons-android: Update network command to hide WiFi and show 5G mtransitapps/commons-android#67 - commons-android: Adjust sleep duration based on CI environment mtransitapps/commons-android#66 - commons-android: Shell > generate all screenshots mtransitapps/commons-android#65 - commons-android: YouTube providers > clean severity&noteworthy defaults - commons-android: Twitter/RSS providers > clean severity&noteworthy defaults - commons-java: Strings cleaner > FR support - parser: Migrate GTFS documentation links from developers.google.com to gtfs.org mtransitapps/parser#37 - parser: Set default value for routeId in RouteColor data class - parser: JSON config > fail parsing if invalid (missing:OK), add "route_id_to_route_short_name_configs", "direction_splitter_enabled", "stop_headsign_cleanup_regex" ...

Update script to skip publishing if no current users

17de384

Change error handling for missing current users to success.

mmathieum self-assigned this Feb 19, 2026

gemini-code-assist Bot reviewed Feb 19, 2026

View reviewed changes

Comment thread shared/app-android/publish_to_current_users.sh

mmathieum commented Feb 19, 2026

View reviewed changes

Comment thread shared/app-android/publish_to_current_users.sh Outdated

Copilot AI mentioned this pull request Feb 19, 2026

Condense 3-line if statement to single line using && operator #583

Merged

Copilot AI and others added 2 commits February 19, 2026 09:10

Refactor exit handling in publish script

6a8ed75

mmathieum commented Feb 19, 2026

View reviewed changes

Comment thread shared/app-android/publish_to_current_users.sh Outdated

Copilot AI mentioned this pull request Feb 19, 2026

Remove unnecessary RESULT variable in publish_to_current_users.sh #584

Merged

Copilot AI and others added 2 commits February 19, 2026 09:25

Enhance publish script with production promotion logic

0af69c3

Updated publish_to_current_users.sh to include production promotion for alpha and private-beta users, with error handling for each publish step.

gemini-code-assist Bot reviewed Feb 19, 2026

View reviewed changes

Comment thread shared/app-android/publish_to_current_users.sh Outdated

Comment thread shared/app-android/publish_to_current_users.sh Outdated

mmathieum and others added 2 commits February 19, 2026 09:41

Update shared/app-android/publish_to_current_users.sh

031349d

Co-authored-by: gemini-code-assist[bot] <176961590+gemini-code-assist[bot]@users.noreply.github.com>

Update shared/app-android/publish_to_current_users.sh

446b74a

Co-authored-by: gemini-code-assist[bot] <176961590+gemini-code-assist[bot]@users.noreply.github.com>

mmathieum marked this pull request as ready for review February 19, 2026 14:41

gemini-code-assist Bot reviewed Feb 19, 2026

View reviewed changes

Comment thread shared/app-android/publish_to_current_users.sh Outdated

Comment thread shared/app-android/publish_to_current_users.sh Outdated

Fix indentation in publish_to_current_users.sh

3e454da

mmathieum merged commit 969aa2e into master Feb 19, 2026
4 checks passed

mmathieum deleted the mm/skip_no_current_users_instead_or_error branch February 19, 2026 14:57

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Update script to skip publishing if no current users#582

Update script to skip publishing if no current users#582
mmathieum merged 8 commits into
masterfrom
mm/skip_no_current_users_instead_or_error

mmathieum commented Feb 19, 2026

Uh oh!

gemini-code-assist Bot commented Feb 19, 2026

Uh oh!

gemini-code-assist Bot left a comment

Uh oh!

Uh oh!

Uh oh!

Copilot AI commented Feb 19, 2026

Uh oh!

Uh oh!

Copilot AI commented Feb 19, 2026

Uh oh!

mmathieum commented Feb 19, 2026

Uh oh!

gemini-code-assist Bot left a comment

Uh oh!

Uh oh!

Uh oh!

mmathieum commented Feb 19, 2026

Uh oh!

gemini-code-assist Bot left a comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants

Conversation

mmathieum commented Feb 19, 2026

Uh oh!

gemini-code-assist Bot commented Feb 19, 2026

Summary of Changes

Highlights

Footnotes

Uh oh!

gemini-code-assist Bot left a comment

Choose a reason for hiding this comment

Code Review

Uh oh!

Uh oh!

Uh oh!

Copilot AI commented Feb 19, 2026

Uh oh!

Uh oh!

Copilot AI commented Feb 19, 2026

Uh oh!

mmathieum commented Feb 19, 2026

Uh oh!

gemini-code-assist Bot left a comment

Choose a reason for hiding this comment

Code Review

Uh oh!

Uh oh!

Uh oh!

mmathieum commented Feb 19, 2026

Uh oh!

gemini-code-assist Bot left a comment

Choose a reason for hiding this comment

Code Review

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants